diff mbox series

m68k: allow PM menu options for COMPILE_TEST

Message ID 20230209010635.24016-1-rdunlap@infradead.org
State New
Headers
Series m68k: allow PM menu options for COMPILE_TEST |

Commit Message

Randy Dunlap Feb. 9, 2023, 1:06 a.m. UTC 
  Allow PM options for COMPILE_TEST. This quietens a kconfig
warning.

This is similar to a patch for Sparc32 that was suggested by
Arnd.

WARNING: unmet direct dependencies detected for PM
  Depends on [n]: !MMU [=y]
  Selected by [y]:
  - SUN20I_PPU [=y] && (ARCH_SUNXI || COMPILE_TEST [=y])

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
---
 arch/m68k/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Feb. 9, 2023, 2:03 p.m. UTC | #1 
Hi Randy,

On Thu, Feb 9, 2023 at 2:06 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Allow PM options for COMPILE_TEST. This quietens a kconfig
> warning.
>
> This is similar to a patch for Sparc32 that was suggested by
> Arnd.
>
> WARNING: unmet direct dependencies detected for PM
>   Depends on [n]: !MMU [=y]
>   Selected by [y]:
>   - SUN20I_PPU [=y] && (ARCH_SUNXI || COMPILE_TEST [=y])
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Thanks for your patch!

> --- a/arch/m68k/Kconfig
> +++ b/arch/m68k/Kconfig
> @@ -126,7 +126,7 @@ menu "Kernel Features"
>
>  endmenu
>
> -if !MMU
> +if !MMU || COMPILE_TEST
>  menu "Power management options"

I think this is the wrong solution.
All other selects of PM are done by architecture/platform-gating
symbols, and none of them can be enabled for compile-testing.

So either SUN20I_PPU should depend on PM, or ARCH_SUNXI
should select PM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Randy Dunlap Feb. 9, 2023, 5:09 p.m. UTC | #2 
Hi Geert,

On 2/9/23 06:03, Geert Uytterhoeven wrote:
> Hi Randy,
> 
> On Thu, Feb 9, 2023 at 2:06 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> Allow PM options for COMPILE_TEST. This quietens a kconfig
>> warning.
>>
>> This is similar to a patch for Sparc32 that was suggested by
>> Arnd.
>>
>> WARNING: unmet direct dependencies detected for PM
>>   Depends on [n]: !MMU [=y]
>>   Selected by [y]:
>>   - SUN20I_PPU [=y] && (ARCH_SUNXI || COMPILE_TEST [=y])
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> 
> Thanks for your patch!
> 
>> --- a/arch/m68k/Kconfig
>> +++ b/arch/m68k/Kconfig
>> @@ -126,7 +126,7 @@ menu "Kernel Features"
>>
>>  endmenu
>>
>> -if !MMU
>> +if !MMU || COMPILE_TEST
>>  menu "Power management options"
> 
> I think this is the wrong solution.
> All other selects of PM are done by architecture/platform-gating

Yes, which is where they should be.

> symbols, and none of them can be enabled for compile-testing.
> 
> So either SUN20I_PPU should depend on PM, or ARCH_SUNXI
> should select PM.

I'll do the first choice since I shouldn't be the one to make
a platform config change without knowing about the platform.

Thank you.
diff mbox series

Patch

diff -- a/arch/m68k/Kconfig b/arch/m68k/Kconfig
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -126,7 +126,7 @@  menu "Kernel Features"
 
 endmenu
 
-if !MMU
+if !MMU || COMPILE_TEST
 menu "Power management options"
 
 config PM