[1/2] dt-bindings: soc: renesas: renesas.yaml: add renesas,rzn1d400-eb compatible

Message ID 20230207145444.166950-2-clement.leger@bootlin.com
State New
Headers
Series ARM: dts: add device-tree and bindings for renesas,rzn1d400-eb |

Commit Message

Clément Léger Feb. 7, 2023, 2:54 p.m. UTC
  Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB
daughter board is plugged on it.

Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
 Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

Rob Herring Feb. 8, 2023, 11:45 p.m. UTC | #1
On Tue, 07 Feb 2023 15:54:43 +0100, Clément Léger wrote:
> Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB
> daughter board is plugged on it.
> 
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  Documentation/devicetree/bindings/soc/renesas/renesas.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
  
Geert Uytterhoeven Feb. 9, 2023, 8:48 a.m. UTC | #2
Hi Clément,

On Tue, Feb 7, 2023 at 3:52 PM Clément Léger <clement.leger@bootlin.com> wrote:
> Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB
> daughter board is plugged on it.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -431,6 +431,12 @@ properties:
>                - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
>            - const: renesas,r9a06g032
>
> +      - description: RZ/N1{D,S} EB
> +        items:
> +          - enum:
> +              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
> +          - const: renesas,r9a06g032

Don't you want to have "renesas,rzn1d400-db", too, in between the two
other values?

> +
>        - description: RZ/Five and RZ/G2UL (R9A07G043)
>          items:
>            - enum:

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
  
Geert Uytterhoeven Feb. 9, 2023, 1:15 p.m. UTC | #3
Hi Clément,

On Thu, Feb 9, 2023 at 2:13 PM Clément Léger <clement.leger@bootlin.com> wrote:
> Le Thu, 9 Feb 2023 09:48:09 +0100,
> Geert Uytterhoeven <geert@linux-m68k.org> a écrit :
> > On Tue, Feb 7, 2023 at 3:52 PM Clément Léger <clement.leger@bootlin.com> wrote:
> > > Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB
> > > daughter board is plugged on it.
> > >
> > > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > > @@ -431,6 +431,12 @@ properties:
> > >                - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
> > >            - const: renesas,r9a06g032
> > >
> > > +      - description: RZ/N1{D,S} EB
> > > +        items:
> > > +          - enum:
> > > +              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
> > > +          - const: renesas,r9a06g032
> >
> > Don't you want to have "renesas,rzn1d400-db", too, in between the two
> > other values?
>
> Do you mean like that ?
>
>  - enum:
>     - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a
>    RZN1D-DB)
>  - const: renesas,rzn1d400-db
>  - const: renesas,r9a06g032
>
> And thus using compatible = "renesas,rzn1d400-eb",
> "renesas,rzn1d400-db", "renesas,r9a06g032" in the EB dt I guess.

Exactly!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
  
Clément Léger Feb. 9, 2023, 1:16 p.m. UTC | #4
Le Thu, 9 Feb 2023 09:48:09 +0100,
Geert Uytterhoeven <geert@linux-m68k.org> a écrit :

> Hi Clément,
> 
> On Tue, Feb 7, 2023 at 3:52 PM Clément Léger <clement.leger@bootlin.com> wrote:
> > Add "renesas,rzn1d400-eb" which target the RZ/N1 EB board when a RZ/N1D-DB
> > daughter board is plugged on it.
> >
> > Signed-off-by: Clément Léger <clement.leger@bootlin.com>  
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > @@ -431,6 +431,12 @@ properties:
> >                - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
> >            - const: renesas,r9a06g032
> >
> > +      - description: RZ/N1{D,S} EB
> > +        items:
> > +          - enum:
> > +              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
> > +          - const: renesas,r9a06g032  
> 
> Don't you want to have "renesas,rzn1d400-db", too, in between the two
> other values?

Do you mean like that ?

 - enum:
    - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a
   RZN1D-DB)
 - const: renesas,rzn1d400-db
 - const: renesas,r9a06g032

And thus using compatible = "renesas,rzn1d400-eb",
"renesas,rzn1d400-db", "renesas,r9a06g032" in the EB dt I guess.

Thanks,

> 
> > +
> >        - description: RZ/Five and RZ/G2UL (R9A07G043)
> >          items:
> >            - enum:  
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
  

Patch

diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
index 2789022b52eb..c31b10e5f44e 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
@@ -431,6 +431,12 @@  properties:
               - renesas,rzn1d400-db # RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package)
           - const: renesas,r9a06g032
 
+      - description: RZ/N1{D,S} EB
+        items:
+          - enum:
+              - renesas,rzn1d400-eb # RZN1D-EB (Expansion Board when using a RZN1D-DB)
+          - const: renesas,r9a06g032
+
       - description: RZ/Five and RZ/G2UL (R9A07G043)
         items:
           - enum: