| Message ID | 20230209014052.17654-1-hayashi.kunihiko@socionext.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp62624wrn;
Wed, 8 Feb 2023 17:49:39 -0800 (PST)
X-Google-Smtp-Source:
AK7set8BGkyXZq35ev0TQDOy74crPCNLmlYTGWCSQghlz4/FNuJglvKfo56lDE0d89cYvzX07nhi
X-Received: by 2002:a17:902:680b:b0:199:3f82:ef62 with SMTP id
h11-20020a170902680b00b001993f82ef62mr5794677plk.5.1675907379527;
Wed, 08 Feb 2023 17:49:39 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675907379; cv=none;
d=google.com; s=arc-20160816;
b=hre9v9tDeUfMNVPUVkU8hV16HRg75s9Nt7G/7sGU4lrQ3lUyREUTJ5HynpBzPtM7eu
RFmQp14ANE184fBMsH03+Fe25L5uupvrIvFzVvA3nWkDWfKTJM8py1AbLavdOEDzxbzS
gJJl0hT2v8zhubDqKgmlNYMGpK6AO2OUjqSPXl2iorWVgioRT6bURj9SR6/AhxUiLiDt
t06CBUxsnoARpS3l6epyQ0dACwdjooFyEgqmlAEUtUmXQq+nfqMH2yFxNQiZD+mgWmuu
R7LOysGZ4qCIhx210lpf1lZ8myhsZT36XOhl3PwwMOLl+DaWbVhfsG4YwlZD4bdRkVBn
lrxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=K4JYOABVCoarsL7bSMRotxgPJcG87GLzlIQqsNJ9lDM=;
b=h0zGttF+m721bTrHLdQf4RXjLKBcr44gmI3DSOyQF+GqzKjtHXt1Er1p4pRwvLWGhv
NV5O2P29uqYaI8Z1/ftClP7OIv6MXOVDqXfstgMa0Dh0CAiS/eCL6GpohllnZ1kK7Heq
tKkyFupokEsEIrdLNKhu1p66HvWEwbSbyVvb+mKnLSnAQKsqSOzALoHCaxQpcFNzDc2g
c+zNPBJiyLDHlbzUhb9zYOAl55nj4BxpGy+8bvjmRuEBsRkj0ZzRVjsL/4Tlez/YyZb6
f46s43NXYyuiWw308wdMFaz28UJXgwlKj0vFi8/UNiDHYKI4jFUvpQEZF4Zz/dBAlcOS
rZzw==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
x10-20020a170902ea8a00b00198f9ca1352si317577plb.101.2023.02.08.17.49.24;
Wed, 08 Feb 2023 17:49:39 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231402AbjBIBk6 (ORCPT <rfc822;ivan.orlov0322@gmail.com>
+ 99 others); Wed, 8 Feb 2023 20:40:58 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33582 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229911AbjBIBk4 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 8 Feb 2023 20:40:56 -0500
Received: from mx.socionext.com (mx.socionext.com [202.248.49.38])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0AC8B20D39;
Wed, 8 Feb 2023 17:40:54 -0800 (PST)
Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52])
by mx.socionext.com with ESMTP; 09 Feb 2023 10:40:54 +0900
Received: from mail.mfilter.local (m-filter-2 [10.213.24.62])
by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id 456DC2019752;
Thu, 9 Feb 2023 10:40:54 +0900 (JST)
Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP;
Thu, 9 Feb 2023 10:40:47 +0900
Received: from plum.e01.socionext.com (unknown [10.212.243.119])
by kinkan2.css.socionext.com (Postfix) with ESMTP id 9D3903D57;
Thu, 9 Feb 2023 10:40:53 +0900 (JST)
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Subject: [PATCH] dt-bindings: ata: Add UniPhier controller binding
Date: Thu, 9 Feb 2023 10:40:52 +0900
Message-Id: <20230209014052.17654-1-hayashi.kunihiko@socionext.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757316256477347779?=
X-GMAIL-MSGID: =?utf-8?q?1757316256477347779?=
|
| Series |
dt-bindings: ata: Add UniPhier controller binding
|
|
Commit Message
Kunihiko Hayashi
Feb. 9, 2023, 1:40 a.m. UTC
Add UniPhier SATA controller compatible string to the platform binding.
This controller needs two reset controls.
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
Documentation/devicetree/bindings/ata/ahci-platform.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
On 09/02/2023 02:40, Kunihiko Hayashi wrote: > Add UniPhier SATA controller compatible string to the platform binding. > This controller needs two reset controls. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > Documentation/devicetree/bindings/ata/ahci-platform.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml > index 7dc2a2e8f598..3f6b21032d02 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml > +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml > @@ -45,6 +45,9 @@ properties: > - marvell,armada-8k-ahci > - marvell,berlin2-ahci > - marvell,berlin2q-ahci > + - socionext,uniphier-pro4-ahci > + - socionext,uniphier-pxs2-ahci > + - socionext,uniphier-pxs3-ahci > - const: generic-ahci > - enum: > - cavium,octeon-7130-ahci > @@ -74,7 +77,8 @@ properties: > maxItems: 1 > > resets: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 You now allow two resets for each other platform, which is not justified in commit msg. Constrain it per device/compatible. Best regards, Krzysztof
Hi Krzysztof, Thank you for reviewing. On 2023/02/09 17:51, Krzysztof Kozlowski wrote: > On 09/02/2023 02:40, Kunihiko Hayashi wrote: >> Add UniPhier SATA controller compatible string to the platform binding. >> This controller needs two reset controls. >> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> --- >> Documentation/devicetree/bindings/ata/ahci-platform.yaml | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml >> b/Documentation/devicetree/bindings/ata/ahci-platform.yaml >> index 7dc2a2e8f598..3f6b21032d02 100644 >> --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml >> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml >> @@ -45,6 +45,9 @@ properties: >> - marvell,armada-8k-ahci >> - marvell,berlin2-ahci >> - marvell,berlin2q-ahci >> + - socionext,uniphier-pro4-ahci >> + - socionext,uniphier-pxs2-ahci >> + - socionext,uniphier-pxs3-ahci >> - const: generic-ahci >> - enum: >> - cavium,octeon-7130-ahci >> @@ -74,7 +77,8 @@ properties: >> maxItems: 1 >> >> resets: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 2 > > You now allow two resets for each other platform, which is not justified > in commit msg. Constrain it per device/compatible. Ah I see. I'll add if-then clause to constrain compatible instead of changing that directly. Thank you, --- Best Regards Kunihiko Hayashi
diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml index 7dc2a2e8f598..3f6b21032d02 100644 --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml @@ -45,6 +45,9 @@ properties: - marvell,armada-8k-ahci - marvell,berlin2-ahci - marvell,berlin2q-ahci + - socionext,uniphier-pro4-ahci + - socionext,uniphier-pxs2-ahci + - socionext,uniphier-pxs3-ahci - const: generic-ahci - enum: - cavium,octeon-7130-ahci @@ -74,7 +77,8 @@ properties: maxItems: 1 resets: - maxItems: 1 + minItems: 1 + maxItems: 2 patternProperties: "^sata-port@[0-9a-f]+$":