Message ID | 20230207-topic-sm8550-upstream-vtdr6130-bindings-fix-v1-1-0ba2323420c5@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2761778wrn; Tue, 7 Feb 2023 02:12:21 -0800 (PST) X-Google-Smtp-Source: AK7set/eHgsf6pzTYDVxfVbljwAVFLMptzlgN9l3Xxowon6wovBCvGkJFLMStvvUYNk0TXNCFGJU X-Received: by 2002:a05:6a21:789b:b0:b8:5881:5c3b with SMTP id bf27-20020a056a21789b00b000b858815c3bmr3109260pzc.58.1675764741104; Tue, 07 Feb 2023 02:12:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675764741; cv=none; d=google.com; s=arc-20160816; b=LzKiu0XBLZ4H28N4eObYU9I3OM840277zwVNGExDG/O4fwzh1ltNJWFQP7DbPr36ND /7ntrxJzwEACFlgMTgU4WKm8Lt/OaJHyV6Xyk1pLb1wM/gqYqbl2zNeqPqfrLqnON2lh 9dTH04G4jONd0b8q0Xl/WiTVWmTJPd5XlEHLIkEJLbJJxQ/TWKUdgHdCUhxmzTe9UTkV EbOHTC36Ux/xh7Ul1jzm+QMgclFls7lVgqSySon552Ns4EPgyAG7PC9UA1Gqie1k7Hs/ vA6Blls+8UyWYaeJPcw7X+AgeEDvdj8ok2Vlurp3QutvtWiNeSCFp0MW/8z/hqF2vqgJ 3yzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=gpHlh5Hc8HFV1dKj42GmS34FxgEk0w80gWXPPnxKJac=; b=b2P5F5YcnRezlg/cWCPALi28QFrBFktemudPpohzk+gsHRsswq4dN4csF5TT2nojA8 0HqBD7OwH5TLE4Hf5Y3Fr7k4y2T/C/4mWZ4nQzcw03IvTdJH4kLBLfocU/QU3rQWYtM2 v5JMSONeSd4hnAGH9LH9wfxo4EM32+aM5DoSuAyblRCR2Hi/sa6Gd/O7TZ+wFxWoBvRe K0pVWcgWywmBsr+NCYNUuu2tHNTUac2F6S79f7yqJrk8I/Agayzg6pV7/+oW8Vstv+MC GxUTyoySCrByK3WVQ8hv0RFLguAQzOTmoEKSIl12d8t7MEf21q7rxnDZaPHk/VU5VKZn /WGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vOLbC+sD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r14-20020a63b10e000000b004ba7c76900dsi15837880pgf.488.2023.02.07.02.12.08; Tue, 07 Feb 2023 02:12:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vOLbC+sD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231324AbjBGKEm (ORCPT <rfc822;kmanaouilinux@gmail.com> + 99 others); Tue, 7 Feb 2023 05:04:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229984AbjBGKEk (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Feb 2023 05:04:40 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ECCEE0 for <linux-kernel@vger.kernel.org>; Tue, 7 Feb 2023 02:04:39 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id u10so7574671wmj.3 for <linux-kernel@vger.kernel.org>; Tue, 07 Feb 2023 02:04:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=gpHlh5Hc8HFV1dKj42GmS34FxgEk0w80gWXPPnxKJac=; b=vOLbC+sDtxDzaimA/wUBYKCPICLToLbGet/ShAWYj7TgtzxvGr+pyvCelqUrPWcR8B Z8wH2rIeBw4IzZ36XWtP1ABuZ9XsKxqQQIoDosl/qup490k1MnCRYS/lpIbEZXYzPoGI vLK4EWkDXzVtRs7go3WxFy5/8HLLUVwMKeD+F9lsQNSmPWKkyIHNu7vfUtQociyAlYYk 2MD/Pz/67/NND2FV0LPDBVpBdM7jtuaHn0Zk21Apj4ZuYb6MQN8usOLQ+ip6+ECGp635 OguGGzu1zVkwCAfaiYL7poMf/1/TR8LAwSIEoSFOkLPfrwthm2yEYws+XXSkCt3ucD/o 48vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gpHlh5Hc8HFV1dKj42GmS34FxgEk0w80gWXPPnxKJac=; b=dszY6D54Mwt/sVd3YnVl3j3PbxU3LxCpoubMefUAbg8vCrY6wKZ6IwFKRsHxbiTTjK oSbkHyrhH7VgKgB/Ky/rYJZGqUUafHVbjZk17cFI+EQV0IpebyvoJHFlyv2FVdeu5Wm6 RvVnPMiD9JDEJd7Wv5wR7CieSP4tHfFq2WVMTtNF3plECKHOJpGgA5rk1otuTiqMlYu1 YOywxK8JVyWLOTxThZOEl1tFb26rc2RWz5TcE0jFVlpuc5DD0dHw9OreAWIfECT3UDXe jlLyrdgG+ydJ+rFAKTK3s1YakkYpV17og9KM9h4+fp145xd8dumRgZP8rC0l/aPxFJN7 bVNA== X-Gm-Message-State: AO0yUKWln391zb+1y0iaptGy8iQy9Cs/BtEM/8FFB2Z5CFbmo07Wbz5o ump7l4CVFEX5UI05+ayFDg4JYQ== X-Received: by 2002:a05:600c:44d4:b0:3df:e69a:2175 with SMTP id f20-20020a05600c44d400b003dfe69a2175mr1495969wmo.35.1675764278045; Tue, 07 Feb 2023 02:04:38 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:8261:5fff:fe11:bdda]) by smtp.gmail.com with ESMTPSA id t6-20020a05600c450600b003dc433bb5e1sm14334052wmo.9.2023.02.07.02.04.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 02:04:37 -0800 (PST) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Tue, 07 Feb 2023 11:04:36 +0100 Subject: [PATCH] dt-bindings: display: panel: visionox,vtdr6130: add missing reg property MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230207-topic-sm8550-upstream-vtdr6130-bindings-fix-v1-1-0ba2323420c5@linaro.org> X-B4-Tracking: v=1; b=H4sIADMi4mMC/x2OywqDMBBFf0Wy7sAkwbT0V0oXeYw6oFEyUQTx3 xu6PIfL4V5KqDCJeneXKnSw8Job6Een4uTzSMCpsTJoLBp8Ql03jiDLq+8R9k1qIb/AUVNx2iI EzonzKDDwCV4n4yzSENGpVgxeCELxOU6tmfd5bnIr1Lb/C5/vff8A53XTL5IAAAA= To: Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.12.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757166689145872579?= X-GMAIL-MSGID: =?utf-8?q?1757166689145872579?= |
Series |
dt-bindings: display: panel: visionox,vtdr6130: add missing reg property
|
|
Commit Message
Neil Armstrong
Feb. 7, 2023, 10:04 a.m. UTC
Add missing reg property and update example to add dsi top node.
Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel")
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../bindings/display/panel/visionox,vtdr6130.yaml | 34 ++++++++++++++--------
1 file changed, 22 insertions(+), 12 deletions(-)
---
base-commit: 49a8133221c71b935f36a7c340c0271c2a9ee2db
change-id: 20230207-topic-sm8550-upstream-vtdr6130-bindings-fix-a1d2630efc06
Best regards,
Comments
On 07/02/2023 11:04, Neil Armstrong wrote: > Add missing reg property and update example to add dsi top node. > > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Neil. On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote: > Add missing reg property and update example to add dsi top node. > > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > .../bindings/display/panel/visionox,vtdr6130.yaml | 34 ++++++++++++++-------- > 1 file changed, 22 insertions(+), 12 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > index 49e2fd4b4e99..84562a5b710a 100644 > --- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > @@ -16,6 +16,10 @@ properties: > compatible: > const: visionox,vtdr6130 > > + reg: > + maxItems: 1 > + description: DSI virtual channel > + Other panels using dsi uses a simple " reg: true" I think that would suffice here too. Sam
On Tue, Feb 07, 2023 at 07:36:00PM +0100, Sam Ravnborg wrote: > Hi Neil. > > > On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote: > > Add missing reg property and update example to add dsi top node. > > > > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel") > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > --- > > .../bindings/display/panel/visionox,vtdr6130.yaml | 34 ++++++++++++++-------- > > 1 file changed, 22 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > > index 49e2fd4b4e99..84562a5b710a 100644 > > --- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > > @@ -16,6 +16,10 @@ properties: > > compatible: > > const: visionox,vtdr6130 > > > > + reg: > > + maxItems: 1 > > + description: DSI virtual channel > > + > Other panels using dsi uses a simple > " reg: true" > > I think that would suffice here too. Yes, because dsi-controller.yaml restricts it to a single entry. However, it's description says there can be more than 1 virtual channel for a device. In that case, it shouldn't be restricted in dsi-controller.yaml and the above with 'maxItems: 1' would be correct. So I'd keep this as-is. Acked-by: Rob Herring <robh@kernel.org> Rob
On Tue, Feb 07, 2023 at 02:37:16PM -0600, Rob Herring wrote: > On Tue, Feb 07, 2023 at 07:36:00PM +0100, Sam Ravnborg wrote: > > Hi Neil. > > > > > > On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote: > > > Add missing reg property and update example to add dsi top node. > > > > > > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel") > > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > > --- > > > .../bindings/display/panel/visionox,vtdr6130.yaml | 34 ++++++++++++++-------- > > > 1 file changed, 22 insertions(+), 12 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > > > index 49e2fd4b4e99..84562a5b710a 100644 > > > --- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > > > +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml > > > @@ -16,6 +16,10 @@ properties: > > > compatible: > > > const: visionox,vtdr6130 > > > > > > + reg: > > > + maxItems: 1 > > > + description: DSI virtual channel > > > + > > Other panels using dsi uses a simple > > " reg: true" > > > > I think that would suffice here too. > > Yes, because dsi-controller.yaml restricts it to a single entry. > However, it's description says there can be more than 1 virtual channel > for a device. In that case, it shouldn't be restricted in > dsi-controller.yaml and the above with 'maxItems: 1' would be correct. > So I'd keep this as-is. Thanks for the explanation. > > Acked-by: Rob Herring <robh@kernel.org> Acked-by: Sam Ravnborg <sam@ravnborg.org>
Hi, On Tue, 07 Feb 2023 11:04:36 +0100, Neil Armstrong wrote: > Add missing reg property and update example to add dsi top node. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next-fixes) [1/1] dt-bindings: display: panel: visionox,vtdr6130: add missing reg property https://cgit.freedesktop.org/drm/drm-misc/commit/?id=467fbc77f673ecc9dcf4e58ffc1fa426a22df7fd
diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml index 49e2fd4b4e99..84562a5b710a 100644 --- a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml @@ -16,6 +16,10 @@ properties: compatible: const: visionox,vtdr6130 + reg: + maxItems: 1 + description: DSI virtual channel + vddio-supply: true vci-supply: true vdd-supply: true @@ -26,6 +30,7 @@ additionalProperties: false required: - compatible + - reg - vddio-supply - vci-supply - vdd-supply @@ -35,18 +40,23 @@ required: examples: - | #include <dt-bindings/gpio/gpio.h> - panel { - compatible = "visionox,vtdr6130"; - - vddio-supply = <&vreg_l12b_1p8>; - vci-supply = <&vreg_l13b_3p0>; - vdd-supply = <&vreg_l11b_1p2>; - - reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; - - port { - panel0_in: endpoint { - remote-endpoint = <&dsi0_out>; + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "visionox,vtdr6130"; + reg = <0>; + + vddio-supply = <&vreg_l12b_1p8>; + vci-supply = <&vreg_l13b_3p0>; + vdd-supply = <&vreg_l11b_1p2>; + + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; + + port { + panel0_in: endpoint { + remote-endpoint = <&dsi0_out>; + }; }; }; };