diff mbox series

[12/24] RISC-V: ACPI: smpboot: Create wrapper smp_setup()

Message ID	20230130182225.2471414-13-sunilvl@ventanamicro.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Sunil V L <sunilvl@ventanamicro.com> To: Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, "Rafael J . Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Jonathan Corbet <corbet@lwn.net> Cc: linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Anup Patel <apatel@ventanamicro.com>, Andrew Jones <ajones@ventanamicro.com>, Atish Patra <atishp@rivosinc.com>, Sunil V L <sunilvl@ventanamicro.com> Subject: [PATCH 12/24] RISC-V: ACPI: smpboot: Create wrapper smp_setup() Date: Mon, 30 Jan 2023 23:52:13 +0530 Message-Id: <20230130182225.2471414-13-sunilvl@ventanamicro.com> In-Reply-To: <20230130182225.2471414-1-sunilvl@ventanamicro.com> References: <20230130182225.2471414-1-sunilvl@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Add basic ACPI support for RISC-V \| [00/24] Add basic ACPI support for RISC-V [01/24] riscv: move sbi_init() earlier before jump_label_init() [02/24] ACPICA: MADT: Add RISC-V INTC interrupt controller [03/24] ACPICA: Add structure definitions for RISC-V RHCT [04/24] RISC-V: ACPI: Add empty headers to enable ACPI core [05/24] RISC-V: ACPI: Add basic functions to build ACPI core [06/24] RISC-V: ACPI: Add PCI functions to build ACPI core [07/24] RISC-V: ACPI: Enable ACPI build infrastructure [08/24] ACPI: Enable ACPI_PROCESSOR for RISC-V [09/24] ACPI: OSL: Make should_use_kmap() 0 for RISC-V. [10/24] ACPI: processor_core: RISC-V: Enable mapping processor to the hartid [11/24] RISC-V: ACPI: irqchip/riscv-intc: Add ACPI support [12/24] RISC-V: ACPI: smpboot: Create wrapper smp_setup() [13/24] RISC-V: ACPI: smpboot: Add ACPI support in smp_setup() [14/24] RISC-V: ACPI: smpboot: Add function to retrieve the hartid [15/24] clocksource/timer-riscv: Refactor riscv_timer_init_dt() [16/24] RISC-V: ACPI: clocksource/timer-riscv: Add ACPI support [17/24] ACPI: RISC-V: drivers/acpi: Add RHCT related code [18/24] RISC-V: ACPI: time.c: Add ACPI support for time_init() [19/24] RISC-V: ACPI: cpufeature: Add ACPI support in riscv_fill_hwcap() [20/24] RISC-V: ACPI: cpu: Enable cpuinfo for ACPI systems [21/24] RISC-V: ACPI: Add ACPI initialization in setup_arch() [22/24] RISC-V: ACPI: Enable ACPI in defconfig [23/24] MAINTAINERS: Add entry for drivers/acpi/riscv [24/24] Documentation/kernel-parameters.txt: Add RISC-V for ACPI parameter

Commit Message

Sunil V L Jan. 30, 2023, 6:22 p.m. UTC

  smp_setup() currently assumes DT based platforms. To enable ACPI,
first make this as a wrapper function and move existing code to
a separate DT specific function.

Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
---
 arch/riscv/kernel/smpboot.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Conor Dooley Feb. 8, 2023, 9:34 p.m. UTC | #1

On Mon, Jan 30, 2023 at 11:52:13PM +0530, Sunil V L wrote:
> Subject: RISC-V: ACPI: smpboot: Create wrapper smp_setup()

As I pointed out the other day, this one of the patches that really
doesn't warrant an ACPI: prefix.

With that fixed:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> smp_setup() currently assumes DT based platforms. To enable ACPI,
> first make this as a wrapper function and move existing code to
> a separate DT specific function.
> 
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> ---
>  arch/riscv/kernel/smpboot.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
> index 00b53913d4c6..26214ddefaa4 100644
> --- a/arch/riscv/kernel/smpboot.c
> +++ b/arch/riscv/kernel/smpboot.c
> @@ -70,7 +70,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
>  	}
>  }
>  
> -void __init setup_smp(void)
> +static void __init of_parse_and_init_cpus(void)
>  {
>  	struct device_node *dn;
>  	unsigned long hart;
> @@ -116,6 +116,11 @@ void __init setup_smp(void)
>  	}
>  }
>  
> +void __init setup_smp(void)
> +{
> +	of_parse_and_init_cpus();
> +}
> +
>  static int start_secondary_cpu(int cpu, struct task_struct *tidle)
>  {
>  	if (cpu_ops[cpu]->cpu_start)
> -- 
> 2.38.0
>

diff mbox series

Patch

diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
index 00b53913d4c6..26214ddefaa4 100644
--- a/arch/riscv/kernel/smpboot.c
+++ b/arch/riscv/kernel/smpboot.c
@@ -70,7 +70,7 @@  void __init smp_prepare_cpus(unsigned int max_cpus)
 	}
 }
 
-void __init setup_smp(void)
+static void __init of_parse_and_init_cpus(void)
 {
 	struct device_node *dn;
 	unsigned long hart;
@@ -116,6 +116,11 @@  void __init setup_smp(void)
 	}
 }
 
+void __init setup_smp(void)
+{
+	of_parse_and_init_cpus();
+}
+
 static int start_secondary_cpu(int cpu, struct task_struct *tidle)
 {
 	if (cpu_ops[cpu]->cpu_start)