| Message ID | 20230207081130.1.I657776750156793721efa247ce6293445137bc8a@changeid |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2936906wrn;
Tue, 7 Feb 2023 08:15:52 -0800 (PST)
X-Google-Smtp-Source:
AK7set/wH4HUnkXYGjtbNhXUkQUKIjRz06aA+6ENWztnqSrc9LDb2cl/Ui7lg0mxuGt4QlTCdrMN
X-Received: by 2002:a17:903:11ce:b0:196:8362:b727 with SMTP id
q14-20020a17090311ce00b001968362b727mr2988572plh.63.1675786552283;
Tue, 07 Feb 2023 08:15:52 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675786552; cv=none;
d=google.com; s=arc-20160816;
b=IaNENHtnZxF+xC2VV/dv/+GPhi4zl6hCWxTQnhST6xnF3YqVhB6NcG/+KDxrg/vkrg
m8fvh6tPhVcWtdaIXhHaxm1mjhnt3WNdJusJx33ltSzfeG2zcsG07EfDJCi3ViaEfLLA
kAgQdm7TrUEp8FxzDvgF6/BtVZs/gBivejr6CefWLSqT4C45NtasprFrO2eJnxR3v1Cj
iUsnH9qV5cd+wbKGCq1eJdTBaNNo0Em8AJOkg2DEv9QpaYEtA8Nokd4b9z2tmEFeQKfy
LRWi0zWcMgY3Z3TWm1Jq1qtFSmz2fOUbuNiOhHiLVdKfscB/esGmgSyRJbnLmbAgQDvE
Em3w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=20K67K9edwRh0ZAf2p1ADQD2Xsmwqcm4t/xw8k9j5dk=;
b=VjfxHncf1625i5ZcJ8AL0A2CtqWUK057zXiReOoSGTqcsUqIu0KPiDJq1HEqzE6Bsd
7pq3RmHM2x9BcAJjF9H+m8UWBvOLCgOYbybcNrRANTrQLjCRQhBduPWV3Jpy2NGW6tFP
uSGcn/1y92rp7iHrEgeCqvcyUE0lX/cA3WwmqyfFNSD/b7h+V3QHO7MAcWAAb/+b3gBT
vW+PC0guGB1KVy0bZsBAS7JwPqb6ynMPaaR1DynXHDrLrn8cNqGi2bufiL4SVTjK1d6k
7tPDHuz5G6cN1BzbyCR43Kr/UhCjxPVSJ5d6P7BtHm/liKJHJSI7TZD/W+AQuiTXtNv1
aI9A==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@chromium.org header.s=google header.b=AoF+pK17;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
i5-20020a170902c94500b001967688b1e8si13966453pla.613.2023.02.07.08.15.38;
Tue, 07 Feb 2023 08:15:52 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@chromium.org header.s=google header.b=AoF+pK17;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231636AbjBGQNB (ORCPT <rfc822;kmanaouilinux@gmail.com>
+ 99 others); Tue, 7 Feb 2023 11:13:01 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36054 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232005AbjBGQMm (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 7 Feb 2023 11:12:42 -0500
Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com
[IPv6:2607:f8b0:4864:20::636])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1962276A2
for <linux-kernel@vger.kernel.org>;
Tue, 7 Feb 2023 08:12:39 -0800 (PST)
Received: by mail-pl1-x636.google.com with SMTP id z1so16107602plg.6
for <linux-kernel@vger.kernel.org>;
Tue, 07 Feb 2023 08:12:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=chromium.org; s=google;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=20K67K9edwRh0ZAf2p1ADQD2Xsmwqcm4t/xw8k9j5dk=;
b=AoF+pK17KeWga6/gfHCf5yHbKRSGJFnueL7IsWIbszgBvma2IhRB52/8yoPorV3frY
0tz93kpERxaUv//F2L5fpiY6l2QIZbFFUkipoOSwguDJluQgAMUzqDoXam4zbwgixYZX
a8Q/34uIhjyoJ7hHEh9NbFk4EvLT4Nk6wMybk=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=20K67K9edwRh0ZAf2p1ADQD2Xsmwqcm4t/xw8k9j5dk=;
b=c3gCTVERsg5o9O7Y+lPHC5GBMb7mi7aonKwNx6WtwwLkdsN0eLcvWmNrka/cuAvQsr
eT2myeynEo3j0of3p1UU4VG3rMogDFbcQDba0s/fBG5046WhzhnPo8K5V2Dv1sYCK4bG
maLD/EcrJkqAN5QstjApizmuIap7Dc/BdDCgJdlz7H6plw1uc14a/bcOCscu8HqYNLL1
WISIh/yI2Xd8iTXrBWmtl+tETCnn0mFHz2eKQyLqX+Ps0f8WotAGuPuXC9BPojYjd4iH
L75ynuTmC6CgHTENJdYPjJe+cbMqzQnRscdYpshKI5Gd0aCN9cSfXz5Xgzic2FQvehvl
MyfQ==
X-Gm-Message-State: AO0yUKW6vd8h+pEIzSBd80NDI+X03PJnyozZHs9EmUGg7J1zHd+7Lnzp
Yb5Nb317Jv5wNWWrjk2XJkkZFg==
X-Received: by 2002:a17:903:1252:b0:198:adc4:22a2 with SMTP id
u18-20020a170903125200b00198adc422a2mr17215569plh.29.1675786358610;
Tue, 07 Feb 2023 08:12:38 -0800 (PST)
Received: from tictac2.mtv.corp.google.com
([2620:15c:9d:2:29fb:a635:f0df:f45a])
by smtp.gmail.com with ESMTPSA id
c4-20020a170902c1c400b00186a2dd3ffdsm9082889plc.15.2023.02.07.08.12.37
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 07 Feb 2023 08:12:38 -0800 (PST)
From: Douglas Anderson <dianders@chromium.org>
To: Benson Leung <bleung@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Julius Werner <jwerner@chromium.org>,
David Gow <davidgow@google.com>,
Jack Rosenthal <jrosenth@chromium.org>,
chrome-platform@lists.linux.dev,
Stephen Boyd <swboyd@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF
Kconfig entries
Date: Tue, 7 Feb 2023 08:12:00 -0800
Message-Id:
<20230207081130.1.I657776750156793721efa247ce6293445137bc8a@changeid>
X-Mailer: git-send-email 2.39.1.519.gcb327c4b5f-goog
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757189559562810277?=
X-GMAIL-MSGID: =?utf-8?q?1757189559562810277?=
|
| Series |
firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries
|
|
Commit Message
Doug Anderson
Feb. 7, 2023, 4:12 p.m. UTC
Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform
drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF
and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help"
text and thus aren't user choosable. They also aren't "select"ed by
anything. They also control the compilation of no code.
Let's remove them.
Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/firmware/google/Kconfig | 8 --------
1 file changed, 8 deletions(-)
Comments
On Tue, Feb 7, 2023 at 8:12 AM Douglas Anderson <dianders@chromium.org> wrote: > > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > > drivers/firmware/google/Kconfig | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig > index 9f190eab43ed..1bc7cbf2f65d 100644 > --- a/drivers/firmware/google/Kconfig > +++ b/drivers/firmware/google/Kconfig > @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE > device tree node /firmware/coreboot. > If unsure say N. > > -config GOOGLE_COREBOOT_TABLE_ACPI > - tristate > - select GOOGLE_COREBOOT_TABLE > - > -config GOOGLE_COREBOOT_TABLE_OF > - tristate > - select GOOGLE_COREBOOT_TABLE > - > config GOOGLE_MEMCONSOLE > tristate > depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT > -- > 2.39.1.519.gcb327c4b5f-goog >
On 2023-02-07 at 08:12 -0800, Douglas Anderson wrote: > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> > --- > > drivers/firmware/google/Kconfig | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig > index 9f190eab43ed..1bc7cbf2f65d 100644 > --- a/drivers/firmware/google/Kconfig > +++ b/drivers/firmware/google/Kconfig > @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE > device tree node /firmware/coreboot. > If unsure say N. > > -config GOOGLE_COREBOOT_TABLE_ACPI > - tristate > - select GOOGLE_COREBOOT_TABLE > - > -config GOOGLE_COREBOOT_TABLE_OF > - tristate > - select GOOGLE_COREBOOT_TABLE > - > config GOOGLE_MEMCONSOLE > tristate > depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT > -- > 2.39.1.519.gcb327c4b5f-goog >
Quoting Douglas Anderson (2023-02-07 08:12:00) > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > Fixes: a28aad66da8b ("firmware: coreboot: Collapse platform drivers into bus core") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- Acked-by: Stephen Boyd <swboyd@chromium.org>
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Greg Kroah-Hartman <gregkh@linuxfoundation.org>: On Tue, 7 Feb 2023 08:12:00 -0800 you wrote: > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > [...] Here is the summary with links: - firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries https://git.kernel.org/chrome-platform/c/e42af72223fd You are awesome, thank you!
Hello: This patch was applied to chrome-platform/linux.git (for-next) by Greg Kroah-Hartman <gregkh@linuxfoundation.org>: On Tue, 7 Feb 2023 08:12:00 -0800 you wrote: > Ever since commit a28aad66da8b ("firmware: coreboot: Collapse platform > drivers into bus core") the Kconfig entries GOOGLE_COREBOOT_TABLE_OF > and GOOGLE_COREBOOT_TABLE_ACPI have been dead. They have no "help" > text and thus aren't user choosable. They also aren't "select"ed by > anything. They also control the compilation of no code. > > Let's remove them. > > [...] Here is the summary with links: - firmware: coreboot: Remove GOOGLE_COREBOOT_TABLE_ACPI/OF Kconfig entries https://git.kernel.org/chrome-platform/c/e42af72223fd You are awesome, thank you!
diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig index 9f190eab43ed..1bc7cbf2f65d 100644 --- a/drivers/firmware/google/Kconfig +++ b/drivers/firmware/google/Kconfig @@ -44,14 +44,6 @@ config GOOGLE_COREBOOT_TABLE device tree node /firmware/coreboot. If unsure say N. -config GOOGLE_COREBOOT_TABLE_ACPI - tristate - select GOOGLE_COREBOOT_TABLE - -config GOOGLE_COREBOOT_TABLE_OF - tristate - select GOOGLE_COREBOOT_TABLE - config GOOGLE_MEMCONSOLE tristate depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT