Message ID | 20230208173343.37582-3-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3588633wrn; Wed, 8 Feb 2023 09:35:41 -0800 (PST) X-Google-Smtp-Source: AK7set9Mlr9u1fBX5qHsUV4COTh+fC0p4RHo3+1TJC2yxuHF4O8VWWWHTV5ZqVeYq1mcHQVhjGVU X-Received: by 2002:a17:902:d505:b0:198:e8c6:859a with SMTP id b5-20020a170902d50500b00198e8c6859amr8380978plg.0.1675877741389; Wed, 08 Feb 2023 09:35:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675877741; cv=none; d=google.com; s=arc-20160816; b=imjHNUV40+spe9k3Ze60WCsae39KHJHlgp1BxYEk64+DRf1iAJPgm0F3c06/zUvf5H OLqHoBAS5dsF+xmH8gh4GjEW0KXM6BLzeEM+l/4z5yq3RQOMl5qBZWNY3JgMXI8lN4Tu PbwzcYBCmEJNiMX5hKL6PB9pZHX0SIAUEaJuAm2qggFANr3jv2ZsHRT0FDN9II9ldnNU gDAMWmeXnCggsVFn2HE8qEFbausJuHmA434fsTv2g3vZ6AdDTHTvQGbKF9eiQSXb5YwL sGWAcOrpLDRoQmD5BTchRIm9im0bu1pLgHJsC3u66ZDXepxazsnfpo5+pDYjBsbdsXEp 4D2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=q9OVJwA69eMSRhW9tyzStHz4hrsJnSOQxDAVnAUhmkE=; b=oi1kHrk1w9N4hB9rKu70jNsIzBmTyg770v/Wzd9WUTgmN/PWZ1zMHmoOD0oueDbRkD zJfZN9XmQrtIXkHxYbyg+lCxiNaJy0VH2XtoyRkaTTnmXWjMrJl+EeiHq78kGzPNfxqR nYSX+R7vJrbwJ6sFYfLpQCot7kdAMRxpRzkfHq0opYrOw2UwV6w289xj4oK3TqmZv065 1quRDVqLcAzsLSLArGTXXKxXACPdJCMbcis0Jf7PaME/XABIw8jJSzUm0tg68uiNUsgI 2kDh4W0QIUdSyiSDsup1FmBHsZdxLcBDvkCjrznlatXE8XmjTBBS6v9/0MZ1EeUsbkGD tBfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ndMqj0wL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d21-20020a170902729500b00198e7ebf46csi15455115pll.271.2023.02.08.09.35.24; Wed, 08 Feb 2023 09:35:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ndMqj0wL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232159AbjBHRe3 (ORCPT <rfc822;ivan.orlov0322@gmail.com> + 99 others); Wed, 8 Feb 2023 12:34:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231913AbjBHReF (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 8 Feb 2023 12:34:05 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96ADF3251B; Wed, 8 Feb 2023 09:34:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675877641; x=1707413641; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bloKEk7wdB/KAamzH2f498CjQ4BYd7MQyp/8x7HupR0=; b=ndMqj0wLWnynraZ4MaSqQjmWUqDE9EKatFTzXOej52AbdsLmzrSeNx20 aUbcIyl9ImbCOVXwlKr2v9maSlZ95f1685hEjERnKz90rTozgd7IZ3LA2 VBdx6PMyPjpmzMtZNJW4hoZRsmMt2iJg888nMlvb/M6Q2Le50JGJpTduM ejGAQTgVythJgG/WxpPKsY6CDVUXa6EluO/z36jEVP5qZBhgMoIpZjisu zhQQOt0Z7AnpH9csGO6juefQ0XASW7A0/OMx6p3ENt4OhxoDwmqBOeJd2 hmf/tQW0BlcBluExU+R79G9TnunPJrvN06XyRrkA6Fg0HHj6RRcU4dXgf g==; X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="310225283" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="310225283" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2023 09:33:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10615"; a="697722976" X-IronPort-AV: E=Sophos;i="5.97,281,1669104000"; d="scan'208";a="697722976" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 08 Feb 2023 09:33:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 8B16F1F8; Wed, 8 Feb 2023 19:33:47 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, Tony Lindgren <tony@atomide.com>, Thomas Gleixner <tglx@linutronix.de>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Geert Uytterhoeven <geert@linux-m68k.org>, Michael Ellerman <mpe@ellerman.id.au>, Christophe Leroy <christophe.leroy@csgroup.eu>, Vincenzo Palazzo <vincenzopalazzodev@gmail.com>, Devarsh Thakkar <devarsht@ti.com>, Michael Walle <michael@walle.cc>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Dipen Patel <dipenp@nvidia.com>, Thierry Reding <treding@nvidia.com>, Stefan Schmidt <stefan@datenfreihafen.org>, Miquel Raynal <miquel.raynal@bootlin.com>, Lee Jones <lee@kernel.org>, linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc-tw-discuss@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-acpi@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, linux-arch@vger.kernel.org, devicetree@vger.kernel.org Cc: Bartosz Golaszewski <brgl@bgdev.pl>, Jonathan Corbet <corbet@lwn.net>, Alex Shi <alexs@kernel.org>, Yanteng Si <siyanteng@loongson.cn>, Hu Haowen <src.res@email.cn>, Russell King <linux@armlinux.org.uk>, Aaro Koskinen <aaro.koskinen@iki.fi>, Janusz Krzysztofik <jmkrzyszt@gmail.com>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Gregory Clement <gregory.clement@bootlin.com>, Alim Akhtar <alim.akhtar@samsung.com>, Nicholas Piggin <npiggin@gmail.com>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Mun Yew Tham <mun.yew.tham@intel.com>, Keerthy <j-keerthy@ti.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Alexander Aring <alex.aring@gmail.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Arend van Spriel <aspriel@gmail.com>, Franky Lin <franky.lin@broadcom.com>, Hante Meuleman <hante.meuleman@broadcom.com>, Kalle Valo <kvalo@kernel.org>, Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com> Subject: [PATCH v4 02/18] ARM: s3c24xx: Use the right include Date: Wed, 8 Feb 2023 19:33:27 +0200 Message-Id: <20230208173343.37582-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230208173343.37582-1-andriy.shevchenko@linux.intel.com> References: <20230208173343.37582-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757285178580657910?= X-GMAIL-MSGID: =?utf-8?q?1757285178580657910?= |
Series |
gpiolib cleanups
|
|
Commit Message
Andy Shevchenko
Feb. 8, 2023, 5:33 p.m. UTC
From: Linus Walleij <linus.walleij@linaro.org> The file s3c64xx.c is including <linux/gpio.h> despite using no symbols from the file, however it needs it to implicitly bring in of_have_populated_dt() so include <linux/of.h> explicitly instead. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- arch/arm/mach-s3c/s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 08/02/2023 18:33, Andy Shevchenko wrote: > From: Linus Walleij <linus.walleij@linaro.org> > > The file s3c64xx.c is including <linux/gpio.h> despite using no > symbols from the file, however it needs it to implicitly bring in > of_have_populated_dt() so include <linux/of.h> explicitly instead. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > arch/arm/mach-s3c/s3c64xx.c | 2 +- It's not s3c24xx anymore, so subject prefix: ARM: s3c64xx: Best regards, Krzysztof
On Wed, Feb 08, 2023 at 06:39:12PM +0100, Krzysztof Kozlowski wrote: > On 08/02/2023 18:33, Andy Shevchenko wrote: ... > It's not s3c24xx anymore, so subject prefix: > ARM: s3c64xx: Fixed locally, thanks.
On 08/02/2023 18:33, Andy Shevchenko wrote: > From: Linus Walleij <linus.walleij@linaro.org> > > The file s3c64xx.c is including <linux/gpio.h> despite using no > symbols from the file, however it needs it to implicitly bring in > of_have_populated_dt() so include <linux/of.h> explicitly instead. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, Feb 8, 2023 at 6:39 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 08/02/2023 18:33, Andy Shevchenko wrote: > > From: Linus Walleij <linus.walleij@linaro.org> > > > > The file s3c64xx.c is including <linux/gpio.h> despite using no > > symbols from the file, however it needs it to implicitly bring in > > of_have_populated_dt() so include <linux/of.h> explicitly instead. > > > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > arch/arm/mach-s3c/s3c64xx.c | 2 +- > > It's not s3c24xx anymore, so subject prefix: > ARM: s3c64xx: My mistake, mea culpa. Yours, Linus Walleij
diff --git a/arch/arm/mach-s3c/s3c64xx.c b/arch/arm/mach-s3c/s3c64xx.c index e97bd59083a8..9f9717874d67 100644 --- a/arch/arm/mach-s3c/s3c64xx.c +++ b/arch/arm/mach-s3c/s3c64xx.c @@ -21,13 +21,13 @@ #include <linux/ioport.h> #include <linux/serial_core.h> #include <linux/serial_s3c.h> +#include <linux/of.h> #include <linux/platform_device.h> #include <linux/reboot.h> #include <linux/io.h> #include <linux/clk/samsung.h> #include <linux/dma-mapping.h> #include <linux/irq.h> -#include <linux/gpio.h> #include <linux/irqchip/arm-vic.h> #include <clocksource/samsung_pwm.h>