Message ID | 20221021203329.4143397-9-arnd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp895360wrr; Fri, 21 Oct 2022 13:49:23 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5tuG40meAeu7MjKkD8CVjRVf5y5IN3Fnl4CaqiKr8ZEMSZ/WiOW6qHPfFQrBOVta5A9QBo X-Received: by 2002:a05:6a00:16c1:b0:563:177f:99ee with SMTP id l1-20020a056a0016c100b00563177f99eemr21242505pfc.7.1666385363496; Fri, 21 Oct 2022 13:49:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666385363; cv=none; d=google.com; s=arc-20160816; b=ZMhog4x7koVHh1sG0zCzr+UFZ59CmNjzoaPUnADcxj4Okt5b4XdKdMc2I1rNoRhtZZ 8RXAjjKx75XOQS5QB96Ig7ynVSMw7CpSForu1sryXP0Y273c14FjmDPXp/bmJmNou5Pg bKVWNvhFkmtRiOUC+C0vZoY9jtfk7vT5EABbP9m8VcVXN+prn6jOcwmDZktDX6/Q63Iq fixiEIpGCsX4jQtdN44fyzv6qWzVzVvybdjOgvYar57a6CvoYx8gB+U2+q/wfqvcB9pI TciJlK1//YQtgRrb0iTjG7zdD33poMn1tiINUmtQ8a3IqokRiyUMw5hMErN3pdiqTcDK 7Phw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ppIJQQaIVnGCsqbwwNQz9ZCXVKy9ttrzjs93uRPloDA=; b=bdin0ZT5d5CR4SH5CjXGlP/DM9iR/QuTrC3sNHi0b9MsafF8blIL61obsDlZRz/JWR NvuLjsZNVa6xzytJaG0TfGsTMrMrdudFWTg453kMxpJIRcy4oUWJGMdsa+9b62yymiiJ EBUWIDxAeSJUZYe92AhAQXuC2QQhcER+hBEnWSMvQf2Ec/cNu4jFWoYUNan87YVgPzDD 9Km6822RTo6KBzV/4nMl/6isfEiha8cN1bOrhdiNhpT3IF5941IAT6ManF0Lj7xXLw9y 4rve1E7t42Z6HMjvsHyCvDjD1YAK7mqpv+KkLQObdVC/eQHcoIv+z9JhYGp71EGDQTWp DJOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f6vZ1lB0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q62-20020a17090a17c400b001f06a6fdb2fsi712835pja.27.2022.10.21.13.49.10; Fri, 21 Oct 2022 13:49:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f6vZ1lB0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbiJUUqU (ORCPT <rfc822;mntrajkot1@gmail.com> + 99 others); Fri, 21 Oct 2022 16:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbiJUUpz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Oct 2022 16:45:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B04A12E0F3; Fri, 21 Oct 2022 13:45:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2E56D60D3F; Fri, 21 Oct 2022 20:43:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AF1EC433D6; Fri, 21 Oct 2022 20:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666385030; bh=+Wm8MnCfMgvnGrZkq/NSP4dC8FF3aoE+uGAAN10YMp4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f6vZ1lB04Q4TXb1CgW8wRsJ4HWkOrqhlckVmlf+mRNd/LcroMsYrFwPCHG1lmaUzO alsuvLolOa28fyoK6qHgIe+K73j1WCZEPyScREViZ3ckfr/xHK8OvhszHjRWbhxUTi 2SLfVgp2omGRSJm3EKjmwzCT2o5KAVMLKnSBQROO7XoA/ZnIgWwtkCZ1IA7lmyhtCS NbTvyksRyesuyfpqrQStweLjs8wuhjOJRIuUilO1CHUZaCXPJZYbonrg3dlJg6EWyL Z1peDjawp56ux1LP0A6fzreFmY75Ypd7LRBbcN+f+jzEAXam7zeXUBdI1sqtkUkgNL K6sMpHKQovFqw== From: Arnd Bergmann <arnd@kernel.org> To: linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Damien Le Moal <damien.lemoal@opensource.wdc.com> Cc: linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>, Simtec Linux Team <linux@simtec.co.uk>, Arnd Bergmann <arnd@arndb.de>, Sergey Shtylyov <s.shtylyov@omp.ru>, Hannes Reinecke <hare@suse.de>, linux-ide@vger.kernel.org Subject: [PATCH 09/21] pata: remove samsung_cf driver Date: Fri, 21 Oct 2022 22:27:42 +0200 Message-Id: <20221021203329.4143397-9-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20221021202254.4142411-1-arnd@kernel.org> References: <20221021202254.4142411-1-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747331699194601178?= X-GMAIL-MSGID: =?utf-8?q?1747331699194601178?= |
Series |
ARM: s3c: clean out obsolete platforms
|
|
Commit Message
Arnd Bergmann
Oct. 21, 2022, 8:27 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de> This device was only used by the smdk6410 board file that is now gone, so the driver can be removed as well. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/ata/Kconfig | 10 - drivers/ata/Makefile | 1 - drivers/ata/pata_samsung_cf.c | 662 ------------------- include/linux/platform_data/ata-samsung_cf.h | 31 - 4 files changed, 704 deletions(-) delete mode 100644 drivers/ata/pata_samsung_cf.c delete mode 100644 include/linux/platform_data/ata-samsung_cf.h
Comments
Hello! On 10/21/22 11:27 PM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This device was only used by the smdk6410 board file that is now > gone, so the driver can be removed as well. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
On 10/22/22 05:27, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This device was only used by the smdk6410 board file that is now > gone, so the driver can be removed as well. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Arnd, This patch does not apply to the for-6.2 branch of libata tree. I can fix that easily, but I am concerned about the fact that this deletes the header file include/linux/platform_data/ata-samsung_cf.h, which has some function declarations for gpio used under arch/arm/mach-s3c. So If I apply this before you queue the other patches for this driver in for-next, we may endup with build failures. No ? > --- > drivers/ata/Kconfig | 10 - > drivers/ata/Makefile | 1 - > drivers/ata/pata_samsung_cf.c | 662 ------------------- > include/linux/platform_data/ata-samsung_cf.h | 31 - > 4 files changed, 704 deletions(-) > delete mode 100644 drivers/ata/pata_samsung_cf.c > delete mode 100644 include/linux/platform_data/ata-samsung_cf.h > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 6b446cfc3455..3b8cb7a29efd 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -1136,16 +1136,6 @@ config PATA_RZ1000 > > If unsure, say N. > > -config PATA_SAMSUNG_CF > - tristate "Samsung SoC PATA support" > - depends on SAMSUNG_DEV_IDE || COMPILE_TEST > - select PATA_TIMINGS > - help > - This option enables basic support for Samsung's S3C/S5P board > - PATA controllers via the new ATA layer > - > - If unsure, say N. > - > config PATA_WINBOND_VLB > tristate "Winbond W83759A VLB PATA support (Experimental)" > depends on ISA > diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile > index 2cca9f500649..4ee5c0761d90 100644 > --- a/drivers/ata/Makefile > +++ b/drivers/ata/Makefile > @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM) += pata_platform.o > obj-$(CONFIG_PATA_OF_PLATFORM) += pata_of_platform.o > obj-$(CONFIG_PATA_RB532) += pata_rb532_cf.o > obj-$(CONFIG_PATA_RZ1000) += pata_rz1000.o > -obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o > > obj-$(CONFIG_PATA_PXA) += pata_pxa.o > > diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c > deleted file mode 100644 > index aba1536ddd44..000000000000 > diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h > deleted file mode 100644 > index fccf969dc4da..000000000000
On 10/24/22 07:41, Damien Le Moal wrote: > On 10/22/22 05:27, Arnd Bergmann wrote: >> From: Arnd Bergmann <arnd@arndb.de> >> >> This device was only used by the smdk6410 board file that is now >> gone, so the driver can be removed as well. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Arnd, > > This patch does not apply to the for-6.2 branch of libata tree. I can fix > that easily, but I am concerned about the fact that this deletes the > header file include/linux/platform_data/ata-samsung_cf.h, which has some > function declarations for gpio used under arch/arm/mach-s3c. So If I apply > this before you queue the other patches for this driver in for-next, we > may endup with build failures. No ? It may be simpler for you to take this patch ? If yes, then: Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> > >> --- >> drivers/ata/Kconfig | 10 - >> drivers/ata/Makefile | 1 - >> drivers/ata/pata_samsung_cf.c | 662 ------------------- >> include/linux/platform_data/ata-samsung_cf.h | 31 - >> 4 files changed, 704 deletions(-) >> delete mode 100644 drivers/ata/pata_samsung_cf.c >> delete mode 100644 include/linux/platform_data/ata-samsung_cf.h >> >> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig >> index 6b446cfc3455..3b8cb7a29efd 100644 >> --- a/drivers/ata/Kconfig >> +++ b/drivers/ata/Kconfig >> @@ -1136,16 +1136,6 @@ config PATA_RZ1000 >> >> If unsure, say N. >> >> -config PATA_SAMSUNG_CF >> - tristate "Samsung SoC PATA support" >> - depends on SAMSUNG_DEV_IDE || COMPILE_TEST >> - select PATA_TIMINGS >> - help >> - This option enables basic support for Samsung's S3C/S5P board >> - PATA controllers via the new ATA layer >> - >> - If unsure, say N. >> - >> config PATA_WINBOND_VLB >> tristate "Winbond W83759A VLB PATA support (Experimental)" >> depends on ISA >> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile >> index 2cca9f500649..4ee5c0761d90 100644 >> --- a/drivers/ata/Makefile >> +++ b/drivers/ata/Makefile >> @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM) += pata_platform.o >> obj-$(CONFIG_PATA_OF_PLATFORM) += pata_of_platform.o >> obj-$(CONFIG_PATA_RB532) += pata_rb532_cf.o >> obj-$(CONFIG_PATA_RZ1000) += pata_rz1000.o >> -obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o >> >> obj-$(CONFIG_PATA_PXA) += pata_pxa.o >> >> diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c >> deleted file mode 100644 >> index aba1536ddd44..000000000000 >> diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h >> deleted file mode 100644 >> index fccf969dc4da..000000000000 >
On 21/10/2022 16:27, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This device was only used by the smdk6410 board file that is now > gone, so the driver can be removed as well. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/ata/Kconfig | 10 - > drivers/ata/Makefile | 1 - > drivers/ata/pata_samsung_cf.c | 662 ------------------- > include/linux/platform_data/ata-samsung_cf.h | 31 - > 4 files changed, 704 deletions(-) > delete mode 100644 drivers/ata/pata_samsung_cf.c > delete mode 100644 include/linux/platform_data/ata-samsung_cf.h > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 6b446cfc3455..3b8cb7a29efd 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -1136,16 +1136,6 @@ config PATA_RZ1000 > > If unsure, say N. > > -config PATA_SAMSUNG_CF > - tristate "Samsung SoC PATA support" > - depends on SAMSUNG_DEV_IDE || COMPILE_TEST > - select PATA_TIMINGS > - help > - This option enables basic support for Samsung's S3C/S5P board > - PATA controllers via the new ATA layer > - This driver is present and somehow usable on newer platform: S5PV210. It's not converted to DT, but someone might want to do it. OTOH, if no one added DT for all this time, I doubt anyone will. Postmarket/Lineage-folks target smartphones, so don't use it. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Oct 24, 2022, at 00:41, Damien Le Moal wrote: > On 10/22/22 05:27, Arnd Bergmann wrote: >> From: Arnd Bergmann <arnd@arndb.de> >> >> This device was only used by the smdk6410 board file that is now >> gone, so the driver can be removed as well. > > This patch does not apply to the for-6.2 branch of libata tree. I can fix > that easily, but I am concerned about the fact that this deletes the > header file include/linux/platform_data/ata-samsung_cf.h, which has some > function declarations for gpio used under arch/arm/mach-s3c. So If I apply > this before you queue the other patches for this driver in for-next, we > may endup with build failures. No ? Right, that was a mistake on my end. I had tested the full 98-patch series in sequence and assumed that the driver removal would be fine to apply separately. I'll just merge this one through the SoC tree then. I have double-checked the pbk3710 and palmld drivers, and those should not have a problem like this one. I still need to send the palmld driver, as the mach-pxa series had some unrelated issues. Arnd
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 6b446cfc3455..3b8cb7a29efd 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -1136,16 +1136,6 @@ config PATA_RZ1000 If unsure, say N. -config PATA_SAMSUNG_CF - tristate "Samsung SoC PATA support" - depends on SAMSUNG_DEV_IDE || COMPILE_TEST - select PATA_TIMINGS - help - This option enables basic support for Samsung's S3C/S5P board - PATA controllers via the new ATA layer - - If unsure, say N. - config PATA_WINBOND_VLB tristate "Winbond W83759A VLB PATA support (Experimental)" depends on ISA diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile index 2cca9f500649..4ee5c0761d90 100644 --- a/drivers/ata/Makefile +++ b/drivers/ata/Makefile @@ -109,7 +109,6 @@ obj-$(CONFIG_PATA_PLATFORM) += pata_platform.o obj-$(CONFIG_PATA_OF_PLATFORM) += pata_of_platform.o obj-$(CONFIG_PATA_RB532) += pata_rb532_cf.o obj-$(CONFIG_PATA_RZ1000) += pata_rz1000.o -obj-$(CONFIG_PATA_SAMSUNG_CF) += pata_samsung_cf.o obj-$(CONFIG_PATA_PXA) += pata_pxa.o diff --git a/drivers/ata/pata_samsung_cf.c b/drivers/ata/pata_samsung_cf.c deleted file mode 100644 index aba1536ddd44..000000000000 diff --git a/include/linux/platform_data/ata-samsung_cf.h b/include/linux/platform_data/ata-samsung_cf.h deleted file mode 100644 index fccf969dc4da..000000000000