Message ID | 1675756199-5917-3-git-send-email-ssengar@linux.microsoft.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2708849wrn; Mon, 6 Feb 2023 23:52:43 -0800 (PST) X-Google-Smtp-Source: AK7set9x7AZvHF2X8dmY1PuTYCljfiOBYPPv/jDS++oo969Hjv6aXR4VGNrmXjksP/h+z37c0ISE X-Received: by 2002:a50:d4cc:0:b0:4aa:a8e7:c04c with SMTP id e12-20020a50d4cc000000b004aaa8e7c04cmr2443189edj.21.1675756363223; Mon, 06 Feb 2023 23:52:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675756363; cv=none; d=google.com; s=arc-20160816; b=SmiTWY4TM0Bv1WPu+QTOa0xE3pYPw2DeWpkI2AaeBJ3lp6Fubd8BkAiuDauTelaqE8 pM4QeTc23LL2ym9WyomiBmOm08FAKs9DREzbaGWZJMsqqAziJwzKRTqf5GQ9nVxqPTBz dr5gSNgYVOVHdPF92aN+JgXaa4zw1pQrX9Z5A9+0SZUQqhhB8y54DOxmBAqUv/58M76v XjbFq3Yw3tI1BVc/YDF4G2uyTbGfHNPn03TL3Y2XGOFFk2FTlq+QfQncOWNzGwAqz4HI uaPwGhLqSIHG+alz7AGr3ynvciMmPd8Str/zTEJFPFzDdaNZ+ECJRaKBrTCTVrLwxKQa Tfyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter; bh=m27CpggRo4AF+8YjkrkT62CF9pWm8xzxwR5YS2mWWsk=; b=s4ztkDVHL2ADtdCfZmBKZQo8YWhHmZKjZV8re7/b9HXcTrhF9Aqw3Ub+zkOL6whmPl +aj2TyjFkFs9XnFHgurcohFGaENmxTz3jqXEqyJLousHxuuPUoiaxgNfpksh6EArthhh YzOnWwwwvkINouTbm/JGC9hdeUBd2F+MKoBBgMrrCW+zwSOyCgxIGuMagDL//2L/Eq9V Ue80KT0c4p/7A2+ZwwV2f0jBA6kqNu2yXAKvjcyBKjqT5WgO3U3WEi2HBujoyob7gZ2N oeex1cQzFh9wxDW4pAC5GCpMuxmYmevb1B5VjqbLgB/+XHFZcyWLMgNcA3motbC+b/eN lC2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=ITVHd11B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gc21-20020a1709072b1500b0088d90504560si14616258ejc.30.2023.02.06.23.52.20; Mon, 06 Feb 2023 23:52:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=ITVHd11B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbjBGHuM (ORCPT <rfc822;kmanaouilinux@gmail.com> + 99 others); Tue, 7 Feb 2023 02:50:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230080AbjBGHuE (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Feb 2023 02:50:04 -0500 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7443E18B20; Mon, 6 Feb 2023 23:50:03 -0800 (PST) Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id EA79720C7E2D; Mon, 6 Feb 2023 23:50:02 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EA79720C7E2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1675756203; bh=m27CpggRo4AF+8YjkrkT62CF9pWm8xzxwR5YS2mWWsk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ITVHd11BBEY1XV/RW1GFECrDc3DvZ6cNR4GgynqIV6y3JmaqQ/J6byoGKvvLhG5c/ FkFbIcbmCOMjjCCeyJxaL/uV5+oEU2Jc031kH0OKPziTDGE66x4KzotxmmGYobc1VX cyk2MFzupAUSSPJz2AZjSIcvViRyX0OdSmkXgFps= From: Saurabh Sengar <ssengar@linux.microsoft.com> To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, daniel.lezcano@linaro.org, tglx@linutronix.de, virtualization@lists.linux-foundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, mikelley@microsoft.com, ssengar@microsoft.com, dphadke@linux.microsoft.com Subject: [PATCH v4 2/6] Drivers: hv: allow non ACPI compilation for hv_is_hibernation_supported Date: Mon, 6 Feb 2023 23:49:55 -0800 Message-Id: <1675756199-5917-3-git-send-email-ssengar@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1675756199-5917-1-git-send-email-ssengar@linux.microsoft.com> References: <1675756199-5917-1-git-send-email-ssengar@linux.microsoft.com> X-Spam-Status: No, score=-19.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757157904108824813?= X-GMAIL-MSGID: =?utf-8?q?1757157904108824813?= |
Series |
Device tree support for Hyper-V VMBus driver
|
|
Commit Message
Saurabh Singh Sengar
Feb. 7, 2023, 7:49 a.m. UTC
acpi_sleep_state_supported API is only define for CONFIG_ACPI flag and
thus it can't be used for non-ACPI builds. Initially there won't be
hibernation support for non ACPI builds.
This change will help adding device tree support in subsequent commits.
Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
---
drivers/hv/hv_common.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
From: Saurabh Sengar <ssengar@linux.microsoft.com> Sent: Monday, February 6, 2023 11:50 PM > > acpi_sleep_state_supported API is only define for CONFIG_ACPI flag and > thus it can't be used for non-ACPI builds. Initially there won't be > hibernation support for non ACPI builds. > > This change will help adding device tree support in subsequent commits. In keeping with the guideline to avoid references like "this patch" or "this change" in commit messages, I'd suggest wording the commit message something like the following: acpi_sleep_state_supported() currently is defined only when CONFIG_ACPI=y. For future work to enable device tree builds, put this function under #ifdef CONFIG_ACPI. Otherwise, return 'false' from hv_is_hibernation_supported() as Hyper-V guest configs using device tree don't support hibernation. With that update, Reviewed-by: Michael Kelley I gave a Reviewed-by on Patch 1 of this series, but the same comment applies about "this change" in that commit message. Michael > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > --- > drivers/hv/hv_common.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index 52a6f89..370ec20 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -234,7 +234,11 @@ void hv_setup_dma_ops(struct device *dev, bool coherent) > > bool hv_is_hibernation_supported(void) > { > +#ifdef CONFIG_ACPI > return !hv_root_partition && acpi_sleep_state_supported(ACPI_STATE_S4); > +#else > + return false; > +#endif > } > EXPORT_SYMBOL_GPL(hv_is_hibernation_supported); > > -- > 1.8.3.1
diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c index 52a6f89..370ec20 100644 --- a/drivers/hv/hv_common.c +++ b/drivers/hv/hv_common.c @@ -234,7 +234,11 @@ void hv_setup_dma_ops(struct device *dev, bool coherent) bool hv_is_hibernation_supported(void) { +#ifdef CONFIG_ACPI return !hv_root_partition && acpi_sleep_state_supported(ACPI_STATE_S4); +#else + return false; +#endif } EXPORT_SYMBOL_GPL(hv_is_hibernation_supported);