| Message ID | Y0z2/qFe3kW96MTs@debian-BULLSEYE-live-builder-AMD64 |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1317937wrs;
Mon, 17 Oct 2022 00:41:50 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM7q8hyO9uKvm3dbdoE83D07hrmIwboHbfKYfr+QQCWCidTB81Fx0rtL1DvBRh6PUonNsSy8
X-Received: by 2002:a17:907:2c78:b0:78d:eacd:1060 with SMTP id
ib24-20020a1709072c7800b0078deacd1060mr7428689ejc.244.1665992510110;
Mon, 17 Oct 2022 00:41:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1665992510; cv=none;
d=google.com; s=arc-20160816;
b=f7SUzxKdtw5CUtxLCuyjVhz/hjsLo7d6RrYym1QQ2rjYDoDZz616R6d1xR4JBG8U0Q
yxvgKBGTc4z+Mh7a9Fomsc/TcS0FAUqVaNHEF3WHt8VKDHwFFFbZTDZRMU3eoj/BNaSf
TGKVsCu3Ygk7eej9F+yJdxuHIpO9sNwxZ4l3BP5nVJ4a1MZdH1njae4z/fny/Aui8KQn
ni/qPGvBNyZKuj6B6jrR/E7BuU4bK49DQtlhrLPbc6FtkqEv+27BAjDrN+y0JaeDav5l
kO+VWGSob9peSa43OC0bKyQ64HhgCgf9qU2MGTTwzsZCmdliMvhw9tkWloienXL656Lg
WY9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-disposition:mime-version:message-id
:subject:cc:to:from:date:dkim-signature;
bh=UYjAta1ZW9FirFJbW+Ov9Dg7Grpyjzu0+7OnfMtTZH0=;
b=iAtCxvh+AT8sFrpP3Od1dWDW0nmk24IR4XvIOZRyWPJfC3OG/YrNWw9+e6SU4T8UwM
kyz0EFwCae34+RpA9Ul3Mmh3uDeR+UutFIHTGBGqkVN+yzGg4gsndsSepDCc5gPwOdnr
6teMyoV6iwqgXuNVkJymBKBUiJp6n1WvWBZHV+NzZsOX/XYn9ZTBAHXpnBWwFQtrjH8P
MyjO5bwnbrb775fU8ko2hPBuzUV1iL3QQVDnAaQLW81xGpPMqPgMuTIsuTZJEo43PEkD
Sam3jkhy/K4hSQF7bA3wYzZDVFPZJCgf7g1bHJdT50qasTGHg0uSQuj03lly7greAOT+
vL8g==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=fail header.i=@mailo.com header.s=mailo header.b=GXEOablk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
u12-20020a50eacc000000b00458ff0764casi7345189edp.95.2022.10.17.00.41.25;
Mon, 17 Oct 2022 00:41:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=fail header.i=@mailo.com header.s=mailo header.b=GXEOablk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mailo.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230214AbiJQHXh (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others);
Mon, 17 Oct 2022 03:23:37 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47894 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230103AbiJQHXf (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 17 Oct 2022 03:23:35 -0400
X-Greylist: delayed 1259 seconds by postgrey-1.37 at
lindbergh.monkeyblade.net; Mon, 17 Oct 2022 00:23:30 PDT
Received: from msg-1.mailo.com (msg-1.mailo.com [213.182.54.11])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2570A59734;
Mon, 17 Oct 2022 00:23:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo;
t=1665990123; bh=v1WmIdGEdjb/NRA9IbpdRDnvrh6PU598P+2FFcf0eoI=;
h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version:
Content-Type;
b=GXEOablkpD9tab0iyR+Nqti3uRljRoWtutJWpTPoK5n3UP8pzswBj/GHpOns/gmy9
y7rJFEl2rGNl0q7iOKJbZJyVzy/XuVyX+23ajS0sOzqVDtUFzX4QbFCEqG1bENXcWn
KrsQvARRQrnFoXikbJl3nlSqaEroCpePbIzaVibY=
Received: by b-5.in.mailobj.net [192.168.90.15] with ESMTP
via [213.182.55.206]
Mon, 17 Oct 2022 09:02:03 +0200 (CEST)
X-EA-Auth:
PgaBZF2EQagjeQgatbitFuEP2vpDjYeqY00rZfLXzUDuULgmxrv3GX32xIOsdaW/FUVjM2UB0rTenzLna3v6qSx8wD8sNT2m
Date: Mon, 17 Oct 2022 12:02:30 +0530
From: Deepak R Varma <drv@mailo.com>
To: outreachy@lists.linux.dev, lars@metafoo.de,
Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com
Subject: [PATCH] staging: iio: frequency: ad9834: merge unnecessary split
lines
Message-ID: <Y0z2/qFe3kW96MTs@debian-BULLSEYE-live-builder-AMD64>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1746918011239280142?=
X-GMAIL-MSGID: =?utf-8?q?1746919762428638492?=
|
| Series |
staging: iio: frequency: ad9834: merge unnecessary split lines
|
|
Commit Message
Deepak R Varma
Oct. 17, 2022, 6:32 a.m. UTC
Improve code readability by merging unnecessary split lines that are
well within the code-style guidelines post merge.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/staging/iio/frequency/ad9834.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--
2.30.2
Comments
On Mon, 17 Oct 2022, Deepak R Varma wrote: > Improve code readability by merging unnecessary split lines that are > well within the code-style guidelines post merge. > > Signed-off-by: Deepak R Varma <drv@mailo.com> Acked-by: Julia Lawall <julia.lawall@inria.fr> > --- > drivers/staging/iio/frequency/ad9834.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c > index 2b4267a87e65..285df0e489a6 100644 > --- a/drivers/staging/iio/frequency/ad9834.c > +++ b/drivers/staging/iio/frequency/ad9834.c > @@ -331,11 +331,9 @@ static IIO_DEV_ATTR_PHASE(0, 1, 0200, NULL, ad9834_write, AD9834_REG_PHASE1); > static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL, ad9834_write, AD9834_PSEL); > static IIO_CONST_ATTR_PHASE_SCALE(0, "0.0015339808"); /* 2PI/2^12 rad*/ > > -static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, > - ad9834_write, AD9834_PIN_SW); > +static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, ad9834_write, AD9834_PIN_SW); > static IIO_DEV_ATTR_OUT_ENABLE(0, 0200, NULL, ad9834_write, AD9834_RESET); > -static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, > - ad9834_write, AD9834_OPBITEN); > +static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, ad9834_write, AD9834_OPBITEN); > static IIO_DEV_ATTR_OUT_WAVETYPE(0, 0, ad9834_store_wavetype, 0); > static IIO_DEV_ATTR_OUT_WAVETYPE(0, 1, ad9834_store_wavetype, 1); > > -- > 2.30.2 > > > > >
On Mon, 17 Oct 2022 09:10:15 +0200 (CEST) Julia Lawall <julia.lawall@inria.fr> wrote: > On Mon, 17 Oct 2022, Deepak R Varma wrote: > > > Improve code readability by merging unnecessary split lines that are > > well within the code-style guidelines post merge. > > > > Signed-off-by: Deepak R Varma <drv@mailo.com> > > Acked-by: Julia Lawall <julia.lawall@inria.fr> Not a huge benefit to readability, but as this is in staging, fair enough! Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to see if we missed anything. Thanks, Jonathan > > > --- > > drivers/staging/iio/frequency/ad9834.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c > > index 2b4267a87e65..285df0e489a6 100644 > > --- a/drivers/staging/iio/frequency/ad9834.c > > +++ b/drivers/staging/iio/frequency/ad9834.c > > @@ -331,11 +331,9 @@ static IIO_DEV_ATTR_PHASE(0, 1, 0200, NULL, ad9834_write, AD9834_REG_PHASE1); > > static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL, ad9834_write, AD9834_PSEL); > > static IIO_CONST_ATTR_PHASE_SCALE(0, "0.0015339808"); /* 2PI/2^12 rad*/ > > > > -static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, > > - ad9834_write, AD9834_PIN_SW); > > +static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, ad9834_write, AD9834_PIN_SW); > > static IIO_DEV_ATTR_OUT_ENABLE(0, 0200, NULL, ad9834_write, AD9834_RESET); > > -static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, > > - ad9834_write, AD9834_OPBITEN); > > +static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, ad9834_write, AD9834_OPBITEN); > > static IIO_DEV_ATTR_OUT_WAVETYPE(0, 0, ad9834_store_wavetype, 0); > > static IIO_DEV_ATTR_OUT_WAVETYPE(0, 1, ad9834_store_wavetype, 1); > > > > -- > > 2.30.2 > > > > > > > > > >
diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c index 2b4267a87e65..285df0e489a6 100644 --- a/drivers/staging/iio/frequency/ad9834.c +++ b/drivers/staging/iio/frequency/ad9834.c @@ -331,11 +331,9 @@ static IIO_DEV_ATTR_PHASE(0, 1, 0200, NULL, ad9834_write, AD9834_REG_PHASE1); static IIO_DEV_ATTR_PHASESYMBOL(0, 0200, NULL, ad9834_write, AD9834_PSEL); static IIO_CONST_ATTR_PHASE_SCALE(0, "0.0015339808"); /* 2PI/2^12 rad*/ -static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, - ad9834_write, AD9834_PIN_SW); +static IIO_DEV_ATTR_PINCONTROL_EN(0, 0200, NULL, ad9834_write, AD9834_PIN_SW); static IIO_DEV_ATTR_OUT_ENABLE(0, 0200, NULL, ad9834_write, AD9834_RESET); -static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, - ad9834_write, AD9834_OPBITEN); +static IIO_DEV_ATTR_OUTY_ENABLE(0, 1, 0200, NULL, ad9834_write, AD9834_OPBITEN); static IIO_DEV_ATTR_OUT_WAVETYPE(0, 0, ad9834_store_wavetype, 0); static IIO_DEV_ATTR_OUT_WAVETYPE(0, 1, ad9834_store_wavetype, 1);