diff mbox series

[3/3] soc: qcom: socinfo: add support for SA8775P

Message ID 20230207100730.218725-4-brgl@bgdev.pl
State New
Headers
Series arm: qcom: sa8775p: add socinfo support |

Commit Message

Bartosz Golaszewski Feb. 7, 2023, 10:07 a.m. UTC 
  From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Add SocInfo support for SA8775P.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/soc/qcom/socinfo.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Feb. 7, 2023, 10:46 a.m. UTC | #1 
On 07/02/2023 11:07, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Add SocInfo support for SA8775P.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/soc/qcom/socinfo.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 3b970a80f3aa..c5208aa99125 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -419,6 +419,7 @@ static const struct soc_id soc_id[] = {
>  	{ qcom_board_id(SM8350) },
>  	{ qcom_board_id(SM6115) },
>  	{ qcom_board_id(SC8280XP) },
> +	{ qcom_board_id(SA8775P) },

This does not look like correctly ordered.

Best regards,
Krzysztof
Bartosz Golaszewski Feb. 7, 2023, 10:49 a.m. UTC | #2 
On Tue, Feb 7, 2023 at 11:46 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 07/02/2023 11:07, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add SocInfo support for SA8775P.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> >  drivers/soc/qcom/socinfo.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> > index 3b970a80f3aa..c5208aa99125 100644
> > --- a/drivers/soc/qcom/socinfo.c
> > +++ b/drivers/soc/qcom/socinfo.c
> > @@ -419,6 +419,7 @@ static const struct soc_id soc_id[] = {
> >       { qcom_board_id(SM8350) },
> >       { qcom_board_id(SM6115) },
> >       { qcom_board_id(SC8280XP) },
> > +     { qcom_board_id(SA8775P) },
>
> This does not look like correctly ordered.
>

Ugh, I missed the fact that these are ordered by the chip ID that's
defined elsewhere. Thanks, will fix that in v2.

Bart
diff mbox series

Patch

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index 3b970a80f3aa..c5208aa99125 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -419,6 +419,7 @@  static const struct soc_id soc_id[] = {
 	{ qcom_board_id(SM8350) },
 	{ qcom_board_id(SM6115) },
 	{ qcom_board_id(SC8280XP) },
+	{ qcom_board_id(SA8775P) },
 	{ qcom_board_id(IPQ6005) },
 	{ qcom_board_id(QRB5165) },
 	{ qcom_board_id(SM8450) },