diff mbox series

[1/3] Staging: rtl8192e: rtl819x_HTProc: fixed missing blank space

Message ID d4898956a848c85fc93c3f7d25cafbfc49a46e60.camel@zohomail.com
State New
Headers
Series staging: rtl8192e: rtl819x_HTProc: code cleanup patches on the rtl8192x_HTProc.c file. |

Commit Message

Aaron Lawrence Oct. 22, 2022, 3:48 p.m. UTC 
  From e6635103e3cf2426220767955b99d2e2b62a7329 Mon Sep 17 00:00:00 2001
Message-Id: <e6635103e3cf2426220767955b99d2e2b62a7329.1666450553.git.t4rmin@zohomail.com>
In-Reply-To: <cover.1666450553.git.t4rmin@zohomail.com>
References: <cover.1666450553.git.t4rmin@zohomail.com>
From: Aaron Lawrence <t4rmin@zohomail.com>
Date: Sat, 22 Oct 2022 20:46:25 +0700
Subject: [PATCH 1/3] Staging: rtl8192e: rtl819x_HTProc: fixed missing blank
 space

Added a missing blank space as per the Linux kernel coding-style
regulations. The issue was flagged by the checkpatch script as a
warning.

Signed-off-by: Aaron Lawrence <t4rmin@zohomail.com>
---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Nam Cao Oct. 22, 2022, 6:21 p.m. UTC | #1 
On Sat, Oct 22, 2022 at 10:48:08PM +0700, Aaron Lawrence wrote:
> >From e6635103e3cf2426220767955b99d2e2b62a7329 Mon Sep 17 00:00:00 2001
> Message-Id: <e6635103e3cf2426220767955b99d2e2b62a7329.1666450553.git.t4rmin@zohomail.com>
> In-Reply-To: <cover.1666450553.git.t4rmin@zohomail.com>
> References: <cover.1666450553.git.t4rmin@zohomail.com>
> From: Aaron Lawrence <t4rmin@zohomail.com>
> Date: Sat, 22 Oct 2022 20:46:25 +0700

I think you messed up something here. These are not supposed to be in
the email description. All your patches are sent separatedly, instead of
being in the same thread.

I can recommend follow the instructions in this website:
https://kernelnewbies.org/FirstKernelPatch

> Subject: [PATCH 1/3] Staging: rtl8192e: rtl819x_HTProc: fixed missing blank
>  space
> 
> Added a missing blank space as per the Linux kernel coding-style
> regulations. The issue was flagged by the checkpatch script as a
> warning.
> 
> Signed-off-by: Aaron Lawrence <t4rmin@zohomail.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_HTProc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> index ef3dca51cf99..b763cf0ba356 100644
> --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> @@ -70,6 +70,7 @@ static u8 LINKSYS_MARVELL_4400N[3] = {0x00, 0x14, 0xa4};
>  void HTUpdateDefaultSetting(struct rtllib_device *ieee)
>  {
>  struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
> +
>  pHTInfo->bRegShortGI20MHz = 1;
>  pHTInfo->bRegShortGI40MHz = 1;
> -- 
> 2.38.1
> 
>
Slade Watkins Oct. 22, 2022, 8:08 p.m. UTC | #2 
On Sat, Oct 22, 2022 at 11:48 AM Aaron Lawrence <t4rmin@zohomail.com> wrote:
>
> From e6635103e3cf2426220767955b99d2e2b62a7329 Mon Sep 17 00:00:00 2001
> Message-Id: <e6635103e3cf2426220767955b99d2e2b62a7329.1666450553.git.t4rmin@zohomail.com>
> In-Reply-To: <cover.1666450553.git.t4rmin@zohomail.com>
> References: <cover.1666450553.git.t4rmin@zohomail.com>
> From: Aaron Lawrence <t4rmin@zohomail.com>
> Date: Sat, 22 Oct 2022 20:46:25 +0700
> Subject: [PATCH 1/3] Staging: rtl8192e: rtl819x_HTProc: fixed missing blank
>  space

Hey there,
Could you resend this without the above? For whatever reason it was
included in the message, even though it shouldn't be.

-srw
Aaron Lawrence Oct. 23, 2022, 9:05 a.m. UTC | #3 
On Sat, 2022-10-22 at 20:21 +0200, Nam Cao wrote:
> On Sat, Oct 22, 2022 at 10:48:08PM +0700, Aaron Lawrence wrote:
> > > From e6635103e3cf2426220767955b99d2e2b62a7329 Mon Sep 17 00:00:00 2001
> > Message-Id: <e6635103e3cf2426220767955b99d2e2b62a7329.1666450553.git.t4rmin@zohomail.com>
> > In-Reply-To: <cover.1666450553.git.t4rmin@zohomail.com>
> > References: <cover.1666450553.git.t4rmin@zohomail.com>
> > From: Aaron Lawrence <t4rmin@zohomail.com>
> > Date: Sat, 22 Oct 2022 20:46:25 +0700
> 
> I think you messed up something here. These are not supposed to be in
> the email description. All your patches are sent separatedly, instead of
> being in the same thread.
> 
> I can recommend follow the instructions in this website:
> https://kernelnewbies.org/FirstKernelPatch
> 
> > Subject: [PATCH 1/3] Staging: rtl8192e: rtl819x_HTProc: fixed missing blank
> >  space
> > 
> > Added a missing blank space as per the Linux kernel coding-style
> > regulations. The issue was flagged by the checkpatch script as a
> > warning.
> > 
> > Signed-off-by: Aaron Lawrence <t4rmin@zohomail.com>
> > ---
> >  drivers/staging/rtl8192e/rtl819x_HTProc.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> > index ef3dca51cf99..b763cf0ba356 100644
> > --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
> > +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
> > @@ -70,6 +70,7 @@ static u8 LINKSYS_MARVELL_4400N[3] = {0x00, 0x14, 0xa4};
> >  void HTUpdateDefaultSetting(struct rtllib_device *ieee)
> >  {
> >  struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
> > +
> >  pHTInfo->bRegShortGI20MHz = 1;
> >  pHTInfo->bRegShortGI40MHz = 1;
> > -- 
> > 2.38.1
> > 
> > 

Ah, I see. I (hopefully) will be sending the correct email 
patchset format next time. Thanks.

Aaron
diff mbox series

Patch

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index ef3dca51cf99..b763cf0ba356 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -70,6 +70,7 @@  static u8 LINKSYS_MARVELL_4400N[3] = {0x00, 0x14, 0xa4};
 void HTUpdateDefaultSetting(struct rtllib_device *ieee)
 {
 struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;
+
 pHTInfo->bRegShortGI20MHz = 1;
 pHTInfo->bRegShortGI40MHz = 1;
-- 
2.38.1