Message ID | 20230206-topic-sm8450-upstream-dp-controller-v1-1-f1345872ed19@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2153511wrn; Mon, 6 Feb 2023 02:17:52 -0800 (PST) X-Google-Smtp-Source: AK7set8LwpU1MYjrkNNhPDfrW3Hus3aVqDTYv77phP/F74EB7eytDGG2c7XYLpY6DToebkeR9/tD X-Received: by 2002:a17:90b:1c8c:b0:230:aa1f:cac2 with SMTP id oo12-20020a17090b1c8c00b00230aa1fcac2mr5180432pjb.44.1675678671832; Mon, 06 Feb 2023 02:17:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675678671; cv=none; d=google.com; s=arc-20160816; b=FHtDqlAOMpa+Y0kK2h3SxdJpNkbp9nR0SIZdWwDxJSqC9BKolrckEGYpD3/QHI35Cu IXR5X0cDuXNnyE/J33jOC/FqqrLJABGMcRYNUz0MrmTxMzKYMM5/6IaDhTFsyP8QxxxE UvGdICbwzf6cgX6w9l9wN7DwnyDFwD0KgiJ8UuYvLUoRFEUsT6QY35l2CkFTzrCSnTwq z1lAnKK2CbLEE1DFTKF2x99Lj40M7olFdSztp7JeCN+yK/5teozHQDsqNrI2jFwHKImd /0swwcLhAbhmdsLCKc4HpJDx8UBH1dfFgUMfFTiJByjll2SK978DDEmr76Hc9qvbukRk kU1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=juT1ANtFRKnjz1qxgg5mjyQWnKuwI08rPtM+jF3OUfc=; b=f7wwIerWHVb0zBPEJRwlfW8tnUGojMn6FJ5n9PrIS7UlcKGXqAvWJAwei5uwMLAIGQ b9B3koOb+K2AM0Rc2tV2DNr9FXEcUWpjemamFUdOnWWNy0hsPW7AKgJiN6oXuwvPw104 7zC4qH9T0siE/YX/lBKjcl3MWl20YxUnexHeR+pt7TWSk3MptUMJj41Qc5SWwJpXApFH VD8QuCXpfIp3dfPTUKSDF1ziQfFNZvrbpc2rknHiNNVRGLAOC5Q6D7PYMf4vjkJA47Gn KO1i57rqNy/ckDWDJj5U5Uq8mFTdfLpCxE84PaBLOIaDfgwZ/TvANTxFaTN7RoyYdTgj 21rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hcxFwOf5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b7-20020a17090aa58700b0022be7634b01si11111908pjq.121.2023.02.06.02.17.39; Mon, 06 Feb 2023 02:17:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hcxFwOf5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230288AbjBFKRZ (ORCPT <rfc822;kmanaouilinux@gmail.com> + 99 others); Mon, 6 Feb 2023 05:17:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230280AbjBFKRS (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 6 Feb 2023 05:17:18 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3296121296 for <linux-kernel@vger.kernel.org>; Mon, 6 Feb 2023 02:17:09 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id u10so5209265wmj.3 for <linux-kernel@vger.kernel.org>; Mon, 06 Feb 2023 02:17:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=juT1ANtFRKnjz1qxgg5mjyQWnKuwI08rPtM+jF3OUfc=; b=hcxFwOf5s3B6uQ+TEDvLWWHa6v/pRaAt0pZWJfSz6KR8G9cKL2s9MQEPh3I8JujA2x i1HZyq/CoPY+6O9Q6HJ2X33Zu7KzgrAFqNMfUez+qAf82Ee7WuiQ1Bh+qlouUHvAMUdi 4cDUMM4O54LRhEir1VY65DffLDAhlGKbg9ntI2V46kPa7KuTX4nyP3h7p6quQf44NFXn kQz5fNeVTeCzBOHluNHqhZNwYw/dPYCm6yeEzw6fzkL8bhVUzVGstvr+Tqpqnt5nRJOi PMU5zVVtcEGA++YzApp1CSULUdocIquCCSzIVcGLxXxMouLlSnOi8fjkzgex0r1YN39x tI9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=juT1ANtFRKnjz1qxgg5mjyQWnKuwI08rPtM+jF3OUfc=; b=jTEDJqMZRgac57bAaiqdElgZzaUxImTMEStrK8b5m89tpvd6SdLlAsy0bVDqV3S3V8 qHBS4Xj+a+4pVMDBDrKAtyeElSNadCX/IVVyQI6Fhd65IuKCG5TFt9+vPqqeIuOL/Rx0 oKUvS5HMWPFe5rU/ohNfQWU/QLtPH3ZXDFfggItCK9AmjVQkzHeSyU6B/ExLSch9a+l9 QucIcXtX18mejacQ7BzZEi1NFjNV8me9AiY3KwTgLWJoSLkfQie7bBI90HnPx4Gno174 4H2UdZh4a4m0NjGYSQoE4F455eqE31/2/HROmdF5b3Crd5BaSrHWV5kaPsQbEvo/DUKN x8TQ== X-Gm-Message-State: AO0yUKUgmGIf4YzZTjc45EK2EcngiyhBF1EKW9BsiAZ/BCwHnRUX03YH trYNO9Xad0U5ZHypGQKSmGMC3g== X-Received: by 2002:a05:600c:1e8d:b0:3df:deb5:6ff5 with SMTP id be13-20020a05600c1e8d00b003dfdeb56ff5mr13663417wmb.24.1675678627739; Mon, 06 Feb 2023 02:17:07 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id w15-20020a05600c474f00b003db0bb81b6asm11314201wmo.1.2023.02.06.02.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 02:17:07 -0800 (PST) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Mon, 06 Feb 2023 11:17:04 +0100 Subject: [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8450 compatible MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230206-topic-sm8450-upstream-dp-controller-v1-1-f1345872ed19@linaro.org> References: <20230206-topic-sm8450-upstream-dp-controller-v1-0-f1345872ed19@linaro.org> In-Reply-To: <20230206-topic-sm8450-upstream-dp-controller-v1-0-f1345872ed19@linaro.org> To: Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Kuogee Hsieh <quic_khsieh@quicinc.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org> Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.12.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757076439009448311?= X-GMAIL-MSGID: =?utf-8?q?1757076439009448311?= |
Series |
arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS
|
|
Commit Message
Neil Armstrong
Feb. 6, 2023, 10:17 a.m. UTC
The SM8450 & SM350 shares the same DT TX IP version, use the
SM8350 compatible as fallback for SM8450.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++
1 file changed, 4 insertions(+)
Comments
On 06/02/2023 11:17, Neil Armstrong wrote: > The SM8450 & SM350 shares the same DT TX IP version, use the > SM8350 compatible as fallback for SM8450. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index 0e8d8df686dc..98bae326e655 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -25,6 +25,10 @@ properties: > - qcom,sc8280xp-edp > - qcom,sdm845-dp > - qcom,sm8350-dp > + - items: > + - enum: > + - qcom,sm8450-dp Indentation looks wrong here. Testing should fail, did you test it? Best regards, Krzysztof
On 06/02/2023 12:33, Krzysztof Kozlowski wrote: > On 06/02/2023 11:17, Neil Armstrong wrote: >> The SM8450 & SM350 shares the same DT TX IP version, use the >> SM8350 compatible as fallback for SM8450. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> index 0e8d8df686dc..98bae326e655 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> @@ -25,6 +25,10 @@ properties: >> - qcom,sc8280xp-edp >> - qcom,sdm845-dp >> - qcom,sm8350-dp >> + - items: >> + - enum: >> + - qcom,sm8450-dp > > Indentation looks wrong here. Testing should fail, did you test it? Moreover it also breaks dt-schema, see https://github.com/devicetree-org/dt-schema/issues/98 > > Best regards, > Krzysztof >
On 06/02/2023 12:20, Dmitry Baryshkov wrote: > On 06/02/2023 12:33, Krzysztof Kozlowski wrote: >> On 06/02/2023 11:17, Neil Armstrong wrote: >>> The SM8450 & SM350 shares the same DT TX IP version, use the >>> SM8350 compatible as fallback for SM8450. >>> >>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>> --- >>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> index 0e8d8df686dc..98bae326e655 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> @@ -25,6 +25,10 @@ properties: >>> - qcom,sc8280xp-edp >>> - qcom,sdm845-dp >>> - qcom,sm8350-dp >>> + - items: >>> + - enum: >>> + - qcom,sm8450-dp >> >> Indentation looks wrong here. Testing should fail, did you test it? > > Moreover it also breaks dt-schema, see https://github.com/devicetree-org/dt-schema/issues/98 Yep the change totally broke on rebase, will fix it Sorry for the noise. Neil > >> >> Best regards, >> Krzysztof >> >
On 06/02/2023 14:36, Neil Armstrong wrote: > On 06/02/2023 12:20, Dmitry Baryshkov wrote: >> On 06/02/2023 12:33, Krzysztof Kozlowski wrote: >>> On 06/02/2023 11:17, Neil Armstrong wrote: >>>> The SM8450 & SM350 shares the same DT TX IP version, use the >>>> SM8350 compatible as fallback for SM8450. >>>> >>>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>>> --- >>>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | >>>> 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git >>>> a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> index 0e8d8df686dc..98bae326e655 100644 >>>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>>> @@ -25,6 +25,10 @@ properties: >>>> - qcom,sc8280xp-edp >>>> - qcom,sdm845-dp >>>> - qcom,sm8350-dp >>>> + - items: >>>> + - enum: >>>> + - qcom,sm8450-dp >>> >>> Indentation looks wrong here. Testing should fail, did you test it? >> >> Moreover it also breaks dt-schema, see >> https://github.com/devicetree-org/dt-schema/issues/98 > > Yep the change totally broke on rebase, will fix it > > Sorry for the noise. N/p. You might want to check the sm8350 GPU patchset. I had to reorder DT nodes.
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index 0e8d8df686dc..98bae326e655 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -25,6 +25,10 @@ properties: - qcom,sc8280xp-edp - qcom,sdm845-dp - qcom,sm8350-dp + - items: + - enum: + - qcom,sm8450-dp + - const: qcom,sm8350-dp reg: minItems: 4