| Message ID | b5d065218265e79daa23f82bb84efc6a7ea120fc.1675461757.git.jpoimboe@kernel.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1080194wrn;
Fri, 3 Feb 2023 14:07:57 -0800 (PST)
X-Google-Smtp-Source:
AK7set9KDsTu8RDxsOO4nXDdOpLS/dY35dHntCorvCOweRsHs6nyBtDLvT/ShuucZdqn6v1NRA2q
X-Received: by 2002:a17:90b:4f44:b0:22c:4bc:2126 with SMTP id
pj4-20020a17090b4f4400b0022c04bc2126mr12271641pjb.45.1675462077093;
Fri, 03 Feb 2023 14:07:57 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675462077; cv=none;
d=google.com; s=arc-20160816;
b=U7EFOWY66DtYWs+hNrKgCaD4y+53Fs5BQjEBJpmF0iZ08YCJoN9IMsh9HT3/cuKtK5
aSwnzjC2y7c6BFpjoB4dPr+QeQwa1qhmaYZMk+XC9PCyRtQ2PSeo058BNtbHwIWFpmqI
k0WnvYknYejm7jYgAfArqd9B1R4SnaeHyukVDR8rMCkyyaskis5bTh0ZBB8ARaN6cefi
7+J5hMfmahHCCyZ/YxL85N8gD0LGxnVcIn+jBnb6RO+XXpmOz6w+CIip5yeec3bGrfwX
YdaFPOZJLzZliKmlO5SyEWbTCOu6CmCgZDw91bdLEENGhT8dmNluUmtefpYSEUHMWN1k
ycqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=cOSQhpL6fhGiM9s4xPZC5do7e8hAA2wOC4tTlUjnTbY=;
b=GLasH4OgOMH839m2G9dAfy18zj3KAoTG4/fs0Jtw7Ezj2BVYx8xRVn5EO59775SJKK
hL0WiUSu/CCdz6GUT5ik+6ebl8pBPzhlxHYhxEZuV9vqckc4lxKWemEXeMY0BaPMoAcB
8RfoC/D5fzcw0chSNt3OWVVI78q3PtxsWCv46BLlJJwAQhvLVl10bpYCgCUggg/Gn1Dq
6dOjMMOI76azfV8+xG7gocudTasTMobm9fVziIkU+soVgBzgBSX2KUUdXY+qTAj74DD+
QedCuVolz2hclcVVqwCGxKD6/Wsn69Tid64arnxbbH3h6cdgcod+XzXAMjyI2fhsTVwC
YcFA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bEfcJwL6;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
v3-20020a17090a960300b0022c19e2e734si8690758pjo.151.2023.02.03.14.07.44;
Fri, 03 Feb 2023 14:07:57 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bEfcJwL6;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233981AbjBCWHe (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others);
Fri, 3 Feb 2023 17:07:34 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56654 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S233593AbjBCWHB (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 3 Feb 2023 17:07:01 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org
[IPv6:2604:1380:4601:e00::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB58BAFCA0;
Fri, 3 Feb 2023 14:06:06 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by ams.source.kernel.org (Postfix) with ESMTPS id 0C680B82C30;
Fri, 3 Feb 2023 22:06:05 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08B2BC433A0;
Fri, 3 Feb 2023 22:06:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
s=k20201202; t=1675461963;
bh=NPua2qPyoi9+ZnTVjzJtwJIKtIAcOluqw/LQWD+kyG0=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=bEfcJwL6SC/AjDrgqLZ4gobtYzzG+kaVTVeIraggyRhwgYWN4oAFuKJ77/RCNTRvY
fup/m+ICRFhtxmQnpWwYUfJLena8YJAeJTm6ZcubnjXEQ/jgxWcSotzf3Y2mbjtquI
yW5I485ZkkpQ6Jqy0xpqJWrVtVjUykBoHEcmO5kdnHPKSdwkiAEHBedDcPx5HCDW7z
e56cpXGjpV9Wa9j+COiY6xVNqjbTa5hVFZNcyFwrdOvNi774RztXhcvRS8u2WNZfqm
te78V+RaoPzaJRgp+oay8agBh6E4MO/A9zlyBZNVH/Oc0XYt+s1wdWgKe5Q1neeH/O
i9bQ03yAKwMEA==
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: jgross@suse.com, richard.henderson@linaro.org,
ink@jurassic.park.msu.ru, mattst88@gmail.com,
linux-alpha@vger.kernel.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org,
linux-ia64@vger.kernel.org, chenhuacai@kernel.org,
kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de,
linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com,
mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu,
linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp,
dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net,
sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com,
linux-xtensa@linux-xtensa.org, peterz@infradead.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
paulmck@kernel.org
Subject: [PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn
Date: Fri, 3 Feb 2023 14:05:21 -0800
Message-Id:
<b5d065218265e79daa23f82bb84efc6a7ea120fc.1675461757.git.jpoimboe@kernel.org>
X-Mailer: git-send-email 2.39.0
In-Reply-To: <cover.1675461757.git.jpoimboe@kernel.org>
References: <cover.1675461757.git.jpoimboe@kernel.org>
MIME-Version: 1.0
Content-type: text/plain
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1756849322908253299?=
X-GMAIL-MSGID: =?utf-8?q?1756849322908253299?=
|
| Series |
cpu,sched: Mark arch_cpu_idle_dead() __noreturn
|
|
Commit Message
Josh Poimboeuf
Feb. 3, 2023, 10:05 p.m. UTC
start_secondary_resume() doesn't return. Annotate it as such. By
extension this also makes arch_cpu_idle_dead() noreturn.
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
---
arch/powerpc/include/asm/smp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Josh Poimboeuf <jpoimboe@kernel.org> writes: > start_secondary_resume() doesn't return. Annotate it as such. By > extension this also makes arch_cpu_idle_dead() noreturn. Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ? Seems like it would be good documentation, even if it's not required once the generic prototype is __noreturn. But not a show-stopper. Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) cheers > diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h > index f63505d74932..cfd42ca8765c 100644 > --- a/arch/powerpc/include/asm/smp.h > +++ b/arch/powerpc/include/asm/smp.h > @@ -66,7 +66,7 @@ void start_secondary(void *unused); > extern int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); > extern int smp_send_safe_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); > extern void smp_send_debugger_break(void); > -extern void start_secondary_resume(void); > +extern void __noreturn start_secondary_resume(void); > extern void smp_generic_give_timebase(void); > extern void smp_generic_take_timebase(void); > > -- > 2.39.0
On Mon, Feb 06, 2023 at 10:10:22PM +1100, Michael Ellerman wrote: > Josh Poimboeuf <jpoimboe@kernel.org> writes: > > start_secondary_resume() doesn't return. Annotate it as such. By > > extension this also makes arch_cpu_idle_dead() noreturn. > > Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ? > > Seems like it would be good documentation, even if it's not required > once the generic prototype is __noreturn. Yeah, agreed. Maybe I'll do that (for all the implementations) with patch 22. > But not a show-stopper. > > Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) Thanks!
diff --git a/arch/powerpc/include/asm/smp.h b/arch/powerpc/include/asm/smp.h index f63505d74932..cfd42ca8765c 100644 --- a/arch/powerpc/include/asm/smp.h +++ b/arch/powerpc/include/asm/smp.h @@ -66,7 +66,7 @@ void start_secondary(void *unused); extern int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); extern int smp_send_safe_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); extern void smp_send_debugger_break(void); -extern void start_secondary_resume(void); +extern void __noreturn start_secondary_resume(void); extern void smp_generic_give_timebase(void); extern void smp_generic_take_timebase(void);