| Message ID | 20230202145208.2328032-5-quic_kathirav@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp283385wrn;
Thu, 2 Feb 2023 06:54:02 -0800 (PST)
X-Google-Smtp-Source:
AK7set+WQ64aT3Nhg7RWLvTiP9a3pij7domYUKnX36gMvAXd5ZiFAJEiz4VBawk0V93iYg4C7lQf
X-Received: by 2002:a05:6a20:6909:b0:b6:b6a6:9753 with SMTP id
q9-20020a056a20690900b000b6b6a69753mr8895871pzj.8.1675349641737;
Thu, 02 Feb 2023 06:54:01 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675349641; cv=none;
d=google.com; s=arc-20160816;
b=wQkAvM5yLARzOt+90YQH6CKjVY7Cps9ngQ7QdqGKURoZYcABKBTydQVPlB+3unNqN/
6AzT64tCotK1rZa+CVjU3y4/j/vY77o/upDY3tsNvm8nIMnYOWuSgO9UEMtq75Wvy2Mg
80ycMI05W/Nz6fg0OW43wgZI74IwEZGJBdW8ty3bvjT9goC4Pr9kAiIGvRSZ8MPn1CR6
SeWitlUthDm15dUdYUt9p/AKkPA0JYtJhqCBhstBNXfLS4Aa9a/xli553CJn0GHj337X
m2R/do8Xewxm5dMoeH+r/afgrVpSWak8qXDni4QdFFTohJOJ/k2shUXpHg9wfcTRX6CY
WT+Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=RglpCvy1t/rl/T4avi3K92KIqeJ8h7w7Fw9uN/yBjdA=;
b=DECi36bpPNhmxtoXSgOgwgmNuWT82V1hEPT8jdUDn1MZOABkAawik6oQQjrOMSjdFT
Y/WJk5Xgy7iOruGBjPE8fg3tkXAcX4it6Q17NcLiX8l1yJiyLkn3IbldbjluCIVpmxxm
X1X3cP8M6L964ceEZxG0X9CEw4rUdZAj92J/YmxZP5ACnLNlTJqGOsrSM18hUFLp60u0
MSY4crduYMgJKaPb8MgMhHR23+oJ5wxGh2oic79aVgNSgbK6EtR1Ks50pj8xYs3uZlxm
3UWdoJXEKPU5zyMGjDHEvh+DrjkHU2j0sG12IDJZDtWK7oO05rZ61CnOScY0rWzObgtd
7pkQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XL6eu1vd;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
t1-20020a170902e84100b00177568a0e53si25636224plg.252.2023.02.02.06.53.47;
Thu, 02 Feb 2023 06:54:01 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XL6eu1vd;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232704AbjBBOxV (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others);
Thu, 2 Feb 2023 09:53:21 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59792 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232058AbjBBOw4 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 2 Feb 2023 09:52:56 -0500
Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com
[205.220.180.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B9AF7F31E;
Thu, 2 Feb 2023 06:52:48 -0800 (PST)
Received: from pps.filterd (m0279870.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
312DmO8w015766;
Thu, 2 Feb 2023 14:52:45 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-transfer-encoding : content-type; s=qcppdkim1;
bh=RglpCvy1t/rl/T4avi3K92KIqeJ8h7w7Fw9uN/yBjdA=;
b=XL6eu1vdRHp4bqwA+eOR4Bj/xsk3fopPoRDuqtk45b5fvzw7JH252TC8/gTkG2+Vv4Qm
pDjicz8JkGgdDiiF+chWJOt2XUlSXTHzuJR2uiGAWew3LumFa4H8e5xa7sLvV2XY6cnl
4WKhzw0iQGKGk4vjyKbppXE4YZuWQUC34My4+Yxgd+4MQr2gMSSP60dMN/lNltZrkrs/
jebQpHevUHQKWQuUwPl5xFX3s9IaAx1oSDTVrxNJE9ALOeg1E6TOr4i7dFxDeSbOat2r
MFZX/64eXn7Scu5G+5Ks/aH1nswSx6i9/kfIK+zbiiIi3VrD3xTCUQ4fqLPAB2LjDpIO rw==
Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com
[129.46.96.20])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nfqsyavep-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Thu, 02 Feb 2023 14:52:45 +0000
Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com
[10.47.209.196])
by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
312EqiqG019654
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Thu, 2 Feb 2023 14:52:44 GMT
Received: from win-platform-upstream01.qualcomm.com (10.80.80.8) by
nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.986.36; Thu, 2 Feb 2023 06:52:40 -0800
From: Kathiravan T <quic_kathirav@quicinc.com>
To: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <jassisinghbrar@gmail.com>,
<linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: Kathiravan T <quic_kathirav@quicinc.com>
Subject: [PATCH 4/6] dt-bindings: mailbox: qcom: add compatible for the
IPQ5332 SoC
Date: Thu, 2 Feb 2023 20:22:06 +0530
Message-ID: <20230202145208.2328032-5-quic_kathirav@quicinc.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230202145208.2328032-1-quic_kathirav@quicinc.com>
References: <20230202145208.2328032-1-quic_kathirav@quicinc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To
nalasex01a.na.qualcomm.com (10.47.209.196)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-GUID: jN2tGUg8xgkstUL6_X6ThmPTnPV8hrAw
X-Proofpoint-ORIG-GUID: jN2tGUg8xgkstUL6_X6ThmPTnPV8hrAw
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
definitions=2023-02-02_04,2023-02-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
impostorscore=0
suspectscore=0 bulkscore=0 phishscore=0 spamscore=0 lowpriorityscore=0
malwarescore=0 clxscore=1015 mlxscore=0 mlxlogscore=934 priorityscore=1501
adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2212070000 definitions=main-2302020133
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1756731425763622579?=
X-GMAIL-MSGID: =?utf-8?q?1756731425763622579?=
|
| Series |
Add APSS clock driver support for IPQ5332
|
|
Commit Message
Kathiravan Thirumoorthy
Feb. 2, 2023, 2:52 p.m. UTC
Add the mailbox compatible for the IPQ5332 SoC.
Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
---
.../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++
1 file changed, 3 insertions(+)
Comments
On 02/02/2023 15:52, Kathiravan T wrote: > Add the mailbox compatible for the IPQ5332 SoC. > > Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 943f9472ae10..8d8cd1bbe67e 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -18,6 +18,7 @@ properties: > oneOf: - items: - enum: - qcom,ipq5332-apcs-apps-global - const: qcom,ipq6018-apcs-apps-global and drop the next patch Best regards, Krzysztof
On 2/2/2023 9:05 PM, Krzysztof Kozlowski wrote: > On 02/02/2023 15:52, Kathiravan T wrote: >> Add the mailbox compatible for the IPQ5332 SoC. >> >> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >> --- >> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> index 943f9472ae10..8d8cd1bbe67e 100644 >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> @@ -18,6 +18,7 @@ properties: >> oneOf: > - items: > - enum: > - qcom,ipq5332-apcs-apps-global > - const: qcom,ipq6018-apcs-apps-global > > and drop the next patch Thanks, will update in V2, as suggested. > > > Best regards, > Krzysztof >
On 02/02/2023 17:35, Krzysztof Kozlowski wrote: > On 02/02/2023 15:52, Kathiravan T wrote: >> Add the mailbox compatible for the IPQ5332 SoC. >> >> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >> --- >> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> index 943f9472ae10..8d8cd1bbe67e 100644 >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> @@ -18,6 +18,7 @@ properties: >> oneOf: > > - items: > - enum: > - qcom,ipq5332-apcs-apps-global > - const: qcom,ipq6018-apcs-apps-global > > and drop the next patch Is it still ok even if the two devices are not fully compatible (iow, using different PLL types)?
On 02/02/2023 22:00, Dmitry Baryshkov wrote: > On 02/02/2023 17:35, Krzysztof Kozlowski wrote: >> On 02/02/2023 15:52, Kathiravan T wrote: >>> Add the mailbox compatible for the IPQ5332 SoC. >>> >>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >>> --- >>> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> index 943f9472ae10..8d8cd1bbe67e 100644 >>> --- >>> a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> +++ >>> b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> @@ -18,6 +18,7 @@ properties: >>> oneOf: >> >> - items: >> - enum: >> - qcom,ipq5332-apcs-apps-global >> - const: qcom,ipq6018-apcs-apps-global >> >> and drop the next patch > > Is it still ok even if the two devices are not fully compatible (iow, > using different PLL types)? Ignore my question, I mixed the A53 and APCS clocks.
On 2/2/2023 9:05 PM, Krzysztof Kozlowski wrote: > On 02/02/2023 15:52, Kathiravan T wrote: >> Add the mailbox compatible for the IPQ5332 SoC. >> >> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >> --- >> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> index 943f9472ae10..8d8cd1bbe67e 100644 >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> @@ -18,6 +18,7 @@ properties: >> oneOf: > - items: > - enum: > - qcom,ipq5332-apcs-apps-global > - const: qcom,ipq6018-apcs-apps-global > > and drop the next patch Hi Krzysztof, I'm planning to post the V2 of this series. How do you want me to proceed? I see you posted separate series[1]. May be I can follow the suggestion which you shared above, starting with IPQ? [1] https://lore.kernel.org/linux-arm-msm/20230202161856.385825-1-krzysztof.kozlowski@linaro.org/ Thanks, > > > Best regards, > Krzysztof >
On 06/02/2023 10:12, Kathiravan T wrote: > > On 2/2/2023 9:05 PM, Krzysztof Kozlowski wrote: >> On 02/02/2023 15:52, Kathiravan T wrote: >>> Add the mailbox compatible for the IPQ5332 SoC. >>> >>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >>> --- >>> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> index 943f9472ae10..8d8cd1bbe67e 100644 >>> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >>> @@ -18,6 +18,7 @@ properties: >>> oneOf: >> - items: >> - enum: >> - qcom,ipq5332-apcs-apps-global >> - const: qcom,ipq6018-apcs-apps-global >> >> and drop the next patch > > > Hi Krzysztof, > > I'm planning to post the V2 of this series. How do you want me to > proceed? I see you posted separate series[1]. May be I can follow the > suggestion which you shared above, starting with IPQ? My series need rebasing on top of Dmitry's fixes, so I propose you just send patch working only for ipq6018, like I wrote above. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 943f9472ae10..8d8cd1bbe67e 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -18,6 +18,7 @@ properties: oneOf: - items: - enum: + - qcom,ipq5332-apcs-apps-global - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global - qcom,msm8976-apcs-kpss-global @@ -111,6 +112,7 @@ allOf: properties: compatible: enum: + - qcom,ipq5332-apcs-apps-global - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global then: @@ -127,6 +129,7 @@ allOf: properties: compatible: enum: + - qcom,ipq5332-apcs-apps-global - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global then: