[v2,02/10] dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example
| Message ID | 20230202104452.299048-3-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp164644wrn;
Thu, 2 Feb 2023 02:48:31 -0800 (PST)
X-Google-Smtp-Source:
AK7set8RyTHAYdRJotEd8ORylho0p3NMC6u0UQvwPmbOILRdyGqts+4Z6obUUECHu0iqJsFuk/Um
X-Received: by 2002:a17:907:720e:b0:887:aac3:9340 with SMTP id
dr14-20020a170907720e00b00887aac39340mr1813784ejc.29.1675334911660;
Thu, 02 Feb 2023 02:48:31 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675334911; cv=none;
d=google.com; s=arc-20160816;
b=wEAPI6k15TS6Krk7dh2IvdYiaGuZrvnJtxOvP2XvSew3V83UilOP4WShc5VaFxk6/g
/udTpKUOuhAwVnXZBC35imlNxqTNTV0LONaPzNrS+STwQWW1/CPR3oz/lfqTk9RFmO6a
7fnqlPD7FHtoYjZtZKOsWBxA2R/Ny9rd0KuvpGgEbCIvIgp8N07c6/IzEDU3sDtwAZYA
DMrj+fw+TtdRS1A3rOG1QuWueS3FpSnmGkSGkqlEInuAI7P+v8r5ZxzFnX4gvaSbE51v
i8crvrfY+waFiDHie66qCc9Ob7fdghxl4HIqx+nz12c732DTMl/9T73B73PNjiFV6xp5
o6iw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=0BFZdJAFzmaSb6924byqc+JrhUYMm2STueF/gtihQYY=;
b=0StuGbDB6OagTfp5TlyynCXj89VMpNeaGbiQoyASbI7uL1eQIxJV9dmrWlVoh3TdwC
fLL0hf5ypWkIEwemNeW0vCehd8RDJ5cu9VrRKbwdjprG6mXBR2vEt0ydUd15i/sBNDHr
t3uhjTaEipDWxcK8wE6rVgn8Dt1xO2iZNn9Ff+Q6l/7tuAZVXXxINB+cWGPZftth7QV2
BLchqQiJFoecxLWqJpepaRIYM5oD9r/hNgviX0S22jow3YbAx35/POGsAa35PWS2AdKj
t63VD19kWvRp/PNjLUhu8Grr1l4Vf4Fxfb5eBETlE0yCpxsyab0dyUH3JVNL0vdRCfza
JRHw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=XOM3Sq7Q;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
y30-20020a170906519e00b0087f5eb7d738si21974465ejk.618.2023.02.02.02.48.08;
Thu, 02 Feb 2023 02:48:31 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=XOM3Sq7Q;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232807AbjBBKrL (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others);
Thu, 2 Feb 2023 05:47:11 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43512 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230021AbjBBKqk (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 2 Feb 2023 05:46:40 -0500
Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com
[IPv6:2a00:1450:4864:20::32b])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94B2D80163
for <linux-kernel@vger.kernel.org>;
Thu, 2 Feb 2023 02:46:06 -0800 (PST)
Received: by mail-wm1-x32b.google.com with SMTP id
hn2-20020a05600ca38200b003dc5cb96d46so3378186wmb.4
for <linux-kernel@vger.kernel.org>;
Thu, 02 Feb 2023 02:46:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=0BFZdJAFzmaSb6924byqc+JrhUYMm2STueF/gtihQYY=;
b=XOM3Sq7QT7VmJDGPc10KBQWq2W8MLane6C430TttEecD1rpuEa3sGwGoz+fsNPVcu+
K06p7l8qkSt9E+7LH7A1W+lyg68m9+Nbeafoe10TFQRRIciYtV29HpTATjUvHrz21E8N
U3ZgRPco1DgZgKk/yVQ5KB0DvQxbQZAuDK+Mx8rfa0y90ONJfyG7I6c2CmaClZ3D6kk1
WHtoOPCjjXuBQfrRh/i6oKFO7sAt2LwEZLBJL0eKPgTrEOCkt1ELh1LT0KRJtZY4xw6l
BrNa0lJxpwDz89vS3z6xlIAXQjPb8PP+KQFAkG1YwjS5/tJDIebCVwGniCdUJBFC70RH
F1Cw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=0BFZdJAFzmaSb6924byqc+JrhUYMm2STueF/gtihQYY=;
b=XoFg3JB/IWw/cxucQGgwio6mbb0VFXZFz6x2a3ePVCe6wOBijtHimQ0hgun/kjLzmU
QY1OER23IFOS+ZtZQNseHoGBZI4mD9+ogV22gb82DlIwHEly8pLEl2s84POvxMLkox6e
U6LHolL9cAY7UqGGuW0IAM7hnb5NRcugIU2C3yIW2pLNerLAARfMBzmlxFv08JBQlBkr
49yY1vh+yXttwZAfG7Rj+7LhPc6u6tYHj8unOeErnEhTF5upDXs9f6egpJDrahW2uBQ/
srssvM711Wi2ERuDZBpYnQW02uWeKxt/CnbpxytIWD+yTHNLDaf5aAS4NDnHPvPcb9uF
y3UQ==
X-Gm-Message-State: AO0yUKVyW4QXH6DJcTvpGFdg9Z8fW+yS4ycQKr4yB7KWn+c0VJOY07uu
wNI6PEQkmwN5lqMPolzBt7T3Fw==
X-Received: by 2002:a05:600c:5404:b0:3dc:4355:25f6 with SMTP id
he4-20020a05600c540400b003dc435525f6mr1468122wmb.26.1675334753990;
Thu, 02 Feb 2023 02:45:53 -0800 (PST)
Received: from krzk-bin.. ([178.197.216.144])
by smtp.gmail.com with ESMTPSA id
n24-20020a05600c181800b003dc3f195abesm4307329wmp.39.2023.02.02.02.45.52
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 02 Feb 2023 02:45:53 -0800 (PST)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>,
Vinod Koul <vkoul@kernel.org>,
Vladimir Lypak <vladimir.lypak@gmail.com>,
Luca Weiss <luca@z3ntu.xyz>, Iskren Chernev <me@iskren.info>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH v2 02/10] dt-bindings: pinctrl: qcom,msm8909: correct GPIO
name pattern and example
Date: Thu, 2 Feb 2023 11:44:44 +0100
Message-Id: <20230202104452.299048-3-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230202104452.299048-1-krzysztof.kozlowski@linaro.org>
References: <20230202104452.299048-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1756715980343556034?=
X-GMAIL-MSGID: =?utf-8?q?1756715980343556034?=
|
| Series |
pinctrl/ARM/arm64: qcom: correct TLMM gpio-ranges and GPIO pin names
|
|
Commit Message
Krzysztof Kozlowski
Feb. 2, 2023, 10:44 a.m. UTC
The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern
and gpio-ranges in the example.
Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
---
.../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Thu, Feb 02, 2023 at 11:44:44AM +0100, Krzysztof Kozlowski wrote: > The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern > and gpio-ranges in the example. > > Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Stephan Gerhold <stephan@gerhold.net> > --- > .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > index 449e6e34be61..85082adc1811 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > @@ -63,7 +63,7 @@ $defs: > subnode. > items: > oneOf: > - - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$" > + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" > - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, > sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1, > qdsd_data2, qdsd_data3 ] > @@ -127,7 +127,7 @@ examples: > interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; > gpio-controller; > #gpio-cells = <2>; > - gpio-ranges = <&tlmm 0 0 117>; > + gpio-ranges = <&tlmm 0 0 113>; I thought 112 was the max? > interrupt-controller; > #interrupt-cells = <2>; > > -- > 2.34.1 >
On Thu, Feb 2, 2023 at 6:01 PM Rob Herring <robh@kernel.org> wrote: > > On Thu, Feb 02, 2023 at 11:44:44AM +0100, Krzysztof Kozlowski wrote: > > The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern > > and gpio-ranges in the example. > > > > Fixes: c249ec7ba1b1 ("dt-bindings: pinctrl: Add DT schema for qcom,msm8909-tlmm") > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Stephan Gerhold <stephan@gerhold.net> > > --- > > .../devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > > index 449e6e34be61..85082adc1811 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > > @@ -63,7 +63,7 @@ $defs: > > subnode. > > items: > > oneOf: > > - - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$" > > + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" > > - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, > > sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1, > > qdsd_data2, qdsd_data3 ] > > @@ -127,7 +127,7 @@ examples: > > interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; > > gpio-controller; > > #gpio-cells = <2>; > > - gpio-ranges = <&tlmm 0 0 117>; > > + gpio-ranges = <&tlmm 0 0 113>; > > I thought 112 was the max? That's the count, duh. Acked-by: Rob Herring <robh@kernel.org>
On Thu, 2 Feb 2023 11:44:44 +0100, Krzysztof Kozlowski wrote: > The MSM8909 TLMM pin controller has GPIOs 0-112, so narrow the pattern > and gpio-ranges in the example. > > Applied, thanks! [02/10] dt-bindings: pinctrl: qcom,msm8909: correct GPIO name pattern and example https://git.kernel.org/krzk/linux-dt/c/87b93dd1fbb23b9bbae461bb2c01f6d93c7524d9 Best regards,
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml index 449e6e34be61..85082adc1811 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml @@ -63,7 +63,7 @@ $defs: subnode. items: oneOf: - - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-7])$" + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" - enum: [ sdc1_clk, sdc1_cmd, sdc1_data, sdc2_clk, sdc2_cmd, sdc2_data, qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1, qdsd_data2, qdsd_data3 ] @@ -127,7 +127,7 @@ examples: interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; gpio-controller; #gpio-cells = <2>; - gpio-ranges = <&tlmm 0 0 117>; + gpio-ranges = <&tlmm 0 0 113>; interrupt-controller; #interrupt-cells = <2>;