Message ID | 20230201054815.4112632-2-dmitry.torokhov@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp100560wrn; Tue, 31 Jan 2023 21:50:53 -0800 (PST) X-Google-Smtp-Source: AK7set8fTszyZU2W6OqF5BUrY1TOTGQdM97/J++EI+Kaj4Nj1IhS9hsTH0cdEVnvdBS7Yz6MRG9h X-Received: by 2002:a17:906:744:b0:888:9693:fb18 with SMTP id z4-20020a170906074400b008889693fb18mr365605ejb.37.1675230653194; Tue, 31 Jan 2023 21:50:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675230653; cv=none; d=google.com; s=arc-20160816; b=CVwah/m7MFABnbIY5gjOX2Ms07RnzTq/qErkQI3vtDrbfeeVcJt5iDhlH8msGjG3Cr J2mX0JqfQLDpDsgOT929cxXeagCHNeH0jv32Wwo0INfkwQjVwr3N2Wtvd+M1yrGm8Q9X cca+e55t/VJ8RmfjrQ/wdqrK+YfnRC0QZ7+zbulsZuKAv7r0JNYhLe4xG8qxZyI0FKHf On2aQQoqMnuo0961boR2NnkvtSPi1KgJu/hS+MVDYI+hIsbJzgOZ6aQGiecrjq0ztmO6 xpWYmXNYDb4iumLvOaVmc8W4nntiv7bueqQk6cST6bhJhVcWa9eIlrJwRVQqs0mgaRN9 uQWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2feaPTiFf6nFchWNFm62ii1folwFLguTnGsIZ0OJssw=; b=FEnJqFlR3BdKj4nrSNWLqpvav0HH37+Wh6qyZm7YIiiO+9eNcOreVmaXM+W0OVXdZa RgkcsL0n2UjG3tc/mjZFrGLdDE8eiHtlUSmrUeVMegG0o/1A2s20CyzLGUV8tdt9deiN sgvgcdJKjx3IWPvOPFc+tDQv2tTYAk6hzd98O5zzCcLJOLB6WUVk4pE9ksmTMbLke1Gq TKlbXFLjfwtFR9CBxjJ8nQA3KraH+TVA/g8SIqVnItQhLSy/1hqxfL8cYDWXB4YiyM1S 3cqYkvZdqjKplaq0I4qVHugbuv50wFwGQrKmdXTtakoQXnqdu1BHBuhSUM0LC0RV4JYS P1yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YMpzAQ8f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id vl7-20020a17090730c700b008889a6323absi8642268ejb.511.2023.01.31.21.50.28; Tue, 31 Jan 2023 21:50:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=YMpzAQ8f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbjBAFsb (ORCPT <rfc822;duw91626@gmail.com> + 99 others); Wed, 1 Feb 2023 00:48:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231329AbjBAFs1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 1 Feb 2023 00:48:27 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0D3166E5; Tue, 31 Jan 2023 21:48:22 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id t12-20020a17090aae0c00b00229f4cff534so2638361pjq.1; Tue, 31 Jan 2023 21:48:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2feaPTiFf6nFchWNFm62ii1folwFLguTnGsIZ0OJssw=; b=YMpzAQ8fSIRxXawrqIgaOXYDEBG33SRSWpmrJnMmSK2OmQZgwHGwnRbudSsCj+yyxr 3rTv0zv0BkaTn18vomuhgoyWeFUmoeWGkQoBuUTf3erEAD98ucoD0r20wrTQSffGrGIW qaR+uoKXBbLnFh7MGh7cIhqvQkPtLpkhzHv0VqK9lBQMS01ESJ5UZv9v7xu/eWFgmHZJ rRrcPK4aZFTZbbQnoRXpPqVXPinXGowI1lPB3lxXcfDvE41gKH5hfQXejCqquluqsBEJ Xc8J4DtqgF76zAOle7igHctSN7wHKCEfBQoz86Onk68CZW/sO5F9AwF030MvmWVJWF/z 8XbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2feaPTiFf6nFchWNFm62ii1folwFLguTnGsIZ0OJssw=; b=Px9bGtvh2qfHWksl7RpSKEaTyngELDTyLtwhNQdVhslko3I48CYYcoYribQsYu3ZU3 FuRP+uXUhGktayKO/ipZjXySP9mt3Zzp58HEhTR7jsa/9Fq7fYuDO3U+ZNMyyOD3Xiah kvFhznMxlWLF+Cw1IdrbH48K7gjekIr19wJxJ4cjY38RI2bFGJZs9c4zw+MtVQK/xj59 JaI5mOcNUHRg4lpwH9oIusMRkL5C3ADJE0ilXccFJANGRMZbvyN2Xw9UbLcjxyw6Kfk7 YcJ09A8ttoYm7hVVROkmvBoLGmCLi1etCXEJuXLPvNJgbOlK8p5R3nP7P26/XCq44Eb1 xsNA== X-Gm-Message-State: AO0yUKVJZDIyjE+8r06wzyZozl9FtVu2FDO1G1CAzpVC2wNjPUPz8oqR bb86Kd7VxEhies9CQOWZ9Tk= X-Received: by 2002:a17:903:1111:b0:196:6ec4:52db with SMTP id n17-20020a170903111100b001966ec452dbmr1854428plh.51.1675230502394; Tue, 31 Jan 2023 21:48:22 -0800 (PST) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:ce3a:44de:62b3:7a4b]) by smtp.gmail.com with ESMTPSA id w2-20020a1709027b8200b00196025a34b9sm7461575pll.159.2023.01.31.21.48.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 21:48:21 -0800 (PST) From: Dmitry Torokhov <dmitry.torokhov@gmail.com> To: Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Arnd Bergmann <arnd@arndb.de>, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 2/3] dt-bindings: rtc: moxart: use proper names for gpio properties Date: Tue, 31 Jan 2023 21:48:14 -0800 Message-Id: <20230201054815.4112632-2-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.39.1.456.gfc5497dd1b-goog In-Reply-To: <20230201054815.4112632-1-dmitry.torokhov@gmail.com> References: <20230201054815.4112632-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756606657297869598?= X-GMAIL-MSGID: =?utf-8?q?1756606657297869598?= |
Series |
[1/3] rtc: moxart: switch to using gpiod API
|
|
Commit Message
Dmitry Torokhov
Feb. 1, 2023, 5:48 a.m. UTC
MOXA ART RTC driver has been switched to gpiod API and is now using
properly named properties for its gpios (with gpiolib implementing a
quirk to recognize legacy names). Change binding document to use
proper names as well.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
.../devicetree/bindings/rtc/moxa,moxart-rtc.txt | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
Comments
On 01/02/2023 06:48, Dmitry Torokhov wrote: > MOXA ART RTC driver has been switched to gpiod API and is now using > properly named properties for its gpios (with gpiolib implementing a > quirk to recognize legacy names). Change binding document to use > proper names as well. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > .../devicetree/bindings/rtc/moxa,moxart-rtc.txt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > index c9d3ac1477fe..1374df7bf9d6 100644 > --- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > +++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > @@ -3,15 +3,15 @@ MOXA ART real-time clock > Required properties: > > - compatible : Should be "moxa,moxart-rtc" > -- gpio-rtc-sclk : RTC sclk gpio, with zero flags > -- gpio-rtc-data : RTC data gpio, with zero flags > -- gpio-rtc-reset : RTC reset gpio, with zero flags > +- rtc-sclk-gpios : RTC sclk gpio, with zero flags > +- rtc-data-gpios : RTC data gpio, with zero flags > +- rtc-reset-gpios : RTC reset gpio, with zero flags Your driver breaks the ABI, doesn't it? If not, how are the old properties parsed? Best regards, Krzysztof
On Wed, Feb 01, 2023 at 08:38:48AM +0100, Krzysztof Kozlowski wrote: > On 01/02/2023 06:48, Dmitry Torokhov wrote: > > MOXA ART RTC driver has been switched to gpiod API and is now using > > properly named properties for its gpios (with gpiolib implementing a > > quirk to recognize legacy names). Change binding document to use > > proper names as well. > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > --- > > .../devicetree/bindings/rtc/moxa,moxart-rtc.txt | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > index c9d3ac1477fe..1374df7bf9d6 100644 > > --- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > +++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > @@ -3,15 +3,15 @@ MOXA ART real-time clock > > Required properties: > > > > - compatible : Should be "moxa,moxart-rtc" > > -- gpio-rtc-sclk : RTC sclk gpio, with zero flags > > -- gpio-rtc-data : RTC data gpio, with zero flags > > -- gpio-rtc-reset : RTC reset gpio, with zero flags > > +- rtc-sclk-gpios : RTC sclk gpio, with zero flags > > +- rtc-data-gpios : RTC data gpio, with zero flags > > +- rtc-reset-gpios : RTC reset gpio, with zero flags > > Your driver breaks the ABI, doesn't it? If not, how are the old > properties parsed? It does not. As I mentioned in the driver code patch, commit eaf1a29665cd ("gpiolib: of: add a quirk for legacy names in MOXA ART RTC") makes sure gpiolib falls back to trying old variants if it can't locate properly formatted names. Thanks.
On Wed, Feb 01, 2023 at 08:15:26AM -0800, Dmitry Torokhov wrote: > On Wed, Feb 01, 2023 at 08:38:48AM +0100, Krzysztof Kozlowski wrote: > > On 01/02/2023 06:48, Dmitry Torokhov wrote: > > > MOXA ART RTC driver has been switched to gpiod API and is now using > > > properly named properties for its gpios (with gpiolib implementing a > > > quirk to recognize legacy names). Change binding document to use > > > proper names as well. > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > --- > > > .../devicetree/bindings/rtc/moxa,moxart-rtc.txt | 12 ++++++------ > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > index c9d3ac1477fe..1374df7bf9d6 100644 > > > --- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > +++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > @@ -3,15 +3,15 @@ MOXA ART real-time clock > > > Required properties: > > > > > > - compatible : Should be "moxa,moxart-rtc" > > > -- gpio-rtc-sclk : RTC sclk gpio, with zero flags > > > -- gpio-rtc-data : RTC data gpio, with zero flags > > > -- gpio-rtc-reset : RTC reset gpio, with zero flags > > > +- rtc-sclk-gpios : RTC sclk gpio, with zero flags > > > +- rtc-data-gpios : RTC data gpio, with zero flags > > > +- rtc-reset-gpios : RTC reset gpio, with zero flags > > > > Your driver breaks the ABI, doesn't it? If not, how are the old > > properties parsed? > > It does not. As I mentioned in the driver code patch, commit > eaf1a29665cd ("gpiolib: of: add a quirk for legacy names in MOXA ART > RTC") makes sure gpiolib falls back to trying old variants if it can't > locate properly formatted names. A dtb with the new names and a kernel without the gpiod conversion would be broken. Up to the platform whether they care really. Rob
On Wed, Feb 01, 2023 at 11:55:04AM -0600, Rob Herring wrote: > On Wed, Feb 01, 2023 at 08:15:26AM -0800, Dmitry Torokhov wrote: > > On Wed, Feb 01, 2023 at 08:38:48AM +0100, Krzysztof Kozlowski wrote: > > > On 01/02/2023 06:48, Dmitry Torokhov wrote: > > > > MOXA ART RTC driver has been switched to gpiod API and is now using > > > > properly named properties for its gpios (with gpiolib implementing a > > > > quirk to recognize legacy names). Change binding document to use > > > > proper names as well. > > > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > --- > > > > .../devicetree/bindings/rtc/moxa,moxart-rtc.txt | 12 ++++++------ > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > > index c9d3ac1477fe..1374df7bf9d6 100644 > > > > --- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > > +++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > > @@ -3,15 +3,15 @@ MOXA ART real-time clock > > > > Required properties: > > > > > > > > - compatible : Should be "moxa,moxart-rtc" > > > > -- gpio-rtc-sclk : RTC sclk gpio, with zero flags > > > > -- gpio-rtc-data : RTC data gpio, with zero flags > > > > -- gpio-rtc-reset : RTC reset gpio, with zero flags > > > > +- rtc-sclk-gpios : RTC sclk gpio, with zero flags > > > > +- rtc-data-gpios : RTC data gpio, with zero flags > > > > +- rtc-reset-gpios : RTC reset gpio, with zero flags > > > > > > Your driver breaks the ABI, doesn't it? If not, how are the old > > > properties parsed? > > > > It does not. As I mentioned in the driver code patch, commit > > eaf1a29665cd ("gpiolib: of: add a quirk for legacy names in MOXA ART > > RTC") makes sure gpiolib falls back to trying old variants if it can't > > locate properly formatted names. > > A dtb with the new names and a kernel without the gpiod conversion would > be broken. Up to the platform whether they care really. Seriously? And I guess devices with DTS do not work with kernels v2.0 so we should never have introduced it... I understand wanting backward compatibility, but asking for both backward and forward is a bit too much IMO. Thanks.
On Wed, Feb 01, 2023 at 11:02:39AM -0800, Dmitry Torokhov wrote: > On Wed, Feb 01, 2023 at 11:55:04AM -0600, Rob Herring wrote: > > On Wed, Feb 01, 2023 at 08:15:26AM -0800, Dmitry Torokhov wrote: > > > On Wed, Feb 01, 2023 at 08:38:48AM +0100, Krzysztof Kozlowski wrote: > > > > On 01/02/2023 06:48, Dmitry Torokhov wrote: > > > > > MOXA ART RTC driver has been switched to gpiod API and is now using > > > > > properly named properties for its gpios (with gpiolib implementing a > > > > > quirk to recognize legacy names). Change binding document to use > > > > > proper names as well. > > > > > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > > --- > > > > > .../devicetree/bindings/rtc/moxa,moxart-rtc.txt | 12 ++++++------ > > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > > > index c9d3ac1477fe..1374df7bf9d6 100644 > > > > > --- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > > > +++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > > > @@ -3,15 +3,15 @@ MOXA ART real-time clock > > > > > Required properties: > > > > > > > > > > - compatible : Should be "moxa,moxart-rtc" > > > > > -- gpio-rtc-sclk : RTC sclk gpio, with zero flags > > > > > -- gpio-rtc-data : RTC data gpio, with zero flags > > > > > -- gpio-rtc-reset : RTC reset gpio, with zero flags > > > > > +- rtc-sclk-gpios : RTC sclk gpio, with zero flags > > > > > +- rtc-data-gpios : RTC data gpio, with zero flags > > > > > +- rtc-reset-gpios : RTC reset gpio, with zero flags > > > > > > > > Your driver breaks the ABI, doesn't it? If not, how are the old > > > > properties parsed? > > > > > > It does not. As I mentioned in the driver code patch, commit > > > eaf1a29665cd ("gpiolib: of: add a quirk for legacy names in MOXA ART > > > RTC") makes sure gpiolib falls back to trying old variants if it can't > > > locate properly formatted names. > > > > A dtb with the new names and a kernel without the gpiod conversion would > > be broken. Up to the platform whether they care really. > > Seriously? And I guess devices with DTS do not work with kernels v2.0 so > we should never have introduced it... They would be fine because they would ignore the dtb. ;) > I understand wanting backward compatibility, but asking for both > backward and forward is a bit too much IMO. Like I said, up to the platform to decide. I'm just defining what's an ABI break or not. If the dtb ships with firmware, do you want new firmware with a newer dtb to break your OS? We can sometimes mitigate that with stable kernel updates. There are obvious cases that don't work such as adding providers such as clocks (instead of dummy fixed clocks) or pinctrl, where old kernels will never have the driver (but doesn't know that). Rob
On Thu, Feb 02, 2023 at 05:27:34PM -0600, Rob Herring wrote: > On Wed, Feb 01, 2023 at 11:02:39AM -0800, Dmitry Torokhov wrote: > > On Wed, Feb 01, 2023 at 11:55:04AM -0600, Rob Herring wrote: > > > On Wed, Feb 01, 2023 at 08:15:26AM -0800, Dmitry Torokhov wrote: > > > > On Wed, Feb 01, 2023 at 08:38:48AM +0100, Krzysztof Kozlowski wrote: > > > > > On 01/02/2023 06:48, Dmitry Torokhov wrote: > > > > > > MOXA ART RTC driver has been switched to gpiod API and is now using > > > > > > properly named properties for its gpios (with gpiolib implementing a > > > > > > quirk to recognize legacy names). Change binding document to use > > > > > > proper names as well. > > > > > > > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > > > --- > > > > > > .../devicetree/bindings/rtc/moxa,moxart-rtc.txt | 12 ++++++------ > > > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > > > > index c9d3ac1477fe..1374df7bf9d6 100644 > > > > > > --- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > > > > +++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt > > > > > > @@ -3,15 +3,15 @@ MOXA ART real-time clock > > > > > > Required properties: > > > > > > > > > > > > - compatible : Should be "moxa,moxart-rtc" > > > > > > -- gpio-rtc-sclk : RTC sclk gpio, with zero flags > > > > > > -- gpio-rtc-data : RTC data gpio, with zero flags > > > > > > -- gpio-rtc-reset : RTC reset gpio, with zero flags > > > > > > +- rtc-sclk-gpios : RTC sclk gpio, with zero flags > > > > > > +- rtc-data-gpios : RTC data gpio, with zero flags > > > > > > +- rtc-reset-gpios : RTC reset gpio, with zero flags > > > > > > > > > > Your driver breaks the ABI, doesn't it? If not, how are the old > > > > > properties parsed? > > > > > > > > It does not. As I mentioned in the driver code patch, commit > > > > eaf1a29665cd ("gpiolib: of: add a quirk for legacy names in MOXA ART > > > > RTC") makes sure gpiolib falls back to trying old variants if it can't > > > > locate properly formatted names. > > > > > > A dtb with the new names and a kernel without the gpiod conversion would > > > be broken. Up to the platform whether they care really. > > > > Seriously? And I guess devices with DTS do not work with kernels v2.0 so > > we should never have introduced it... > > They would be fine because they would ignore the dtb. ;) > > > I understand wanting backward compatibility, but asking for both > > backward and forward is a bit too much IMO. > > Like I said, up to the platform to decide. I'm just defining what's an > ABI break or not. > > If the dtb ships with firmware, do you want new firmware with a newer > dtb to break your OS? We can sometimes mitigate that with stable kernel > updates. There are obvious cases that don't work such as adding > providers such as clocks (instead of dummy fixed clocks) or pinctrl, > where old kernels will never have the driver (but doesn't know that). When vendors ship firmware they target particular set of software that runs on it, so they would not mindlessly jump to the very latest version of binding. Doing that would be similar to a vendor that originally shipped a system with Windows 7 out of sudden changing its firmware to use latest and greatest mechanisms defined in ACPI 6.5 and removing older ones. Thanks.
diff --git a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt index c9d3ac1477fe..1374df7bf9d6 100644 --- a/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt +++ b/Documentation/devicetree/bindings/rtc/moxa,moxart-rtc.txt @@ -3,15 +3,15 @@ MOXA ART real-time clock Required properties: - compatible : Should be "moxa,moxart-rtc" -- gpio-rtc-sclk : RTC sclk gpio, with zero flags -- gpio-rtc-data : RTC data gpio, with zero flags -- gpio-rtc-reset : RTC reset gpio, with zero flags +- rtc-sclk-gpios : RTC sclk gpio, with zero flags +- rtc-data-gpios : RTC data gpio, with zero flags +- rtc-reset-gpios : RTC reset gpio, with zero flags Example: rtc: rtc { compatible = "moxa,moxart-rtc"; - gpio-rtc-sclk = <&gpio 5 0>; - gpio-rtc-data = <&gpio 6 0>; - gpio-rtc-reset = <&gpio 7 0>; + rtc-sclk-gpios = <&gpio 5 0>; + rtc-data-gpios = <&gpio 6 0>; + rtc-reset-gpios = <&gpio 7 0>; };