diff mbox series

[v3,1/6] ASoC: amd: yc: Adjust the gain for PDM DMIC

Message ID 20230131184653.10216-2-mario.limonciello@amd.com
State New
Headers
Series Fix default DMIC gain on AMD PDM drivers |

Commit Message

Mario Limonciello Jan. 31, 2023, 6:46 p.m. UTC 
  A number of users for Lenovo Rembrandt based laptops are
reporting that the microphone is too quiet relative to
Windows with a dual boot.

Increase the PDM gain to overcome this problem.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 sound/soc/amd/yc/acp6x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Feb. 2, 2023, 11:42 a.m. UTC | #1 
On Tue, Jan 31, 2023 at 12:46:47PM -0600, Mario Limonciello wrote:
> A number of users for Lenovo Rembrandt based laptops are
> reporting that the microphone is too quiet relative to
> Windows with a dual boot.

If you're sending a cover letter for a series you should send it to the
maintainers as well, not just the patches.
Mario Limonciello Feb. 2, 2023, 1:38 p.m. UTC | #2 
On 2/2/23 05:42, Mark Brown wrote:
> On Tue, Jan 31, 2023 at 12:46:47PM -0600, Mario Limonciello wrote:
>> A number of users for Lenovo Rembrandt based laptops are
>> reporting that the microphone is too quiet relative to
>> Windows with a dual boot.
> 
> If you're sending a cover letter for a series you should send it to the
> maintainers as well, not just the patches.

My apologies.  My scripts to get maintainers to send to sometimes fail 
on cover letters and I didn't do a manual fix up.

Would you like me to resend the series?
Mark Brown Feb. 2, 2023, 1:42 p.m. UTC | #3 
On Thu, Feb 02, 2023 at 07:38:55AM -0600, Mario Limonciello wrote:

> Would you like me to resend the series?

No, it's fine.
diff mbox series

Patch

diff --git a/sound/soc/amd/yc/acp6x.h b/sound/soc/amd/yc/acp6x.h
index 74b596e6807ad..846ca10e24d3f 100644
--- a/sound/soc/amd/yc/acp6x.h
+++ b/sound/soc/amd/yc/acp6x.h
@@ -31,7 +31,7 @@ 
 #define ACP_ERROR_STAT	29
 #define PDM_DECIMATION_FACTOR	2
 #define ACP_PDM_CLK_FREQ_MASK	7
-#define ACP_WOV_MISC_CTRL_MASK	0x10
+#define ACP_WOV_MISC_CTRL_MASK	0x18
 #define ACP_PDM_ENABLE		1
 #define ACP_PDM_DISABLE		0
 #define ACP_PDM_DMA_EN_STATUS	2