Message ID | 20230201101559.15529-2-johan+linaro@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp192085wrn; Wed, 1 Feb 2023 02:18:49 -0800 (PST) X-Google-Smtp-Source: AK7set8B2TENvJOlHKvgtYgCCCDutDIM5InAxAZC144KUao1cJTJGkWxqxAcsfto6jX6z2wGoS2L X-Received: by 2002:aa7:d959:0:b0:4a1:7543:d6ad with SMTP id l25-20020aa7d959000000b004a17543d6admr1344169eds.28.1675246729385; Wed, 01 Feb 2023 02:18:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675246729; cv=none; d=google.com; s=arc-20160816; b=L+NTfU+cHfWLn8fdgTF0xhiAqM49bHrOqjQ31hituKUXeXz0pot8DO+EAfHA5iPFH/ 4i6Y8R/QrFl7t4GNIqwRlSq54uCQbDfu+/XWtah4ke37S8BhtwZarALM3zIZvzt3SLVR L9imIgPCxmdjgzDOCLVJFJoODs5t54CVdMVh6RdMKy9p/VAsUK8VlN1F61rgJOgn77+8 Mxm8NZ6LZUYa4xN5IVJ9Q6quATL9sfZe+z7C2mpSKzu4AbA7UOWrqbv9wC0EdkN+NJ71 Tr+G2e3UpSXhdhQFuG+fY1yiQmQyfWt8pyYjOXIfDNOexJu5MaPtTD3XYddtEd1LNQIk MkhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UO1Mkqv7/tLEnxFq/EfFFl9WWiJXKuGb4eg9Ewjvpdk=; b=ERaWv//IoBiJKXj0AocaSD1u7P6wVDMJG5xwXqdnBYX6BvZr6CV3hW5VTeYYluHSod 6DBEecIkSWVPEmryVWBI0DMUkMES/Z6TjW4uRCMBmZ4Z1N83Ho77m3O0H1BZgR1TUZCB HTkrUwuW5bREcwU6j/wIQHW1QgGiJqlKknl0Jl7j0m19R91gitDhBG3nUyfrb4n3kMmo O+rfl5OIyMpc7PO/Uw4Z0nOVhMVh0InFymzF8ct4CY9wDOzg2UlfDLMtz46wc5EamKBL h5nFyTuIARLh6hOprNutOTUe04K5wj5WPO1a4TxoQ1f/KlIS7c8ZrN0PCULplqELCZ9K y3MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q+YA47U1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fd6-20020a056402388600b004a2662b3c33si6255656edb.280.2023.02.01.02.18.08; Wed, 01 Feb 2023 02:18:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Q+YA47U1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232341AbjBAKRA (ORCPT <rfc822;duw91626@gmail.com> + 99 others); Wed, 1 Feb 2023 05:17:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232054AbjBAKQg (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 1 Feb 2023 05:16:36 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 158204F875; Wed, 1 Feb 2023 02:16:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC4BFB82153; Wed, 1 Feb 2023 10:16:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B2EFC433EF; Wed, 1 Feb 2023 10:16:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675246592; bh=/jzNzk0NhS4/FCAYMQWbqL9kCfrOP5Et7Jn12aqIVFU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q+YA47U1a6hCaCVthi4li1QCYeGP257njXnsax7cF7vyUdfw+PX2v1hqVMA6UlBw+ YuPfezKfhCBEmIET1emJ6B3y8ds76bJ6fG5G5/aVghIa1qfXcKJEQyc5QUAEqIoBd+ fQERzie+TjiOc+d9ShKB6NIs0jxI3EEF53q7mi1jP8KGLvFSc5pXh4ybyKUYZMg+dn cz/1zhVCDIfOHXbV2zBYY/52jXkvKlnPRfXzwy6k976L23q6lwFUjdNGcRGqwYarGA S/aPmVgLQQdAKYSN/OY0RbjC/HK55r5sMzpCrkEQaKvpwPLgAKbMlZHerk3BVH0UGd mrdxWSarhh1Uw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from <johan+linaro@kernel.org>) id 1pNAAf-00043i-2E; Wed, 01 Feb 2023 11:16:53 +0100 From: Johan Hovold <johan+linaro@kernel.org> To: Georgi Djakov <djakov@kernel.org> Cc: Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, =?utf-8?b?QXJ0dXIgxZp3aWdvxYQ=?= <a.swigon@samsung.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org>, stable@vger.kernel.org, Georgi Djakov <georgi.djakov@linaro.org> Subject: [PATCH 01/23] interconnect: fix mem leak when freeing nodes Date: Wed, 1 Feb 2023 11:15:37 +0100 Message-Id: <20230201101559.15529-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230201101559.15529-1-johan+linaro@kernel.org> References: <20230201101559.15529-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756623514428826781?= X-GMAIL-MSGID: =?utf-8?q?1756623514428826781?= |
Series |
interconnect: fix racy provider registration
|
|
Commit Message
Johan Hovold
Feb. 1, 2023, 10:15 a.m. UTC
The node link array is allocated when adding links to a node but is not
deallocated when nodes are destroyed.
Fixes: 11f1ceca7031 ("interconnect: Add generic on-chip interconnect API")
Cc: stable@vger.kernel.org # 5.1
Cc: Georgi Djakov <georgi.djakov@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/interconnect/core.c | 1 +
1 file changed, 1 insertion(+)
Comments
On 1.02.2023 11:15, Johan Hovold wrote: > The node link array is allocated when adding links to a node but is not > deallocated when nodes are destroyed. > > Fixes: 11f1ceca7031 ("interconnect: Add generic on-chip interconnect API") > Cc: stable@vger.kernel.org # 5.1 > Cc: Georgi Djakov <georgi.djakov@linaro.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/interconnect/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c > index 423f875d4b54..dc61620a0191 100644 > --- a/drivers/interconnect/core.c > +++ b/drivers/interconnect/core.c > @@ -850,6 +850,7 @@ void icc_node_destroy(int id) > > mutex_unlock(&icc_lock); > > + kfree(node->links); > kfree(node); > } > EXPORT_SYMBOL_GPL(icc_node_destroy);
diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index 423f875d4b54..dc61620a0191 100644 --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -850,6 +850,7 @@ void icc_node_destroy(int id) mutex_unlock(&icc_lock); + kfree(node->links); kfree(node); } EXPORT_SYMBOL_GPL(icc_node_destroy);