diff mbox series

[v2] dt-bindings: mmc: Add cap-aggressive-pm property

Message ID 20230130064433.962712-1-chenhuiz@axis.com
State New
Headers
Series [v2] dt-bindings: mmc: Add cap-aggressive-pm property |

Commit Message

Hermes Zhang Jan. 30, 2023, 6:44 a.m. UTC 
  Add a new property: cap-aggressive-pm to enable the
MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
---

Notes:
    Update commit message

 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring Jan. 30, 2023, 10:44 p.m. UTC | #1 
On Mon, Jan 30, 2023 at 02:44:33PM +0800, Hermes Zhang wrote:
> Add a new property: cap-aggressive-pm to enable the
> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Is that a kernel feature or something from the MMC or SD specifications? 
The former doesn't belong in DT. Set this based on the compatible string 
of the controller.

> 
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
> 
> Notes:
>     Update commit message
> 
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 86c73fd825fd..7ca674263dba 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -177,6 +177,11 @@ properties:
>      description:
>        enable SDIO IRQ signalling on this interface
>  
> +  cap-aggressive-pm:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      enable MMC_CAP_AGGRESSIVE_PM feature
> +
>    full-pwr-cycle:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> -- 
> 2.30.2
>
Krzysztof Kozlowski Jan. 31, 2023, 7:16 p.m. UTC | #2 
On 30/01/2023 07:44, Hermes Zhang wrote:
> Add a new property: cap-aggressive-pm to enable the
> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.
> 
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>


We did not finish discussion from v1 as you did not really answer my
concerns there. Don't send v2 because it looks like you cut the
discussion and ignore the feedback.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index 86c73fd825fd..7ca674263dba 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -177,6 +177,11 @@  properties:
     description:
       enable SDIO IRQ signalling on this interface
 
+  cap-aggressive-pm:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      enable MMC_CAP_AGGRESSIVE_PM feature
+
   full-pwr-cycle:
     $ref: /schemas/types.yaml#/definitions/flag
     description: