Message ID | 20230130035556.694814-1-rkannoth@marvell.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1995328wrn; Sun, 29 Jan 2023 19:58:29 -0800 (PST) X-Google-Smtp-Source: AK7set/F68MVcGPS6QBN9JPJr+H13wMRrZJ5z+HyIvulgFun4UQEM/iEzPAXwk/3oFaPwFha+yeg X-Received: by 2002:a17:906:784e:b0:889:d998:1576 with SMTP id p14-20020a170906784e00b00889d9981576mr508954ejm.66.1675051108950; Sun, 29 Jan 2023 19:58:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675051108; cv=none; d=google.com; s=arc-20160816; b=uTbQ6KkgXAjymcnIbJWrXHDYSm3ncwr/d2We1oDDnrgG7r99+5n6ZRRKtV6Mu0rhM4 +UmrAVIn3xw7PJ7OgPKRROw/Wo79ksEOrbVwNrhhkhqn3HJrcFZ6EYSQt5P+LcdTv3z4 k9E1o11nfZ/n9drsytZytAM3MkQclPQ6zlLwxuCNIPkla1P+PdqRKCS3iI8A92noFjVb +EML7ncpYNO2yJ1rSYFNJi0iYKdeXEypGlDgj+/qmxAuGttdG0PPCr97X/p1ceNtuOXw 05FsbNj+kYn0WA6z5cuaxJkDs2D95MQcpScCB/Znb0uNeBm1BVNDUXQ0FNjByuowpteC cjeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2BkxocrkQyuArqadL/m9cRAQ5qXVQ1kYI4JJRWuZG3s=; b=Yvn+trQnDMoiak1q39C0Hux8ESBgtEQ8jjnThcLerNZmAZzw4DLiBrK+epCp82wqsJ ZR0LNnDhFlM7P/H6upP+SX2nqZ9uocf0Jo1O12K9tOlqkUgKK7IFNkkkbEQUOwg7o7qh EfCeKFPJNG4YrC17524lFssYpGYP2yT96idBl8hODwRAYuFERZTi8ncGCzZcNcV4VtQv Qw+vPqiMYb8+SRmKIkLamdUlqK2GnJiJxef5vEu6H5emhsjpcu5eAtKcO0MbRMzc9piP InsnuLtZjhAJogtkmO9uAedO8YNe3HTp2AiOIHe8Pssa2l9Ff+u0PkttR3yh06aIlir9 iSSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=kQYOJk5F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 14-20020a17090600ce00b007ae186b15f9si14755602eji.597.2023.01.29.19.57.58; Sun, 29 Jan 2023 19:58:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=kQYOJk5F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=marvell.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235278AbjA3D4g (ORCPT <rfc822;n2h9z4@gmail.com> + 99 others); Sun, 29 Jan 2023 22:56:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232201AbjA3D4f (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 29 Jan 2023 22:56:35 -0500 Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36768196B5; Sun, 29 Jan 2023 19:56:34 -0800 (PST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30U0P3m1011796; Sun, 29 Jan 2023 19:56:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=2BkxocrkQyuArqadL/m9cRAQ5qXVQ1kYI4JJRWuZG3s=; b=kQYOJk5FTlpprD+XlG8xBWVt95+ughimaDF9Xmmhowcd2PfX0bIE9ugdItjdvwhPSUyV 9fLa+4f4mRMOsAnzhRq4fv1Tr0R+gqDIYLTT7gvRDSAo+rwGqHurFajKPRjTHV0dv5h7 wzvrYyMThjroZFdeXHdyO5668H4mKeFRow4PZL9O2wVwjM04KyNrpSSNNviSzRKLWHie zH23OaZK/tatXvkqm/w5lzLWVLXoPMh2lVHLZWHWBIx5hlNcU7kqSnrl75vP7RGZTCR9 oXOcgXDwdy+dV3RoIJtuEQvlD1U9Kp/5E1SPLurYySqLyxEU3JJuE9NbOQxzZdNaxx0f UQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3nd1xum1hd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 29 Jan 2023 19:56:22 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Sun, 29 Jan 2023 19:56:20 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend Transport; Sun, 29 Jan 2023 19:56:20 -0800 Received: from localhost.localdomain (unknown [10.28.36.165]) by maili.marvell.com (Postfix) with ESMTP id 9EA823F70A7; Sun, 29 Jan 2023 19:56:16 -0800 (PST) From: Ratheesh Kannoth <rkannoth@marvell.com> To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com> CC: <sgoutham@marvell.com>, Ratheesh Kannoth <rkannoth@marvell.com> Subject: [net-next PATCH] octeontx2-af: Removed unnecessary debug messages. Date: Mon, 30 Jan 2023 09:25:56 +0530 Message-ID: <20230130035556.694814-1-rkannoth@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: ZlrVuQPv1haZsu45jxG1nMcA2gISeGiz X-Proofpoint-GUID: ZlrVuQPv1haZsu45jxG1nMcA2gISeGiz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-30_01,2023-01-27_01,2022-06-22_01 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756418391728432205?= X-GMAIL-MSGID: =?utf-8?q?1756418391728432205?= |
Series |
[net-next] octeontx2-af: Removed unnecessary debug messages.
|
|
Commit Message
Ratheesh Kannoth
Jan. 30, 2023, 3:55 a.m. UTC
From: Sunil Goutham <sgoutham@marvell.com> NPC exact match feature is supported only on one silicon variant, removed debug messages which print that this feature is not available on all other silicon variants. Signed-off-by: Sunil Goutham <sgoutham@marvell.com> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> --- .../net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
Comments
On Mon, Jan 30, 2023 at 09:25:56AM +0530, Ratheesh Kannoth wrote: > From: Sunil Goutham <sgoutham@marvell.com> > > NPC exact match feature is supported only on one silicon > variant, removed debug messages which print that this > feature is not available on all other silicon variants. > > Signed-off-by: Sunil Goutham <sgoutham@marvell.com> > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> > --- > .../net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > index f69102d20c90..ad1374a12a40 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > @@ -200,10 +200,8 @@ void npc_config_secret_key(struct rvu *rvu, int blkaddr) > struct rvu_hwinfo *hw = rvu->hw; > u8 intf; > > - if (!hwcap->npc_hash_extract) { > - dev_info(rvu->dev, "HW does not support secret key configuration\n"); > + if (!hwcap->npc_hash_extract) > return; > - } > > for (intf = 0; intf < hw->npc_intfs; intf++) { > rvu_write64(rvu, blkaddr, NPC_AF_INTFX_SECRET_KEY0(intf), > @@ -221,10 +219,8 @@ void npc_program_mkex_hash(struct rvu *rvu, int blkaddr) > struct rvu_hwinfo *hw = rvu->hw; > u8 intf; > > - if (!hwcap->npc_hash_extract) { > - dev_dbg(rvu->dev, "Field hash extract feature is not supported\n"); > + if (!hwcap->npc_hash_extract) > return; > - } > > for (intf = 0; intf < hw->npc_intfs; intf++) { > npc_program_mkex_hash_rx(rvu, blkaddr, intf); > @@ -1854,16 +1850,12 @@ int rvu_npc_exact_init(struct rvu *rvu) > /* Check exact match feature is supported */ > npc_const3 = rvu_read64(rvu, blkaddr, NPC_AF_CONST3); > if (!(npc_const3 & BIT_ULL(62))) { > - dev_info(rvu->dev, "%s: No support for exact match support\n", > - __func__); > return 0; > } You should remove () brackets here too. > > /* Check if kex profile has enabled EXACT match nibble */ > cfg = rvu_read64(rvu, blkaddr, NPC_AF_INTFX_KEX_CFG(NIX_INTF_RX)); > if (!(cfg & NPC_EXACT_NIBBLE_HIT)) { > - dev_info(rvu->dev, "%s: NPC exact match nibble not enabled in KEX profile\n", > - __func__); > return 0; > } Same comment. > > -- > 2.25.1 >
---------------------------------------------------------------------- On Mon, Jan 30, 2023 at 09:25:56AM +0530, Ratheesh Kannoth wrote: > From: Sunil Goutham <sgoutham@marvell.com> > > NPC exact match feature is supported only on one silicon variant, > removed debug messages which print that this feature is not available > on all other silicon variants. > > Signed-off-by: Sunil Goutham <sgoutham@marvell.com> > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> > --- > .../net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 12 > ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > index f69102d20c90..ad1374a12a40 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > @@ -200,10 +200,8 @@ void npc_config_secret_key(struct rvu *rvu, int blkaddr) > struct rvu_hwinfo *hw = rvu->hw; > u8 intf; > > - if (!hwcap->npc_hash_extract) { > - dev_info(rvu->dev, "HW does not support secret key configuration\n"); > + if (!hwcap->npc_hash_extract) > return; > - } > > for (intf = 0; intf < hw->npc_intfs; intf++) { > rvu_write64(rvu, blkaddr, NPC_AF_INTFX_SECRET_KEY0(intf), @@ > -221,10 +219,8 @@ void npc_program_mkex_hash(struct rvu *rvu, int blkaddr) > struct rvu_hwinfo *hw = rvu->hw; > u8 intf; > > - if (!hwcap->npc_hash_extract) { > - dev_dbg(rvu->dev, "Field hash extract feature is not supported\n"); > + if (!hwcap->npc_hash_extract) > return; > - } > > for (intf = 0; intf < hw->npc_intfs; intf++) { > npc_program_mkex_hash_rx(rvu, blkaddr, intf); @@ -1854,16 +1850,12 > @@ int rvu_npc_exact_init(struct rvu *rvu) > /* Check exact match feature is supported */ > npc_const3 = rvu_read64(rvu, blkaddr, NPC_AF_CONST3); > if (!(npc_const3 & BIT_ULL(62))) { > - dev_info(rvu->dev, "%s: No support for exact match support\n", > - __func__); > return 0; > } >You should remove () brackets here too. Ratheesh -> Sorry , I did not get you. We have more than one statement in this "if" loop. How can we remove brackets ? > > /* Check if kex profile has enabled EXACT match nibble */ > cfg = rvu_read64(rvu, blkaddr, NPC_AF_INTFX_KEX_CFG(NIX_INTF_RX)); > if (!(cfg & NPC_EXACT_NIBBLE_HIT)) { > - dev_info(rvu->dev, "%s: NPC exact match nibble not enabled in KEX profile\n", > - __func__); > return 0; > } >Same comment. Ratheesh -> same comment. > > -- > 2.25.1 >
On Tue, Jan 31, 2023 at 07:11:10AM +0000, Ratheesh Kannoth wrote: > ---------------------------------------------------------------------- > On Mon, Jan 30, 2023 at 09:25:56AM +0530, Ratheesh Kannoth wrote: > > From: Sunil Goutham <sgoutham@marvell.com> > > > > NPC exact match feature is supported only on one silicon variant, > > removed debug messages which print that this feature is not available > > on all other silicon variants. > > > > Signed-off-by: Sunil Goutham <sgoutham@marvell.com> > > Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com> > > --- > > .../net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c | 12 > > ++---------- > > 1 file changed, 2 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > > index f69102d20c90..ad1374a12a40 100644 > > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c > > @@ -200,10 +200,8 @@ void npc_config_secret_key(struct rvu *rvu, int blkaddr) > > struct rvu_hwinfo *hw = rvu->hw; > > u8 intf; > > > > - if (!hwcap->npc_hash_extract) { > > - dev_info(rvu->dev, "HW does not support secret key configuration\n"); > > + if (!hwcap->npc_hash_extract) > > return; > > - } > > > > for (intf = 0; intf < hw->npc_intfs; intf++) { > > rvu_write64(rvu, blkaddr, NPC_AF_INTFX_SECRET_KEY0(intf), @@ > > -221,10 +219,8 @@ void npc_program_mkex_hash(struct rvu *rvu, int blkaddr) > > struct rvu_hwinfo *hw = rvu->hw; > > u8 intf; > > > > - if (!hwcap->npc_hash_extract) { > > - dev_dbg(rvu->dev, "Field hash extract feature is not supported\n"); > > + if (!hwcap->npc_hash_extract) > > return; > > - } > > > > for (intf = 0; intf < hw->npc_intfs; intf++) { > > npc_program_mkex_hash_rx(rvu, blkaddr, intf); @@ -1854,16 +1850,12 > > @@ int rvu_npc_exact_init(struct rvu *rvu) > > /* Check exact match feature is supported */ > > npc_const3 = rvu_read64(rvu, blkaddr, NPC_AF_CONST3); > > if (!(npc_const3 & BIT_ULL(62))) { > > - dev_info(rvu->dev, "%s: No support for exact match support\n", > > - __func__); > > return 0; > > } > > >You should remove () brackets here too. > Ratheesh -> Sorry , I did not get you. We have more than one statement in this "if" loop. How can we remove brackets ? Please configure your email client to respect reply format. Probably my typo mislead you, you need to remove {} brackets. Before your change if (!(npc_const3 & BIT_ULL(62))) { dev_info(rvu->dev, "%s: No support for exact match support\n", __func__); return 0; } After your change: if (!(npc_const3 & BIT_ULL(62))) { return 0; } Thanks
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c index f69102d20c90..ad1374a12a40 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c @@ -200,10 +200,8 @@ void npc_config_secret_key(struct rvu *rvu, int blkaddr) struct rvu_hwinfo *hw = rvu->hw; u8 intf; - if (!hwcap->npc_hash_extract) { - dev_info(rvu->dev, "HW does not support secret key configuration\n"); + if (!hwcap->npc_hash_extract) return; - } for (intf = 0; intf < hw->npc_intfs; intf++) { rvu_write64(rvu, blkaddr, NPC_AF_INTFX_SECRET_KEY0(intf), @@ -221,10 +219,8 @@ void npc_program_mkex_hash(struct rvu *rvu, int blkaddr) struct rvu_hwinfo *hw = rvu->hw; u8 intf; - if (!hwcap->npc_hash_extract) { - dev_dbg(rvu->dev, "Field hash extract feature is not supported\n"); + if (!hwcap->npc_hash_extract) return; - } for (intf = 0; intf < hw->npc_intfs; intf++) { npc_program_mkex_hash_rx(rvu, blkaddr, intf); @@ -1854,16 +1850,12 @@ int rvu_npc_exact_init(struct rvu *rvu) /* Check exact match feature is supported */ npc_const3 = rvu_read64(rvu, blkaddr, NPC_AF_CONST3); if (!(npc_const3 & BIT_ULL(62))) { - dev_info(rvu->dev, "%s: No support for exact match support\n", - __func__); return 0; } /* Check if kex profile has enabled EXACT match nibble */ cfg = rvu_read64(rvu, blkaddr, NPC_AF_INTFX_KEX_CFG(NIX_INTF_RX)); if (!(cfg & NPC_EXACT_NIBBLE_HIT)) { - dev_info(rvu->dev, "%s: NPC exact match nibble not enabled in KEX profile\n", - __func__); return 0; }