diff mbox series

block: Remove mm.h from bvec.h

Message ID 20230131050132.2627124-1-willy@infradead.org
State New
Headers
Series block: Remove mm.h from bvec.h |

Commit Message

Matthew Wilcox Jan. 31, 2023, 5:01 a.m. UTC 
  This was originally added for the definition of nth_page(), but we no
longer use nth_page() in this header, so we can drop the heavyweight
mm.h now.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 include/linux/bvec.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Christoph Hellwig Jan. 31, 2023, 9 a.m. UTC | #1 
On Tue, Jan 31, 2023 at 05:01:32AM +0000, Matthew Wilcox (Oracle) wrote:
> This was originally added for the definition of nth_page(), but we no
> longer use nth_page() in this header, so we can drop the heavyweight
> mm.h now.

I'm for this, but I'd really prefer to have this survive the build bot
for a few days and random builds as there could be users that are
missing the explicit include by now.  And someone the buildbot seems
down or overloaded lately :(
Jens Axboe Jan. 31, 2023, 6:02 p.m. UTC | #2 
On Tue, 31 Jan 2023 05:01:32 +0000, Matthew Wilcox (Oracle) wrote:
> This was originally added for the definition of nth_page(), but we no
> longer use nth_page() in this header, so we can drop the heavyweight
> mm.h now.
> 
> 

Applied, thanks!

[1/1] block: Remove mm.h from bvec.h
      commit: 2d97930d74b12467fd5f48d8560e48c1cf5edcb1

Best regards,
diff mbox series

Patch

diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index 35c25dff651a..7939b345ee7f 100644
--- a/include/linux/bvec.h
+++ b/include/linux/bvec.h
@@ -12,7 +12,6 @@ 
 #include <linux/errno.h>
 #include <linux/limits.h>
 #include <linux/minmax.h>
-#include <linux/mm.h>
 #include <linux/types.h>
 
 struct page;