Message ID | 20230127145708.12915-1-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp881486wrn; Fri, 27 Jan 2023 07:06:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXsoOQmYGMIwTzUaw9WYzfh0WXEOOAmOvCLO8bfBMbGjjreWWj/Ccd51fsTWy8G60Cm8DgSq X-Received: by 2002:a17:907:6e05:b0:871:dd2:4afb with SMTP id sd5-20020a1709076e0500b008710dd24afbmr58713712ejc.42.1674831979620; Fri, 27 Jan 2023 07:06:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674831979; cv=none; d=google.com; s=arc-20160816; b=QpDhItw0wUSnLwfuLAb0SF+k+ykAITkhmR4jsu+7lDao2+jh5UcMmGsWbmciOfkkEy R9ZE6TR2cTmOt9iTYv8jYHb2Ier0731iPovex6athVwrsWl/EBUovHNQaTnuYN3DRTGN L28deK634+zFUYuE9TEOD+pvvF+GLzgUit8uAuuRsEnDoWXtSRLzl6KjGpynIKRv/N20 lfgK0TwDym2Equ7X6OuiSwzKtodq/ykjAnDeX5KX22mNV9PpZVJFLXEZImrbMunI1Tp3 UKFqMbvA9JMYrYYW/Fkq679IKV7nK7wIj+yZqMgtBhSSAoFIxMgiElFluPVIsfADvUHn W4wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IxIhTEnlTJLVr1/vkT19DQmweyWClpe//vYzs41t4Yo=; b=Jw5ZCGEB71rmEqQaTocMTY+iD34VwTxGR3gqNKAHdoliwZQo/w3PbW1q03HS/J1UX4 QDHqP7ra5mb3lYud5r+tRarBHTRlC4aFxg+b7zuftPt0mg/9CqjtPrdVTa1Jz0i3ydJ6 /DtOYXeQ5ldMMQUQXPbgACwz6zG9yVvgFA4pIO8mWZTByLGO+8RGixalZ6QQdvE2sN8s XokmKN1a6LUkrS7ucY1PvVCv/LPg+1iqrpjLdesvW+i5dpclTOZfDFNZ/MWAj3jR3RiB Y1rNn2r1pVWH+j1x19/dH6uap9MQqUa8vk1f1UanWHxG7wsvlSOw3+nhk7gbxgK6fqSI vlvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=llyz1y5B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a056402128800b0049822232df5si5667956edv.526.2023.01.27.07.05.52; Fri, 27 Jan 2023 07:06:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=llyz1y5B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234067AbjA0O4o (ORCPT <rfc822;lekhanya01809@gmail.com> + 99 others); Fri, 27 Jan 2023 09:56:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbjA0O4m (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 27 Jan 2023 09:56:42 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B5E43BD95; Fri, 27 Jan 2023 06:56:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674831402; x=1706367402; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nqGsro9x3Ly10ZkoIRHvC0P7jMS0S/jmWDsPx3WjnAQ=; b=llyz1y5BinRmqBqQQA2f6MLHmVSBl7d57sXFa2e7OyHfjVIfDsrzVlNa VV3+K0A4C6poRkGl0G7rmf3eCH4lldyJbiKbm1MFuN1pU+HYWIsNAFafE oxFvMh6Brjc0q8D7ky5hzJd40bz6nqkcgZC+lb+Rd5YphPnbcklwkA2ri pNb/CUAWoNr5O7Og0otiJPPotbUsBPMXexWL9wzlVfv35Sbbn+7cMH5gX s5rUrppDt5JvHCY0mVRselsmvWCDvDX12HcPIz2KUgyJYArnlmJZ8pFpo gCJjWeRqrGwMsY0Gzg54HONDuQxJUuqJEYZkLC7kKq3MHD+iaSxG5e8Lh A==; X-IronPort-AV: E=McAfee;i="6500,9779,10603"; a="307444799" X-IronPort-AV: E=Sophos;i="5.97,251,1669104000"; d="scan'208";a="307444799" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2023 06:56:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10603"; a="663288299" X-IronPort-AV: E=Sophos;i="5.97,251,1669104000"; d="scan'208";a="663288299" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 27 Jan 2023 06:56:37 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id CE5BC1A5; Fri, 27 Jan 2023 16:57:13 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Brendan Higgins <brendanhiggins@google.com>, David Gow <davidgow@google.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Subject: [PATCH v1 1/1] .gitignore: Unignore .kunitconfig Date: Fri, 27 Jan 2023 16:57:08 +0200 Message-Id: <20230127145708.12915-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756188618110268761?= X-GMAIL-MSGID: =?utf-8?q?1756188618110268761?= |
Series |
[v1,1/1] .gitignore: Unignore .kunitconfig
|
|
Commit Message
Andy Shevchenko
Jan. 27, 2023, 2:57 p.m. UTC
There are almost dozen of .kunitconfig files that are ignored but
tracked. Unignore them.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, 27 Jan 2023 at 22:56, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > There are almost dozen of .kunitconfig files that are ignored but > tracked. Unignore them. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- Thanks! Only the original root-directory .kunitignore file was intended to be ignored, and that's no longer as important, and is now in the build dir anyway. Reviewed-by: David Gow <davidgow@google.com> Cheers, -- David > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 22984d22d29e..e4f2ba0be516 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -100,6 +100,7 @@ modules.order > !.get_maintainer.ignore > !.gitattributes > !.gitignore > +!.kunitconfig > !.mailmap > !.rustfmt.toml > > -- > 2.39.0 >
On Sat, Jan 28, 2023 at 3:56 PM David Gow <davidgow@google.com> wrote: > > On Fri, 27 Jan 2023 at 22:56, Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > There are almost dozen of .kunitconfig files that are ignored but > > tracked. Unignore them. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > Thanks! Only the original root-directory .kunitignore file was > intended to be ignored, and that's no longer as important, and is now > in the build dir anyway. > > Reviewed-by: David Gow <davidgow@google.com> > > Cheers, > -- David > > > .gitignore | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/.gitignore b/.gitignore > > index 22984d22d29e..e4f2ba0be516 100644 > > --- a/.gitignore > > +++ b/.gitignore > > @@ -100,6 +100,7 @@ modules.order > > !.get_maintainer.ignore > > !.gitattributes > > !.gitignore > > +!.kunitconfig > > !.mailmap > > !.rustfmt.toml > > > > -- > > 2.39.0 > > Why is this a dot file in the first place?
On Sat, 28 Jan 2023 at 22:37, Masahiro Yamada <masahiroy@kernel.org> wrote: > > On Sat, Jan 28, 2023 at 3:56 PM David Gow <davidgow@google.com> wrote: > > > > On Fri, 27 Jan 2023 at 22:56, Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > There are almost dozen of .kunitconfig files that are ignored but > > > tracked. Unignore them. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > --- > > > > Thanks! Only the original root-directory .kunitignore file was > > intended to be ignored, and that's no longer as important, and is now > > in the build dir anyway. > > > > Reviewed-by: David Gow <davidgow@google.com> > > > > Cheers, > > -- David > > > > > .gitignore | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/.gitignore b/.gitignore > > > index 22984d22d29e..e4f2ba0be516 100644 > > > --- a/.gitignore > > > +++ b/.gitignore > > > @@ -100,6 +100,7 @@ modules.order > > > !.get_maintainer.ignore > > > !.gitattributes > > > !.gitignore > > > +!.kunitconfig > > > !.mailmap > > > !.rustfmt.toml > > > > > > -- > > > 2.39.0 > > > > > > Why is this a dot file in the first place? > In short, historical reasons. The long answer is that there are two places "kunitconfig" files are used: as a user-provided file with their preferred test config (which is kept local), and as a recommended test config for a given subsystem (which is checked in). Originally, no .kunitconfig files were checked in: one was either autogenerated or manually modified and left in the root source directory. This eventually moved into the build directory, and a number of features which de-emphasized it in favour of command-line arguments and the (new) checked-in per-subsystem configs, which probably shouldn't be hidden. There's no fundamental reason (other than it being a bit annoying to rename everything and update the code) we can't change it, either for all kunitconfig files, or just the checked-in ones, if that's preferred. -- David
On Tue, Jan 31, 2023 at 9:01 AM David Gow <davidgow@google.com> wrote: > > On Sat, 28 Jan 2023 at 22:37, Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > On Sat, Jan 28, 2023 at 3:56 PM David Gow <davidgow@google.com> wrote: > > > > > > On Fri, 27 Jan 2023 at 22:56, Andy Shevchenko > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > > > There are almost dozen of .kunitconfig files that are ignored but > > > > tracked. Unignore them. > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > --- > > > > > > Thanks! Only the original root-directory .kunitignore file was > > > intended to be ignored, and that's no longer as important, and is now > > > in the build dir anyway. > > > > > > Reviewed-by: David Gow <davidgow@google.com> > > > > > > Cheers, > > > -- David > > > > > > > .gitignore | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/.gitignore b/.gitignore > > > > index 22984d22d29e..e4f2ba0be516 100644 > > > > --- a/.gitignore > > > > +++ b/.gitignore > > > > @@ -100,6 +100,7 @@ modules.order > > > > !.get_maintainer.ignore > > > > !.gitattributes > > > > !.gitignore > > > > +!.kunitconfig > > > > !.mailmap > > > > !.rustfmt.toml > > > > > > > > -- > > > > 2.39.0 > > > > > > > > > > Why is this a dot file in the first place? > > > > In short, historical reasons. > > The long answer is that there are two places "kunitconfig" files are > used: as a user-provided file with their preferred test config (which > is kept local), and as a recommended test config for a given subsystem > (which is checked in). > Originally, no .kunitconfig files were checked in: one was either > autogenerated or manually modified and left in the root source > directory. This eventually moved into the build directory, and a > number of features which de-emphasized it in favour of command-line > arguments and the (new) checked-in per-subsystem configs, which > probably shouldn't be hidden. Do you mean there are two types for .kunitconfig - auto-generated ones and check-in ones? If this patch is applied, is there a possibility where auto-generated .kunitconfig files would be accidentally added to the repository? > There's no fundamental reason (other than it being a bit annoying to > rename everything and update the code) we can't change it, either for > all kunitconfig files, or just the checked-in ones, if that's > preferred. > > -- David
On Tue, 31 Jan 2023 at 10:11, Masahiro Yamada <masahiroy@kernel.org> wrote: > > On Tue, Jan 31, 2023 at 9:01 AM David Gow <davidgow@google.com> wrote: > > > > On Sat, 28 Jan 2023 at 22:37, Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > > > On Sat, Jan 28, 2023 at 3:56 PM David Gow <davidgow@google.com> wrote: > > > > > > > > On Fri, 27 Jan 2023 at 22:56, Andy Shevchenko > > > > <andriy.shevchenko@linux.intel.com> wrote: > > > > > > > > > > There are almost dozen of .kunitconfig files that are ignored but > > > > > tracked. Unignore them. > > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > --- > > > > > > > > Thanks! Only the original root-directory .kunitignore file was > > > > intended to be ignored, and that's no longer as important, and is now > > > > in the build dir anyway. > > > > > > > > Reviewed-by: David Gow <davidgow@google.com> > > > > > > > > Cheers, > > > > -- David > > > > > > > > > .gitignore | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/.gitignore b/.gitignore > > > > > index 22984d22d29e..e4f2ba0be516 100644 > > > > > --- a/.gitignore > > > > > +++ b/.gitignore > > > > > @@ -100,6 +100,7 @@ modules.order > > > > > !.get_maintainer.ignore > > > > > !.gitattributes > > > > > !.gitignore > > > > > +!.kunitconfig > > > > > !.mailmap > > > > > !.rustfmt.toml > > > > > > > > > > -- > > > > > 2.39.0 > > > > > > > > > > > > > > Why is this a dot file in the first place? > > > > > > > In short, historical reasons. > > > > The long answer is that there are two places "kunitconfig" files are > > used: as a user-provided file with their preferred test config (which > > is kept local), and as a recommended test config for a given subsystem > > (which is checked in). > > Originally, no .kunitconfig files were checked in: one was either > > autogenerated or manually modified and left in the root source > > directory. This eventually moved into the build directory, and a > > number of features which de-emphasized it in favour of command-line > > arguments and the (new) checked-in per-subsystem configs, which > > probably shouldn't be hidden. > > > Do you mean there are two types for .kunitconfig - auto-generated ones > and check-in ones? > > If this patch is applied, is there a possibility where > auto-generated .kunitconfig files would be accidentally > added to the repository? > > I wouldn't think so -- the auto-generated ones live in the build directory (which is itself '.kunit' by default). You'd have to go out of your way to do an in-tree build, and then add generated files. -- David
On Fri, Jan 27, 2023 at 04:57:08PM +0200, Andy Shevchenko wrote: > There are almost dozen of .kunitconfig files that are ignored but > tracked. Unignore them. It's still an issue, can we apply this patch or can somebody to propose the better sooner than later, please?
On Fri, 10 Mar 2023 at 23:31, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Fri, Jan 27, 2023 at 04:57:08PM +0200, Andy Shevchenko wrote: > > There are almost dozen of .kunitconfig files that are ignored but > > tracked. Unignore them. > > It's still an issue, can we apply this patch or can somebody to propose > the better sooner than later, please? > Agreed. Masahiro, Shuah: who wants to pick this up? I'm happy either way. Cheers, -- David
diff --git a/.gitignore b/.gitignore index 22984d22d29e..e4f2ba0be516 100644 --- a/.gitignore +++ b/.gitignore @@ -100,6 +100,7 @@ modules.order !.get_maintainer.ignore !.gitattributes !.gitignore +!.kunitconfig !.mailmap !.rustfmt.toml