diff mbox series

[22/24] RISC-V: ACPI: Enable ACPI in defconfig

Message ID	20230130182225.2471414-23-sunilvl@ventanamicro.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Sunil V L <sunilvl@ventanamicro.com> To: Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, "Rafael J . Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Jonathan Corbet <corbet@lwn.net> Cc: linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Anup Patel <apatel@ventanamicro.com>, Andrew Jones <ajones@ventanamicro.com>, Atish Patra <atishp@rivosinc.com>, Sunil V L <sunilvl@ventanamicro.com> Subject: [PATCH 22/24] RISC-V: ACPI: Enable ACPI in defconfig Date: Mon, 30 Jan 2023 23:52:23 +0530 Message-Id: <20230130182225.2471414-23-sunilvl@ventanamicro.com> In-Reply-To: <20230130182225.2471414-1-sunilvl@ventanamicro.com> References: <20230130182225.2471414-1-sunilvl@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Add basic ACPI support for RISC-V \| [00/24] Add basic ACPI support for RISC-V [01/24] riscv: move sbi_init() earlier before jump_label_init() [02/24] ACPICA: MADT: Add RISC-V INTC interrupt controller [03/24] ACPICA: Add structure definitions for RISC-V RHCT [04/24] RISC-V: ACPI: Add empty headers to enable ACPI core [05/24] RISC-V: ACPI: Add basic functions to build ACPI core [06/24] RISC-V: ACPI: Add PCI functions to build ACPI core [07/24] RISC-V: ACPI: Enable ACPI build infrastructure [08/24] ACPI: Enable ACPI_PROCESSOR for RISC-V [09/24] ACPI: OSL: Make should_use_kmap() 0 for RISC-V. [10/24] ACPI: processor_core: RISC-V: Enable mapping processor to the hartid [11/24] RISC-V: ACPI: irqchip/riscv-intc: Add ACPI support [12/24] RISC-V: ACPI: smpboot: Create wrapper smp_setup() [13/24] RISC-V: ACPI: smpboot: Add ACPI support in smp_setup() [14/24] RISC-V: ACPI: smpboot: Add function to retrieve the hartid [15/24] clocksource/timer-riscv: Refactor riscv_timer_init_dt() [16/24] RISC-V: ACPI: clocksource/timer-riscv: Add ACPI support [17/24] ACPI: RISC-V: drivers/acpi: Add RHCT related code [18/24] RISC-V: ACPI: time.c: Add ACPI support for time_init() [19/24] RISC-V: ACPI: cpufeature: Add ACPI support in riscv_fill_hwcap() [20/24] RISC-V: ACPI: cpu: Enable cpuinfo for ACPI systems [21/24] RISC-V: ACPI: Add ACPI initialization in setup_arch() [22/24] RISC-V: ACPI: Enable ACPI in defconfig [23/24] MAINTAINERS: Add entry for drivers/acpi/riscv [24/24] Documentation/kernel-parameters.txt: Add RISC-V for ACPI parameter

Commit Message

Sunil V L Jan. 30, 2023, 6:22 p.m. UTC

  Add support to build ACPI subsystem in defconfig.

Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
---
 arch/riscv/configs/defconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Conor Dooley Jan. 30, 2023, 11:47 p.m. UTC | #1

Hey Sunil,

Two quick comments while I think of them..

On Mon, Jan 30, 2023 at 11:52:23PM +0530, Sunil V L wrote:
> RISC-V: ACPI: Enable ACPI in defconfig

btw, about half of this series redundantly puts "ACPI:" or "RISC-V:
ACPI:" into $subject. None of commits that mention ACPI after the last :
should mention ACPI in the prefix IMO, it's just noise.

For example, this one should be something like:
RISC-V: enable ACPI in defconfig

> Add support to build ACPI subsystem in defconfig.
> 
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> ---
>  arch/riscv/configs/defconfig | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index 128dcf4c0814..8ce06fb0dde8 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -218,3 +218,7 @@ CONFIG_RCU_EQS_DEBUG=y
>  # CONFIG_FTRACE is not set
>  # CONFIG_RUNTIME_TESTING_MENU is not set
>  CONFIG_MEMTEST=y
> +CONFIG_ARCH_SUPPORTS_ACPI=y

This needs to go into the arch Kconfig file, where it will be selected.
Check what arm64 does if you are not sure what I mean.

Hopefully I'll get a chance to look at the rest of this this week
sometime,
Conor.

Sunil V L Jan. 31, 2023, 8:41 a.m. UTC | #2

Hi Conor,
On Mon, Jan 30, 2023 at 11:47:35PM +0000, Conor Dooley wrote:
> Hey Sunil,
> 
> Two quick comments while I think of them..
> 

Sure. Thank you!

> On Mon, Jan 30, 2023 at 11:52:23PM +0530, Sunil V L wrote:
> > RISC-V: ACPI: Enable ACPI in defconfig
> 
> btw, about half of this series redundantly puts "ACPI:" or "RISC-V:
> ACPI:" into $subject. None of commits that mention ACPI after the last :
> should mention ACPI in the prefix IMO, it's just noise.
> 
> For example, this one should be something like:
> RISC-V: enable ACPI in defconfig
> 

I agree. Will update in the next version. I added ACPI in begining so that
I could quickly identify them along with other patches in my branch.

> > Add support to build ACPI subsystem in defconfig.
> > 
> > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> > ---
> >  arch/riscv/configs/defconfig | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> > index 128dcf4c0814..8ce06fb0dde8 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -218,3 +218,7 @@ CONFIG_RCU_EQS_DEBUG=y
> >  # CONFIG_FTRACE is not set
> >  # CONFIG_RUNTIME_TESTING_MENU is not set
> >  CONFIG_MEMTEST=y
> > +CONFIG_ARCH_SUPPORTS_ACPI=y
> 
> This needs to go into the arch Kconfig file, where it will be selected.
> Check what arm64 does if you are not sure what I mean.
> 

Yes, I have added in "[PATCH 07/24] RISC-V: ACPI: Enable ACPI build
infrastructure". But forgot to remove here. Thanks!. Will update it when
I send next revision.

> Hopefully I'll get a chance to look at the rest of this this week
> sometime,
> Conor.
> 

Thanks!
Sunil

diff mbox series

Patch

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index 128dcf4c0814..8ce06fb0dde8 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -218,3 +218,7 @@  CONFIG_RCU_EQS_DEBUG=y
 # CONFIG_FTRACE is not set
 # CONFIG_RUNTIME_TESTING_MENU is not set
 CONFIG_MEMTEST=y
+CONFIG_ARCH_SUPPORTS_ACPI=y
+CONFIG_ACPI=y
+CONFIG_ACPI_MCFG=y
+# CONFIG_PCI_QUIRKS is not set