Message ID | 20230109034734.491518-1-chao@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp1961378wrt; Sun, 8 Jan 2023 19:50:05 -0800 (PST) X-Google-Smtp-Source: AMrXdXvY9BTwNCwQsPxP2dV0rD0khmdDj5oDjUEgCIlnn4YZ480LADTVQKq5ypVsu2lkyk0R16v/ X-Received: by 2002:a05:6402:5167:b0:497:1b2:5f88 with SMTP id d7-20020a056402516700b0049701b25f88mr8836340ede.16.1673236204926; Sun, 08 Jan 2023 19:50:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673236204; cv=none; d=google.com; s=arc-20160816; b=LVHoUmU+5sJ/jxWcd43yEAWCJsOvgFe54SNaEeXeqUgq9WV6C2tybkoNOXKms3pfK9 IAwble3peVwj5U6ik9scn9nAeGf1xqx+4qbbtVg2LcfaNGZZt74gbyOY1ur7qwsdb/eN qlUIFzOBJcckKgUed2yGVp56iUZj6GhsV6yGSKtov7i3/QexUfpRxivDe5ffZmiewClo g2Fq++wiITAeL16ayikpAoFOJDDTqCqa0eYrAjXqcQ4ZWVrx3fpo/d0Sj8gZlitLHNtI yYTLNMyUKDDYJLOR7Ov88XQJDVmWW3k9fhbucPKvCVTMSwtIKQLCpRO6br008ltK3IEu IuZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=K2r7sas/9J1FBVf3GFl8ES5/XBH/KZQvSHm//SRNSRY=; b=jGC2K1cpKUL4UN/9EqlgEZJpWIky3gpRwUR9fc9OBkB8PXDus616MsxTwd4PEXastB zZ1f0MKHI0YUKt23kpbu3De8LxSMUJMOic982NAUBTUrYvuRdPsRLCpKsZe8vy/+HJeK knnC5kRGhjcB7PDYr/m4IC0M0o1NvA/M3AMSlYN3VwMJRq89ihC9pf9j2zKDOxG0hPhU B3TkQHv91XBb5RED8zb9Nj603EvKL/erBgq8u6gJX0McGkBdr2muWF1uVrFpwtbQS1Pv qcjkB+H929iHTSmvRUDrD+egSAomfUR7JmfPPMqDfbiJ6sAMrzh8LoyY9yoJsjM/MLDP yf1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J+WioKvU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l7-20020a056402254700b0045ad02bb8fbsi9359342edb.290.2023.01.08.19.49.42; Sun, 08 Jan 2023 19:50:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J+WioKvU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234160AbjAIDrz (ORCPT <rfc822;jian.xie.xdx@gmail.com> + 99 others); Sun, 8 Jan 2023 22:47:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231225AbjAIDru (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 8 Jan 2023 22:47:50 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A6A6247 for <linux-kernel@vger.kernel.org>; Sun, 8 Jan 2023 19:47:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E9D58B80C7B for <linux-kernel@vger.kernel.org>; Mon, 9 Jan 2023 03:47:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 609E8C433D2; Mon, 9 Jan 2023 03:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673236066; bh=bVMllKVymzErfe1oVh1phFGGebLRoiDWdp3ZzO703Ts=; h=From:To:Cc:Subject:Date:From; b=J+WioKvUkcckgC2UD76uzWAjNEy9n/kAIXOBWoCOd3NS2G7/WWequuKcAo5Dqo7K/ Opy/2V8Ajrn9dM1Jg22faM2CaHAY0UaIWKOQR8wn38wuuYoQnDmL6qieaXgPNPSgJi /tSxlZ1n/u9FdPSK/VUxwD4SFYk7SDXvbxSyF9Oc1MiiY3MoEpkMpGsTPgrL1uko2B FLi0fQ1nQDTgAo9RpyCokD/jt8TrWH+qhmAouTJZli0fTMgsj2yuMXxMCDlXUeA0KD 3+NYa4NkrKd8nJM9PJxUTpndWjXOw6Gnl+X9So6Ruh7KAEjZIHvS9WCZkfbn8YTp61 DGk53B1hbGBaA== From: Chao Yu <chao@kernel.org> To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu <chao@kernel.org> Subject: [PATCH] f2fs: remove unneeded f2fs_cp_error() in f2fs_create_whiteout() Date: Mon, 9 Jan 2023 11:47:34 +0800 Message-Id: <20230109034734.491518-1-chao@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754515326859029033?= X-GMAIL-MSGID: =?utf-8?q?1754515326859029033?= |
Series |
f2fs: remove unneeded f2fs_cp_error() in f2fs_create_whiteout()
|
|
Commit Message
Chao Yu
Jan. 9, 2023, 3:47 a.m. UTC
f2fs_rename() has checked CP_ERROR_FLAG, so remove redundant check
in f2fs_create_whiteout().
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/namei.c | 3 ---
1 file changed, 3 deletions(-)
Comments
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Mon, 9 Jan 2023 11:47:34 +0800 you wrote: > f2fs_rename() has checked CP_ERROR_FLAG, so remove redundant check > in f2fs_create_whiteout(). > > Signed-off-by: Chao Yu <chao@kernel.org> > --- > fs/f2fs/namei.c | 3 --- > 1 file changed, 3 deletions(-) Here is the summary with links: - [f2fs-dev] f2fs: remove unneeded f2fs_cp_error() in f2fs_create_whiteout() https://git.kernel.org/jaegeuk/f2fs/c/8abe4be45132 You are awesome, thank you!
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 6032589099ce..82923273f4bb 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -926,9 +926,6 @@ static int f2fs_tmpfile(struct user_namespace *mnt_userns, struct inode *dir, static int f2fs_create_whiteout(struct user_namespace *mnt_userns, struct inode *dir, struct inode **whiteout) { - if (unlikely(f2fs_cp_error(F2FS_I_SB(dir)))) - return -EIO; - return __f2fs_tmpfile(mnt_userns, dir, NULL, S_IFCHR | WHITEOUT_MODE, true, whiteout); }