[COMMITTED] testsuite: Restore TORTURE_OPTIONS in gm2/warnings/returntype/fail/warnings-returntype-fail.exp
Message ID | yddo7qgqhno.fsf@CeBiTec.Uni-Bielefeld.DE |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2176290wrn; Mon, 30 Jan 2023 05:25:16 -0800 (PST) X-Google-Smtp-Source: AK7set8owdSibnXwoQx6dEZkPvVN//QWRpeT+EpAxYjByarpSyN/JZL3g+6YIAFUNjl/dV6Pa+O9 X-Received: by 2002:a17:906:6808:b0:878:6da5:bf75 with SMTP id k8-20020a170906680800b008786da5bf75mr15226712ejr.35.1675085115973; Mon, 30 Jan 2023 05:25:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675085115; cv=none; d=google.com; s=arc-20160816; b=c4gx1lTWFB9FSwaCmSAdhunZlihpaVhY35j9FTlWtbvyGpP7rLY+HEjAPNWdc5Q0Xl iO440jzccME3NY/beGXFpitc2/iSz51Kb+YzLgSDj6JrLTe3lqxe/Ap+gEjMmdoYlAYE 1NTJqoZHT+ljD2ZhfqhArdcvX7+E7i6tKcauQCUzIofKSruGk2xZdR7OHNRxfxNiu2Cn ni1OLJToLcrMI9uQwt7igXZ4a4IzgXu5cxeL4ZjcMD38rUB5Zr66ygCxqpCwXnenCFcN wYEtdNYZuAW5T1/R8KRYQXj3vd9++rcDS3v3sIYkV9hwjnVnE0V0E4YdGoc5+xCB/pYK 5F2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :message-id:date:subject:cc:to:from:dkim-signature:dmarc-filter :delivered-to; bh=8Gjl6A7leJvwo5FJPR/qK1E88BxqxNLH0GB4MOvKsss=; b=wJJW2w3+Bucchk1KW1FdF8qwKadr75nvslyWCXmBryYaVFLq2gnyO6/ZSLkQ/4X8hc f9SZvCrcXKq/ySsrdYRu7kQjlOQsmURDPObITTBHrafhieY/VKReXNXwe8RIHQkn+WV5 J73UzkQ6VAjB0fcxZf3F/zrm8/r7k1pyWLz1V5K82SGMWIWItX7JJRb2s3dklbCtO92U wMc9x6nHFNlyCZclOrV4jaQjDrWhlXiH92ICpi2lc06v+LErts61q1BB1eK97n81Ii0Z rydCfQnKr0xRWomy4rXkBMuStAG6dcVP1PuqSL/cZ1Svipe2cXtQxhsH+yLJ6gMvFg48 j7pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@CeBiTec.Uni-Bielefeld.DE header.s=20200306 header.b=mW+q8+dQ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id cp18-20020a17090793d200b00878742fba64si14746989ejc.68.2023.01.30.05.25.15 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 05:25:15 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@CeBiTec.Uni-Bielefeld.DE header.s=20200306 header.b=mW+q8+dQ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 518D83858418 for <ouuuleilei@gmail.com>; Mon, 30 Jan 2023 13:25:09 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id DB0DF3858CDB for <gcc-patches@gcc.gnu.org>; Mon, 30 Jan 2023 13:24:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB0DF3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=none smtp.mailfrom=cebitec.uni-bielefeld.de Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 6A8FD14FE1; Mon, 30 Jan 2023 14:24:44 +0100 (CET) X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HGCzTJzLXlXU; Mon, 30 Jan 2023 14:24:44 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p508548b7.dip0.t-ipconnect.de [80.133.72.183]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id E667914F67; Mon, 30 Jan 2023 14:24:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1675085084; bh=A+85FkIPaz/aPkNU7qLtrPAa0FS7O4D76UksTWJOw1A=; h=From:To:Cc:Subject:Date:From; b=mW+q8+dQK+TGGRJHe09gx+IzSysg6rldvkdEFSFEWW6dWuIdVg3LRFItKouxmiY09 cXFfndubJfzVrpkptfJgPPIny8B/z+3wXud9mVqUCoPxXAE9OsGk/ZwU6LqoQ4UrH3 oUuoa42xnzJqY3Ql/vHx1O90TbijlRFsFqkXUfevKwG9qYwo2Swzek6/7biFWc80l2 7urr3iLLbxx+joaRC+/7XGz02wWsaxBj9TN/hXD0tFm0RDJWaaB1QNXcuHDcK5jZNs k/u4emwPF8vAamC+1zS6wU3slTS/zKnS/XXHUq0ncl+M1D57xS+mez8bi0Egp7hx3b TbhnzHIQo3S/A== From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> To: gcc-patches@gcc.gnu.org Cc: Gaius Mulley <gaiusmod2@gmail.com> Subject: [COMMITTED] testsuite: Restore TORTURE_OPTIONS in gm2/warnings/returntype/fail/warnings-returntype-fail.exp Date: Mon, 30 Jan 2023 14:24:43 +0100 Message-ID: <yddo7qgqhno.fsf@CeBiTec.Uni-Bielefeld.DE> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Status: No, score=-3794.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756454050915088072?= X-GMAIL-MSGID: =?utf-8?q?1756454050915088072?= |
Series |
[COMMITTED] testsuite: Restore TORTURE_OPTIONS in gm2/warnings/returntype/fail/warnings-returntype-fail.exp
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Rainer Orth
Jan. 30, 2023, 1:24 p.m. UTC
Between 20230126 and 20230127, 1100+ gm2 tests started to FAIL for the non-default multilib, e.g. FAIL: gm2/calling-c/datatypes/unbounded/run/pass/m.mod compilation, {additional_flags= -O0 -g -Werror=return-type } timeout=10 UNRESOLVED: gm2/calling-c/datatypes/unbounded/run/pass/m.mod execution, {additional_flags= -O0 -g -Werror=return-type } timeout=10 FAIL: gm2/case/pass/testcase1.mod, -O0 -g -Werror=return-type [...] cc1gm2: warning: '-Werror=' argument '-Werror=return-type' is not valid for Modula-2 I'm seeing this on all of Solaris/x86, Solaris/SPARC, and Linux/x86_64. I could trace this to gm2/warnings/returntype/fail/warnings-returntype-fail.exp not properly restoring TORTURE_OPTIONS. Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11. Installed on trunk. Rainer
Comments
Hi! On 2023-01-30T14:24:43+0100, Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> wrote: > Between 20230126 and 20230127, 1100+ gm2 tests started to FAIL for the > non-default multilib, e.g. > > FAIL: gm2/calling-c/datatypes/unbounded/run/pass/m.mod compilation, {additional_flags= -O0 -g -Werror=return-type } timeout=10 > UNRESOLVED: gm2/calling-c/datatypes/unbounded/run/pass/m.mod execution, {additional_flags= -O0 -g -Werror=return-type } timeout=10 > FAIL: gm2/case/pass/testcase1.mod, -O0 -g -Werror=return-type > [...] > cc1gm2: warning: '-Werror=' argument '-Werror=return-type' is not valid for Modula-2 > > I'm seeing this on all of Solaris/x86, Solaris/SPARC, and Linux/x86_64. ACK. > I could trace this to > gm2/warnings/returntype/fail/warnings-returntype-fail.exp not properly > restoring TORTURE_OPTIONS. > > Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11. Installed on > trunk. ACK, thanks. And note that this is independent of (or: complements) Iain's commit r13-5473-gfe4608efc15b881ac908a3f90d7322736495ae72 "Modula-2: Claim Wreturn-type in lang.opt", <https://inbox.sourceware.org/gcc-patches/20230128132353.77631-1-iain@sandoe.co.uk>, which remains necessary for: 'gm2/warnings/returntype/pass/Termbase.mod', 'gm2/warnings/returntype/pass/goodreturn.mod', 'gm2/warnings/returntype/pass/keypressedsimple.mod'. Grüße Thomas > 2023-01-30 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> > > gcc/testsuite: > * gm2/warnings/returntype/fail/warnings-returntype-fail.exp: Save, > restore TORTURE_OPTIONS. > > diff --git a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp > --- a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp > +++ b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp > @@ -28,6 +28,8 @@ load_lib gm2-torture.exp > gm2_init_pim "${srcdir}/gm2/warnings/returntype/fail" > > global TORTURE_OPTIONS > + > +set old_options $TORTURE_OPTIONS > set TORTURE_OPTIONS { { -O0 -g -Werror=return-type } } > > foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.mod]] { > @@ -38,3 +40,5 @@ foreach testcase [lsort [glob -nocomplai > > gm2-torture-fail $testcase > } > + > +set TORTURE_OPTIONS $old_options ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
Hi Thomas, > And note that this is independent of (or: complements) Iain's > commit r13-5473-gfe4608efc15b881ac908a3f90d7322736495ae72 > "Modula-2: Claim Wreturn-type in lang.opt", > <https://inbox.sourceware.org/gcc-patches/20230128132353.77631-1-iain@sandoe.co.uk>, > which remains necessary for: > 'gm2/warnings/returntype/pass/Termbase.mod', > 'gm2/warnings/returntype/pass/goodreturn.mod', > 'gm2/warnings/returntype/pass/keypressedsimple.mod'. indeed: those failures happened for the default multilib, while the ones I observed affect the non-default ones. Rainer
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes: > Between 20230126 and 20230127, 1100+ gm2 tests started to FAIL for the > non-default multilib, e.g. > > FAIL: gm2/calling-c/datatypes/unbounded/run/pass/m.mod compilation, {additional_flags= -O0 -g -Werror=return-type } timeout=10 > UNRESOLVED: gm2/calling-c/datatypes/unbounded/run/pass/m.mod execution, {additional_flags= -O0 -g -Werror=return-type } timeout=10 > FAIL: gm2/case/pass/testcase1.mod, -O0 -g -Werror=return-type > [...] > cc1gm2: warning: '-Werror=' argument '-Werror=return-type' is not valid for Modula-2 > > I'm seeing this on all of Solaris/x86, Solaris/SPARC, and Linux/x86_64. > > I could trace this to > gm2/warnings/returntype/fail/warnings-returntype-fail.exp not properly > restoring TORTURE_OPTIONS. > > Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11. Installed on > trunk. > > Rainer apologies and many thanks for detecting and fixing this bug regards, Gaius
diff --git a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp --- a/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp +++ b/gcc/testsuite/gm2/warnings/returntype/fail/warnings-returntype-fail.exp @@ -28,6 +28,8 @@ load_lib gm2-torture.exp gm2_init_pim "${srcdir}/gm2/warnings/returntype/fail" global TORTURE_OPTIONS + +set old_options $TORTURE_OPTIONS set TORTURE_OPTIONS { { -O0 -g -Werror=return-type } } foreach testcase [lsort [glob -nocomplain $srcdir/$subdir/*.mod]] { @@ -38,3 +40,5 @@ foreach testcase [lsort [glob -nocomplai gm2-torture-fail $testcase } + +set TORTURE_OPTIONS $old_options