Message ID | 20230127093217.60818-4-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp742807wrn; Fri, 27 Jan 2023 01:41:36 -0800 (PST) X-Google-Smtp-Source: AMrXdXulowN970gc3e/wGnZ2rXws4SN+2MInlAKqsYiABaCt5MUUx5etvZUui6SxxfX4T0xSagCj X-Received: by 2002:a17:902:f542:b0:195:f412:5e6f with SMTP id h2-20020a170902f54200b00195f4125e6fmr29732016plf.48.1674812495815; Fri, 27 Jan 2023 01:41:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674812495; cv=none; d=google.com; s=arc-20160816; b=HUf049CIR6K9WGx8KtTAEcqoxdG8QGQr7d+++N6n4F8xeQQxJvKN4WOhwcoAgzvf4U wzaNRroPmSj6NXQVSgaogpzUutGP5LmoD69sVeHKnCZNxhwR1A817+AoKC6o7hae1tXe jdyJ9+I3T5PDdyWeUnsK4UGDhar1p/mO1yBAnQjgviUuwlN3NE8nHG8wFjhTp6UcwlOP JSgnvrpRKk9d7H4wxyDu1aMKqNG4RCh80GIBwoYevSaG6Ca4aF7upRnI3LeRWcPyt51X k2KQEarvTKQjcVII9ZoLOSBvanrtJK9X1BrLG7TAhJXMjJd03r1I40FfxARDjaO7tZjY N44Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bk9rrRbVlBSUREXw1iLQlsEZh4LHFBUluT2+RY/DXog=; b=l/wP4BCo2Sj/85UnA7ipsrBGU+9T5vRhhwMsDUC/CeWJAE/fVMTczKTI2gjJ/E7QBb d5lGQD9txUtsNnYfM3WxLt0g6nmDlTKTMyQZMCsi1kP1Ppxk59X0UPkl8IBU9DXS+BGE mMSKJmPakkhdjfYIjfBT489yRc99dQ4NQbbXb7HE3TievzXLhN1q+vjGl83CbFxH3A1k SFIe9Ah5UH4Zvzb0glCfnyWMhl2lFD4L5ObrhO8OigKzpz2PkGSXq6O7NbMS7iNEE45w /DT0LIl5Q3uvSuSkvdvBRrk6JR+apHBBXrHpMBj+rrTZzfr/zMh4aRoFZ/Eb5CNqjt6B 9pkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T4ho7Z56; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a170902cec100b00192e272f71dsi4625179plg.192.2023.01.27.01.41.23; Fri, 27 Jan 2023 01:41:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=T4ho7Z56; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232884AbjA0JdA (ORCPT <rfc822;lekhanya01809@gmail.com> + 99 others); Fri, 27 Jan 2023 04:33:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233109AbjA0Jck (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 27 Jan 2023 04:32:40 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F1A638024 for <linux-kernel@vger.kernel.org>; Fri, 27 Jan 2023 01:32:31 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id l8so2997029wms.3 for <linux-kernel@vger.kernel.org>; Fri, 27 Jan 2023 01:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bk9rrRbVlBSUREXw1iLQlsEZh4LHFBUluT2+RY/DXog=; b=T4ho7Z56EkelNKuLOIS7cADyCVSEQ8LKxCT/HEcCYIM9LjiuPwF5dDpt/48Ki3aOYF /X1dONb0m0tFA8HRxbGg/ELLlsV82x274Dsht5yhsCoc0Z1z+XageqYoXhIjIg9dOyZ2 wmCG2WmL1hQ3eaP7KZima2CGPK1YWOI9aOYcnlqhRaWqcmxI/+BQu4FzDLISdHXsfkkt OXuuDN+AK9ozvh9AerLh0LNm14jNUVLcxGDpUiCq+QzWmirbFguu/Fql/MOaCopNqCVk Lw1ey9dHYDYMiYGsF7Q2qJlMsrMYV3G23lmLT98Jpf2H+SRM7mYpr1WNPIIiaHar9QuI XIEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bk9rrRbVlBSUREXw1iLQlsEZh4LHFBUluT2+RY/DXog=; b=2ZXngy3t+oFRkIZeqmqaYi/KKbTkudIa6tH6j1f/PqOb7VRP4QmL8hXi7b36N+cvCn /ob9hFuJrqzZ+/DCTA/0cBi5+5epEiQM2S2WisIluZESmgcCym1C7a6qDE5J5g6xCws2 cdsKHSQFCx0VR+YuaQYvSMvlGOjm7rKmZu000JtPjDKZLEHQMRipPkKtGn3eLvlec+c6 kl/HUCudDAzAT/2L0JZenhnNOBNlVjZgxqrWBx5+gusZjW9CbLGu6fZtrPdhDItHFDST jnWUwUUgBM6CaFmsdf6JTKNzbQStT+qt57H3TgOC4Xt77jBJYO2o4WrbkdvuWdma8qy0 Zfrg== X-Gm-Message-State: AFqh2kodyDKIypmBjoOLhsUKX38rQuNp23G9OOxqioC/37+mi+M9Ani8 I73U2MM9JyTMHc+9mveGBg8puA== X-Received: by 2002:a05:600c:54d0:b0:3d9:7847:96e2 with SMTP id iw16-20020a05600c54d000b003d9784796e2mr38265609wmb.2.1674811949873; Fri, 27 Jan 2023 01:32:29 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id e19-20020a05600c439300b003cfd4e6400csm3795265wmn.19.2023.01.27.01.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 01:32:29 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Damien Le Moal <damien.lemoal@opensource.wdc.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Linus Walleij <linusw@kernel.org>, Imre Kaloz <kaloz@openwrt.org>, Krzysztof Halasa <khalasa@piap.pl>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Wim Van Sebroeck <wim@linux-watchdog.org>, Guenter Roeck <linux@roeck-us.net>, Marek Vasut <marex@denx.de>, Lubomir Rintel <lkundrak@v3.sk>, - <devicetree@vger.kernel.org>, Marc Zyngier <maz@kernel.org>, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH v2 3/3] dt-bindings: serial: restrict possible child node names Date: Fri, 27 Jan 2023 10:32:17 +0100 Message-Id: <20230127093217.60818-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230127093217.60818-1-krzysztof.kozlowski@linaro.org> References: <20230127093217.60818-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756168187477804246?= X-GMAIL-MSGID: =?utf-8?q?1756168187477804246?= |
Series |
dt-bindings: serial/mtd/mc/ata: use MC peripheral props
|
|
Commit Message
Krzysztof Kozlowski
Jan. 27, 2023, 9:32 a.m. UTC
The re-usable serial.yaml schema matches every property with ".*"
pattern, thus any other schema referencing it will not report unknown
(unevaluated) properties. This hides several wrong properties. It is
a limitation of dtschema, thus provide a simple workaround: expect
children to be only of few names matching upstream usage (Bluetooth,
GNSS, GPS and MCU).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/serial/serial.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Jan 27, 2023 at 10:32 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > The re-usable serial.yaml schema matches every property with ".*" > pattern, thus any other schema referencing it will not report unknown > (unevaluated) properties. This hides several wrong properties. It is > a limitation of dtschema, thus provide a simple workaround: expect > children to be only of few names matching upstream usage (Bluetooth, > GNSS, GPS and MCU). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Fair enough, Acked-by: Linus Walleij <linus.walleij@linaro.org> However I think V.35 WAN devices (high speed serial network links) should actually be using this? They are just some fancy serial port after all. Cf Documentation/devicetree/bindings/net/intel,ixp4xx-hss.yaml No big deal I guess since they are mostly an anarchronism and not on the table right now. Yours, Linus Walleij
On 27/01/2023 14:29, Linus Walleij wrote: > On Fri, Jan 27, 2023 at 10:32 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > >> The re-usable serial.yaml schema matches every property with ".*" >> pattern, thus any other schema referencing it will not report unknown >> (unevaluated) properties. This hides several wrong properties. It is >> a limitation of dtschema, thus provide a simple workaround: expect >> children to be only of few names matching upstream usage (Bluetooth, >> GNSS, GPS and MCU). >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Fair enough, > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > However I think V.35 WAN devices (high speed serial network links) > should actually be using this? They are just some fancy serial port > after all. Cf > Documentation/devicetree/bindings/net/intel,ixp4xx-hss.yaml > > No big deal I guess since they are mostly an anarchronism and not > on the table right now. intel,ixp4xx-hss is not part of the expansion bus node. Best regards, Krzysztof
On Sun, Jan 29, 2023 at 4:48 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 27/01/2023 14:29, Linus Walleij wrote: > > On Fri, Jan 27, 2023 at 10:32 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > > > >> The re-usable serial.yaml schema matches every property with ".*" > >> pattern, thus any other schema referencing it will not report unknown > >> (unevaluated) properties. This hides several wrong properties. It is > >> a limitation of dtschema, thus provide a simple workaround: expect > >> children to be only of few names matching upstream usage (Bluetooth, > >> GNSS, GPS and MCU). > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > Fair enough, > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > > However I think V.35 WAN devices (high speed serial network links) > > should actually be using this? They are just some fancy serial port > > after all. Cf > > Documentation/devicetree/bindings/net/intel,ixp4xx-hss.yaml > > > > No big deal I guess since they are mostly an anarchronism and not > > on the table right now. > > intel,ixp4xx-hss is not part of the expansion bus node. True, my point is that WAN V.35 devices in general should be, so that the pattern properties should include wan. But we can add it later if a user appears. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml index e05ad3ac2abc..c9231e501f1f 100644 --- a/Documentation/devicetree/bindings/serial/serial.yaml +++ b/Documentation/devicetree/bindings/serial/serial.yaml @@ -96,7 +96,7 @@ then: rts-gpios: false patternProperties: - ".*": + "^bluetooth|gnss|gps|mcu$": if: type: object then: