| Message ID | 20230127111913.117036-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp780928wrn;
Fri, 27 Jan 2023 03:28:24 -0800 (PST)
X-Google-Smtp-Source:
AK7set8TJV8e8dxjpKIZdbeWqCGqtw4XxmJAvCa6l1410vIV2Z5yR+OVcrMIA0BfgPCIVy+7/WWs
X-Received: by 2002:a17:903:124d:b0:192:ad82:dc98 with SMTP id
u13-20020a170903124d00b00192ad82dc98mr5658855plh.34.1674818904489;
Fri, 27 Jan 2023 03:28:24 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1674818904; cv=none;
d=google.com; s=arc-20160816;
b=fX7xkSnlLY4Y3ZrzxwDqRANhwCWrrx42hB970HSRWbjx4nvR3MLcQj0E0/8Pz6cNTV
rpkljnDceCJGBgEi0umiuR1GPTetTTUJ+mldBL6DJRs95s9yVIFDNqjMjl/0DSjKYZvb
70aybn7A2U3pKEGf7fLnD640aIEm7e8boQx7KO0GhxwCi82Cpod0t93NKxUw/tuR8iY6
6NU2fa/0RTcsKkhliZouLmtXILyVrGMLoZoncP730XQa+ULSLJG3jx8fgpi9MFkyuCkk
eQlMIGitdF80t5RIOixVTOheMYw/EZMCggvtEn+Jw6BZDzaC9lg9KwkDMn4fGkxf+b0a
ZolA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=UHPOSXcl0PvUmCRJGe++fk0HPlizptRgv2FYZzA8BdM=;
b=jf4EIFOYeHmkIDzw9wBqEKFMQjuiVHlD2mfiyitcUSIOF7qlCgd456WzWZtmBc3vHF
JBSIwUUYf/ghaSLFji77BmjsLms1kn4Sbjmn5mAPaAgzeZNjyE0WNDPrXPmZOd6qOkgT
+jXRDv3BZXEY0ONfOZM5NGdebti+Am/jnURqpR4GQsYpJV3uY47Qe8/cwOwsWXkqURI6
/DCupkfd77qYkbQHom0dtI7oA7Otu7oYGDr8WGd+oJkKV3VY30dHA/Kfl9VwR1XqRQ8k
7FKe+ZbZNY0Sbp0kLWznr42Ry1GsZwx+TCnLDpN5yQjzWtZ/+viifSq2HYVABC2ondCb
VGmg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=SZSZC43J;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
o12-20020a170902d4cc00b00189fdf3b84csi4908794plg.385.2023.01.27.03.28.08;
Fri, 27 Jan 2023 03:28:24 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=SZSZC43J;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233310AbjA0LVH (ORCPT <rfc822;lekhanya01809@gmail.com>
+ 99 others); Fri, 27 Jan 2023 06:21:07 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55370 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S233160AbjA0LUo (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 27 Jan 2023 06:20:44 -0500
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com
[IPv6:2a00:1450:4864:20::435])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4641A7AE6E
for <linux-kernel@vger.kernel.org>;
Fri, 27 Jan 2023 03:19:32 -0800 (PST)
Received: by mail-wr1-x435.google.com with SMTP id bk16so4643959wrb.11
for <linux-kernel@vger.kernel.org>;
Fri, 27 Jan 2023 03:19:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=UHPOSXcl0PvUmCRJGe++fk0HPlizptRgv2FYZzA8BdM=;
b=SZSZC43JlERBqyAp9tfew+eUJBbA43EsO5khxkd+BuRYoVSrnKE3/RcuNe6kLPBHPW
JiL4/FbmThbpEkU7p+o4+sJXFdZwyV2rq1mEjLx6YIcjHwzGId7+sAnJRtxc/+KwaG4w
udafqMLhPKNMTraaDLqdHzPx11rCc3EzB8i5SlzygWrkJSWHJKXMP3BYpP/Us6R73Hu/
gSsMmlxah56UeIZu0J+lPscAiQsEza3DryaUHfJuBcd4SPOaZwzdAhcQ6z7Z9BiSfzFS
sd8Qe78eddnxcNU9kqHlcvNwleB8CBDD+3xHxP4yho+WYTEy8Q5b0J0ZxRh6g2SOKS8h
tD8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=UHPOSXcl0PvUmCRJGe++fk0HPlizptRgv2FYZzA8BdM=;
b=EBjD5udDACHvxX5hQCqGun7TslgMBdOUfSuUnJxtJ6Aul1tAd+tx5vAcQUF1BLmSLv
UIXUWlr/tOZG+DonsolsYKnxkv+dZd91Lh6Q+Xd01Wi6nLng+14/49FbufvouE9PtuX4
RQTFEVShwA/F3Px6z9DiiysXY38oTNFA2dol1tdxqnFv56iUxMO76SNGIY7gmMb5Foxx
IrBj2IMshJkRnqAwYs5NIovQJ7zOzJCGLIUrYZh+/z46/0qQioCwOg7G5OCqEy68ZFa8
KndaGWcUruu5xHnMfiVOSL3BqO41NYTetFma67Q+iPD3+igI89wl193mKsJ5hDfoUp4L
RinA==
X-Gm-Message-State: AFqh2kpBZX22qKZ0SXW+qluHgCNz3M5y+c9CeEFoqw4pLCMM2o1NH32/
moooZGwQCk3yCcDQ+Vk6RaL3PQ==
X-Received: by 2002:adf:e310:0:b0:2bd:d8f1:2edf with SMTP id
b16-20020adfe310000000b002bdd8f12edfmr35173274wrj.49.1674818357628;
Fri, 27 Jan 2023 03:19:17 -0800 (PST)
Received: from krzk-bin.. ([178.197.216.144])
by smtp.gmail.com with ESMTPSA id
l15-20020a5d6d8f000000b002bfb37497a8sm4157584wrs.31.2023.01.27.03.19.16
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 27 Jan 2023 03:19:17 -0800 (PST)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Abel Vesa <abel.vesa@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH] arm64: dts: qcom: sm8550-mtp: drop incorrect
vdd-l6-l16-supply
Date: Fri, 27 Jan 2023 12:19:13 +0100
Message-Id: <20230127111913.117036-1-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1756174907376820475?=
X-GMAIL-MSGID: =?utf-8?q?1756174907376820475?=
|
| Series |
arm64: dts: qcom: sm8550-mtp: drop incorrect vdd-l6-l16-supply
|
|
Commit Message
Krzysztof Kozlowski
Jan. 27, 2023, 11:19 a.m. UTC
There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators.
Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 -
1 file changed, 1 deletion(-)
Comments
On 27.01.2023 12:19, Krzysztof Kozlowski wrote: > There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators. > > Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- @Abel, shouldn't this be l5-l16? Such combination would be valid as per the driver, but please recheck with schematics. Konrad > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 725d3bc3ee72..d6ae80414654 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -47,7 +47,6 @@ regulators-0 { > vdd-bob2-supply = <&vph_pwr>; > vdd-l2-l13-l14-supply = <&vreg_bob1>; > vdd-l3-supply = <&vreg_s4g_1p3>; > - vdd-l6-l16-supply = <&vreg_bob1>; > vdd-l6-l7-supply = <&vreg_bob1>; > vdd-l8-l9-supply = <&vreg_bob1>; > vdd-l11-supply = <&vreg_s4g_1p3>;
On 23-01-27 12:19:13, Krzysztof Kozlowski wrote: > There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators. > > Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 725d3bc3ee72..d6ae80414654 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -47,7 +47,6 @@ regulators-0 { > vdd-bob2-supply = <&vph_pwr>; > vdd-l2-l13-l14-supply = <&vreg_bob1>; > vdd-l3-supply = <&vreg_s4g_1p3>; > - vdd-l6-l16-supply = <&vreg_bob1>; NACK. There is actually an L6 but is not added yet. But the correct one here is actually: vdd-l5-l16-supply At least according to the power grid documentation. > vdd-l6-l7-supply = <&vreg_bob1>; > vdd-l8-l9-supply = <&vreg_bob1>; > vdd-l11-supply = <&vreg_s4g_1p3>; > -- > 2.34.1 >
On 23-01-27 13:34:03, Abel Vesa wrote: > On 23-01-27 12:19:13, Krzysztof Kozlowski wrote: > > There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators. > > > > Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts") > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > > index 725d3bc3ee72..d6ae80414654 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > > @@ -47,7 +47,6 @@ regulators-0 { > > vdd-bob2-supply = <&vph_pwr>; > > vdd-l2-l13-l14-supply = <&vreg_bob1>; > > vdd-l3-supply = <&vreg_s4g_1p3>; > > - vdd-l6-l16-supply = <&vreg_bob1>; > > NACK. > > There is actually an L6 but is not added yet. Actually L6 is added already, my bad. > > But the correct one here is actually: vdd-l5-l16-supply > > At least according to the power grid documentation. > > > vdd-l6-l7-supply = <&vreg_bob1>; > > vdd-l8-l9-supply = <&vreg_bob1>; > > vdd-l11-supply = <&vreg_s4g_1p3>; > > -- > > 2.34.1 > >
On 27/01/2023 12:34, Abel Vesa wrote: > On 23-01-27 12:19:13, Krzysztof Kozlowski wrote: >> There is no vdd-l6-l16 supply in qcom,pm8550-rpmh-regulators. >> >> Fixes: 71342fb91eae ("arm64: dts: qcom: Add base SM8550 MTP dts") >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> index 725d3bc3ee72..d6ae80414654 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> @@ -47,7 +47,6 @@ regulators-0 { >> vdd-bob2-supply = <&vph_pwr>; >> vdd-l2-l13-l14-supply = <&vreg_bob1>; >> vdd-l3-supply = <&vreg_s4g_1p3>; >> - vdd-l6-l16-supply = <&vreg_bob1>; > > NACK. > > There is actually an L6 but is not added yet. > > But the correct one here is actually: vdd-l5-l16-supply Konrad also suggested this. I'll correct to l5-l16. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts index 725d3bc3ee72..d6ae80414654 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts @@ -47,7 +47,6 @@ regulators-0 { vdd-bob2-supply = <&vph_pwr>; vdd-l2-l13-l14-supply = <&vreg_bob1>; vdd-l3-supply = <&vreg_s4g_1p3>; - vdd-l6-l16-supply = <&vreg_bob1>; vdd-l6-l7-supply = <&vreg_bob1>; vdd-l8-l9-supply = <&vreg_bob1>; vdd-l11-supply = <&vreg_s4g_1p3>;