| Message ID | 20221013152212.416661-7-angelogioacchino.delregno@collabora.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp337571wrs;
Thu, 13 Oct 2022 08:25:14 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM7ztKM9SQg+jz5kpp3Iq1EmC9f121u5/ncTAlBeRWpnDdSZDIfWlSlwGBay1kvLI3ndrjpN
X-Received: by 2002:a63:5141:0:b0:43c:1471:7eb5 with SMTP id
r1-20020a635141000000b0043c14717eb5mr306937pgl.587.1665674714579;
Thu, 13 Oct 2022 08:25:14 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1665674714; cv=none;
d=google.com; s=arc-20160816;
b=A7BLTB5xQ+RTqvk3j2Ouj9Fx5Eo2Gsqc85lTXRhWVLNuCIuDm6YIff8y1J4d4EGS57
c/gjjH7Uqu9zcpx3+QrmMflQLqq21XLdEM4G3VhZ5z/Wg9hYvX4TFGiSD3D7zKCFLfzn
BxxYWoRGWHUGxUgjwVTQg0kQrOmGI4ByzQGOOVuXcDiM1DQ5fzQ5oj05LVxJ6x2ckizD
y6Ww/29PWEImUXL6f2UoQr8fTEF6uDgGjzNz20TzsiD7tR7z3kIY4/t+h6Sj8PX27ouF
003lBkAvXwu17dRo4mqHaLC1VbiP+jZ5B/8hUVsBZAk3irmWXnX1LcNXLxQBfXoNdRdY
l22g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=ov420NLpC0YD+Qsl19uGAo67aWaxWZx+qIQbqcUwkiQ=;
b=YgpJuvKNGZ6llHWRT/2EIi0E+Pc0h1bgw00OMJ6NsEIgQW5d02MiXb/yrificwamav
eVceIqN690apvyvoMtRxhf/QeQSoH1DIxUHykTYdlHxBSVykTHLuqh7Bu5cfYG0wdIC2
7qU1mQR/RZZ6llFiK/ESeJ2KYN75y1fHDMIDOfuXpZtCO9yl9Cu50Y6yJN4CCjSjNX9v
f9RqkzrIzZKs1VXxenKGr98ndvnKQqbP5TJfI6mw5N3pbYb0GIWN07ORXfai4Pu72IPl
t8fvkRrqp4oqAleeVQ3Rr/ZmtwSQWXETSkDyfAAsjjgHeKkJXf4S7cmxW9LmJX1q77mN
K5Bg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=KnNC2aRr;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
w7-20020a170902e88700b001822121c45fsi15741746plg.338.2022.10.13.08.25.01;
Thu, 13 Oct 2022 08:25:14 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=KnNC2aRr;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229915AbiJMPWp (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others);
Thu, 13 Oct 2022 11:22:45 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60352 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229733AbiJMPW3 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 13 Oct 2022 11:22:29 -0400
Received: from madras.collabora.co.uk (madras.collabora.co.uk
[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49FA0127905;
Thu, 13 Oct 2022 08:22:27 -0700 (PDT)
Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it
[2.237.20.237])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
(Authenticated sender: kholk11)
by madras.collabora.co.uk (Postfix) with ESMTPSA id EA99A6602370;
Thu, 13 Oct 2022 16:22:24 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
s=mail; t=1665674545;
bh=OIVvm9eZZnDpMulbdkAjAXAZiIM5QtEjlxZKqlbUhN4=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=KnNC2aRr1CuewZByFW/jeStIoRR+cQKvdAc1e4Nr2itAlV18cP5mtMa9/jxqaXSCk
sgucXlPqmUQ47m2fAIT7AQdgdzJBYjEhSb6x2GSRHfIAT8lqfkvfvOWpWWnqNbOX5R
HLnmKQp34796JcP+uEprJMy9hi1xfJ7XAxHvejEe38Azb+Dy3I337s0zFX+7Cx7bQ5
Vjoa+sBjwjdt3ceInjCKF7zVfYwrKY4sokMPBiWCfs10FIMwfxtOX3P/wTsQNaa1ou
hx84eKrCmDIiZq4AiXSoZGCiEsU/VhmpBDvsJpqFuIQGLm/DnMboJA9tC+valF/VmF
7Y+up0VvDk0rg==
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
To: matthias.bgg@gmail.com
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
sam.shih@mediatek.com, hanks.chen@mediatek.com,
weiyi.lu@mediatek.com, zhiyong.tao@mediatek.com,
andrew-sh.cheng@mediatek.com, viresh.kumar@linaro.org,
chunfeng.yun@mediatek.com, fparent@baylibre.com,
mars.cheng@mediatek.com, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit
names
Date: Thu, 13 Oct 2022 17:22:10 +0200
Message-Id: <20221013152212.416661-7-angelogioacchino.delregno@collabora.com>
X-Mailer: git-send-email 2.37.2
In-Reply-To: <20221013152212.416661-1-angelogioacchino.delregno@collabora.com>
References: <20221013152212.416661-1-angelogioacchino.delregno@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1746586529236159857?=
X-GMAIL-MSGID: =?utf-8?q?1746586529236159857?=
|
| Series |
ARM64 MediaTek devicetree fixes - Part 1
|
|
Commit Message
AngeloGioacchino Del Regno
Oct. 13, 2022, 3:22 p.m. UTC
Update the names to regulator-usb-p{0-3}-vbus to fix unit_address_vs_reg
warnings for those.
Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712")
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote: > Update the names to regulator-usb-p{0-3}-vbus to fix > unit_address_vs_reg > warnings for those. > > Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712") > Signed-off-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > index 638908773706..d31a194124c9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { > id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; > }; > > - usb_p0_vbus: regulator@2 { > + usb_p0_vbus: regulator-usb-p0-vbus { Can we modify dt-binding of fixed regulator instead of changing the node name, since all nodes using fixed regulator may need be changed. > compatible = "regulator-fixed"; > regulator-name = "p0_vbus"; > regulator-min-microvolt = <5000000>; > @@ -59,7 +59,7 @@ usb_p0_vbus: regulator@2 { > enable-active-high; > }; > > - usb_p1_vbus: regulator@3 { > + usb_p1_vbus: regulator-usb-p1-vbus { > compatible = "regulator-fixed"; > regulator-name = "p1_vbus"; > regulator-min-microvolt = <5000000>; > @@ -68,7 +68,7 @@ usb_p1_vbus: regulator@3 { > enable-active-high; > }; > > - usb_p2_vbus: regulator@4 { > + usb_p2_vbus: regulator-usb-p2-vbus { > compatible = "regulator-fixed"; > regulator-name = "p2_vbus"; > regulator-min-microvolt = <5000000>; > @@ -77,7 +77,7 @@ usb_p2_vbus: regulator@4 { > enable-active-high; > }; > > - usb_p3_vbus: regulator@5 { > + usb_p3_vbus: regulator-usb-p3-vbus { > compatible = "regulator-fixed"; > regulator-name = "p3_vbus"; > regulator-min-microvolt = <5000000>;
Il 14/10/22 04:43, Chunfeng Yun ha scritto: > On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote: >> Update the names to regulator-usb-p{0-3}-vbus to fix >> unit_address_vs_reg >> warnings for those. >> >> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712") >> Signed-off-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> --- >> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >> index 638908773706..d31a194124c9 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { >> id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; >> }; >> >> - usb_p0_vbus: regulator@2 { >> + usb_p0_vbus: regulator-usb-p0-vbus { > Can we modify dt-binding of fixed regulator instead of changing the > node name, > since all nodes using fixed regulator may need be changed. > These regulators have no MMIO, nor need any index, so it would be simply wrong to change the binding and leave them as they are here in the devicetree. Regards, Angelo
On Fri, 2022-10-14 at 09:35 +0200, AngeloGioacchino Del Regno wrote: > Il 14/10/22 04:43, Chunfeng Yun ha scritto: > > On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno > > wrote: > > > Update the names to regulator-usb-p{0-3}-vbus to fix > > > unit_address_vs_reg > > > warnings for those. > > > > > > Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for > > > MT2712") > > > Signed-off-by: AngeloGioacchino Del Regno < > > > angelogioacchino.delregno@collabora.com> > > > --- > > > arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > > > b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > > > index 638908773706..d31a194124c9 100644 > > > --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > > > +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts > > > @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { > > > id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; > > > }; > > > > > > - usb_p0_vbus: regulator@2 { > > > + usb_p0_vbus: regulator-usb-p0-vbus { > > > > Can we modify dt-binding of fixed regulator instead of changing the > > node name, > > since all nodes using fixed regulator may need be changed. > > > > These regulators have no MMIO, nor need any index, so it would be > simply > wrong to change the binding and leave them as they are here in the > devicetree. You are right, then many files need be modified? Thanks > > Regards, > Angelo
Il 21/10/22 08:25, Chunfeng Yun ha scritto: > On Fri, 2022-10-14 at 09:35 +0200, AngeloGioacchino Del Regno wrote: >> Il 14/10/22 04:43, Chunfeng Yun ha scritto: >>> On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno >>> wrote: >>>> Update the names to regulator-usb-p{0-3}-vbus to fix >>>> unit_address_vs_reg >>>> warnings for those. >>>> >>>> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for >>>> MT2712") >>>> Signed-off-by: AngeloGioacchino Del Regno < >>>> angelogioacchino.delregno@collabora.com> >>>> --- >>>> arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++---- >>>> 1 file changed, 4 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >>>> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >>>> index 638908773706..d31a194124c9 100644 >>>> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >>>> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts >>>> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { >>>> id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; >>>> }; >>>> >>>> - usb_p0_vbus: regulator@2 { >>>> + usb_p0_vbus: regulator-usb-p0-vbus { >>> >>> Can we modify dt-binding of fixed regulator instead of changing the >>> node name, >>> since all nodes using fixed regulator may need be changed. >>> >> >> These regulators have no MMIO, nor need any index, so it would be >> simply >> wrong to change the binding and leave them as they are here in the >> devicetree. > You are right, then many files need be modified? > Yes Chunfeng, many files need to be modified due to mistakes made in the past. No big deal though: as long as we're all aware of what needs to happen, it's fine! Cheers, Angelo
diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts index 638908773706..d31a194124c9 100644 --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 { id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>; }; - usb_p0_vbus: regulator@2 { + usb_p0_vbus: regulator-usb-p0-vbus { compatible = "regulator-fixed"; regulator-name = "p0_vbus"; regulator-min-microvolt = <5000000>; @@ -59,7 +59,7 @@ usb_p0_vbus: regulator@2 { enable-active-high; }; - usb_p1_vbus: regulator@3 { + usb_p1_vbus: regulator-usb-p1-vbus { compatible = "regulator-fixed"; regulator-name = "p1_vbus"; regulator-min-microvolt = <5000000>; @@ -68,7 +68,7 @@ usb_p1_vbus: regulator@3 { enable-active-high; }; - usb_p2_vbus: regulator@4 { + usb_p2_vbus: regulator-usb-p2-vbus { compatible = "regulator-fixed"; regulator-name = "p2_vbus"; regulator-min-microvolt = <5000000>; @@ -77,7 +77,7 @@ usb_p2_vbus: regulator@4 { enable-active-high; }; - usb_p3_vbus: regulator@5 { + usb_p3_vbus: regulator-usb-p3-vbus { compatible = "regulator-fixed"; regulator-name = "p3_vbus"; regulator-min-microvolt = <5000000>;