diff mbox series

arm64: dts: imx8mm-verdin: Do not power down eth-phy

Message ID 20230116140153.23938-1-dev@pschenker.ch
State New
Headers
Series arm64: dts: imx8mm-verdin: Do not power down eth-phy |

Commit Message

Philippe Schenker Jan. 16, 2023, 2:01 p.m. UTC 
  From: Philippe Schenker <philippe.schenker@toradex.com>

Currently if suspending using either freeze or memory state, the fec
driver tries to power down the phy which leads to crash of the kernel
and non-responsible kernel with the following call trace:

[   24.839889 ] Call trace:
[   24.839892 ]  phy_error+0x18/0x60
[   24.839898 ]  kszphy_handle_interrupt+0x6c/0x80
[   24.839903 ]  phy_interrupt+0x20/0x2c
[   24.839909 ]  irq_thread_fn+0x30/0xa0
[   24.839919 ]  irq_thread+0x178/0x2c0
[   24.839925 ]  kthread+0x154/0x160
[   24.839932 ]  ret_from_fork+0x10/0x20

Since there is currently no functionality in the phy subsystem to power
down phys let's just disable the feature of powering-down the ethernet
phy.

Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

---

 arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Shawn Guo Jan. 26, 2023, 7:32 a.m. UTC | #1 
On Mon, Jan 16, 2023 at 03:01:52PM +0100, Philippe Schenker wrote:
> From: Philippe Schenker <philippe.schenker@toradex.com>
> 
> Currently if suspending using either freeze or memory state, the fec
> driver tries to power down the phy which leads to crash of the kernel
> and non-responsible kernel with the following call trace:
> 
> [   24.839889 ] Call trace:
> [   24.839892 ]  phy_error+0x18/0x60
> [   24.839898 ]  kszphy_handle_interrupt+0x6c/0x80
> [   24.839903 ]  phy_interrupt+0x20/0x2c
> [   24.839909 ]  irq_thread_fn+0x30/0xa0
> [   24.839919 ]  irq_thread+0x178/0x2c0
> [   24.839925 ]  kthread+0x154/0x160
> [   24.839932 ]  ret_from_fork+0x10/0x20
> 
> Since there is currently no functionality in the phy subsystem to power
> down phys let's just disable the feature of powering-down the ethernet
> phy.
> 
> Fixes: 6a57f224f734 ("arm64: dts: freescale: add initial support for verdin imx8m mini")
> Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
index 7e8b3b0fa306..4df3c9760151 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
@@ -102,6 +102,7 @@  reg_ethphy: regulator-ethphy {
 		off-on-delay = <500000>;
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_reg_eth>;
+		regulator-always-on;
 		regulator-boot-on;
 		regulator-max-microvolt = <3300000>;
 		regulator-min-microvolt = <3300000>;