Message ID | 20230125-tfp410_i2c-v1-1-66a4d4e390b7@criticallink.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp488473wrn; Wed, 25 Jan 2023 13:14:16 -0800 (PST) X-Google-Smtp-Source: AMrXdXssrKhTTw3/bwgTPovZ2kBv4pSVTRi6SAsQ35gTqn0ZkpJ9cNA5Jiz+jXKNIPZYlmw090Ap X-Received: by 2002:a17:906:26d7:b0:84c:a065:d723 with SMTP id u23-20020a17090626d700b0084ca065d723mr30598980ejc.44.1674681256294; Wed, 25 Jan 2023 13:14:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674681256; cv=none; d=google.com; s=arc-20160816; b=qvUtegvYpO4K+tZXDJMo8t3ijORjvdeg8W85sKJH7Vxp1vGMRLBhnRDnOQpEyOx4Gk lI57BggbCr8htgiSA0RJS5mfJUY1gOMOafqAQV0mgsydmRXmP79i/18Ogq5VKW08bBlr e8zdN95zCjTmrg99l2r1QFNJj4WYdI/yPs36Oxc/zDDGDGVe0VdeqLTGTyzCO/vabg/v 00RIPxzx4CVdInCqmv/sCrb2rDFSnKkukJBI5PIrv9c10OOYnzoz3YmoI4IaMfEEeM55 zImNf7GQkunRy5IWZ+cbp1oQPn6eKdRQxq1kBvM6N9eFD12PHI7Q3DJqCFGqiwh4u1lG G1KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=fUjI7H8s1MYo6Cc+S/e5j/o7dI4Q79O1EcwP8gpHRPk=; b=j47pQw9ikcMTDgNKgsTNYMO4NphPftnuNRqHWju4tZsw2KbaDetkiFd1lqMxX+M3+p JHyqoGLYgNUpRv88LG3ZRAmkva6C2Gq419XejEeqyBh4QULaKYdDciNUI1Ww6lLniqLs n0xIXAvmgZ83PbyzLEEubJMLibMJ4oN987q7L0glyyGuXjwKRJ3upFnxYz1oCjrT4Slh FqoGa76/PtzSwEetZNERFUDvTI02TxdXv38u+5zMOn5TwNL0fptW2omq890DI4LYQH+T oXZ45x39T+YZBrqZx5qM3TlgNJv7pXyehXA1QjmNOGj/Y8L5WDmtBRGpdgQlo7VCZYSE Pm1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=WmRJE2Mq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ui28-20020a170907c91c00b0086b6a3fd247si6631873ejc.557.2023.01.25.13.13.51; Wed, 25 Jan 2023 13:14:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@criticallink.com header.s=google header.b=WmRJE2Mq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=criticallink.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236680AbjAYVKm (ORCPT <rfc822;lekhanya01809@gmail.com> + 99 others); Wed, 25 Jan 2023 16:10:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234642AbjAYVKY (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 25 Jan 2023 16:10:24 -0500 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B04C5AA62 for <linux-kernel@vger.kernel.org>; Wed, 25 Jan 2023 13:09:21 -0800 (PST) Received: by mail-qt1-x82e.google.com with SMTP id g16so15153554qtu.2 for <linux-kernel@vger.kernel.org>; Wed, 25 Jan 2023 13:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=criticallink.com; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fUjI7H8s1MYo6Cc+S/e5j/o7dI4Q79O1EcwP8gpHRPk=; b=WmRJE2Mq3Y+K4158GTsOqdZvqf33NCVXb6of19VtyNo0PcicmQNERhsu7pw2PcRyMm Vz1utLmAmbd1YPUFxI8pDqWLvZqh8Rpe1qY5VMxVQb9rjYMgI7FGlHWwb5OwFCQUxtU9 gu6GkH6MCUev7XYvuuPwgWfw3yYbBZ8wPe3KKpEmp2INlv+S5MxtUFVPluSh9Yehpeag lneKEXSp4XmuqFuwtRRRSQ3tDAivnOQDLNvK7BnK6XYRICC/GTej7dWLLc05kpFbk5KH WXiJxzmzgQ7fLEVaV4LSzo52layZX7CYhG/CEYGDr4J6GI8rIwa4ihRSPRq0LRgQbMLq q3qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fUjI7H8s1MYo6Cc+S/e5j/o7dI4Q79O1EcwP8gpHRPk=; b=xdpEnAtkRtdyoV3MaEL2Ef7uYm6M15ZxlVe5nrRB4QX7s/hDfvRhY2kqts2bpmy3uZ 1Y35a41hWMCKRL80EPERNMB2SoXkI3D96jvWVrvsrL45v6RxSa8F7PNJqZ5k5evIhE3b hEWxjR3wyHpVs00ocH4qLkALC3HQoza2w00juPygft1KGgsxllBx8P2O6oz3DbEZlabw V4xT7FVhnVYoxfH2/i9P/OyhvngzLOLO0yb3fM3vj8+uaasIZ895Sh6UVWgNUEnaO44a lVXRFxPu6Musn2rHTnljEV1ADhvKVNaDCU/UI7mZKxwok0KKZu6dds7ZiHRcDXDPCw7m aXBw== X-Gm-Message-State: AO0yUKX1dwWqUB3AUIWOqCvudS6eOgIETuo9uq+Fsv7FJcDhjPrlOEu1 ak+wlWYmLRdfMCYuih6SrDzKgw== X-Received: by 2002:a05:622a:494:b0:3b6:4249:bbca with SMTP id p20-20020a05622a049400b003b64249bbcamr7001049qtx.55.1674680958298; Wed, 25 Jan 2023 13:09:18 -0800 (PST) Received: from [127.0.1.1] (static-72-90-70-109.syrcny.fios.verizon.net. [72.90.70.109]) by smtp.gmail.com with ESMTPSA id q196-20020a3743cd000000b0070736988c10sm4177090qka.110.2023.01.25.13.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 13:09:17 -0800 (PST) From: Jonathan Cormier <jcormier@criticallink.com> Date: Wed, 25 Jan 2023 16:09:09 -0500 Subject: [PATCH 1/4] dt-bindings: display: bridge: tfp410: Add tfp410 i2c example MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230125-tfp410_i2c-v1-1-66a4d4e390b7@criticallink.com> References: <20230125-tfp410_i2c-v1-0-66a4d4e390b7@criticallink.com> In-Reply-To: <20230125-tfp410_i2c-v1-0-66a4d4e390b7@criticallink.com> To: Andrzej Hajda <andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <robert.foss@linaro.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Jyri Sarha <jsarha@ti.com> Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Williamson <michael.williamson@criticallink.com>, Bob Duke <bduke@criticallink.com>, Jonathan Cormier <jcormier@criticallink.com> X-Mailer: b4 0.11.3-dev-d001f X-Developer-Signature: v=1; a=openpgp-sha256; l=1541; i=jcormier@criticallink.com; h=from:subject:message-id; bh=Ne8kM0iOMcS7U5BkEx6jIQptCk+Yyk87jfs/YUNCJd4=; b=owEBbQKS/ZANAwAKAdzX/S4LNuuqAcsmYgBj0Zp7UF8IgNYOldWOmS1L7oYJE1M9wa/rtzY7bwpg As8z5cOJAjMEAAEKAB0WIQT/MozqCeZtYxNnVN/c1/0uCzbrqgUCY9GaewAKCRDc1/0uCzbrqqg7EA C2dSK8WyTKgvw8F11qy4Z57FlvkXXc96GXak0aeWgH2SeRpR5VeUg//WoWgoLALeN+yr8Zer8VbHx9 pYkAJzmmmSA3eym1PtscHMdHF6EY79tufpY5cBN7TZAtRI5TJ5aX8zLzKKeEzQ7DZfhCrUuNKnqoND FzpVO+M3yYubTnp1tqgWPQz3zhGVnTTlXkYcyXs50CBDXj7R/1sJlpgCvspkPXynYobaS6cGzv5D3Z TDStjQmbbYqb0x7jyiR0SjoHeLlNB+1rnzGJ16Ez857rqo/A8kibojKWUxFcytWROpT8kHrDOh8LIb LWFBy2WZMsvU0kxCD9bjy7TQ4g7CgSOeRa9effsX1yAMQiAOQ4TUUpDRdVwCGusV5DKnfNRn+xEVpl 6cY4jSTz3SkG4GgX66jGvQv5xgrML5TV+cCRyQVx4TkiW9PB71nZkVn7STWc8dZRlNh+OMuhU0R/zU lCp3ZAoa1vwnPuHy5tKYxjgjEruwsMWN56zPS/J6SQz5nh4IAZzQL0DstS4g9r1LvGcnDFzX1Nlh6d mC1V41L9Om+BYLIQSv9pVWG1+GniW/s1W+jLE8JzWBJxeGnIwYwC7seD/IdE3VL5IVK6Hcez1jypOk 1PEqO9BLxE1tU6fzFaddvLptinwdYV3oJ/GuSZc2zaLglaY7AUgCyNn2tAjw== X-Developer-Key: i=jcormier@criticallink.com; a=openpgp; fpr=FF328CEA09E66D63136754DFDCD7FD2E0B36EBAA X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756030572961292894?= X-GMAIL-MSGID: =?utf-8?q?1756030572961292894?= |
Series |
DRM: BRIDGE: TFP410: Add i2c support
|
|
Commit Message
Jonathan Cormier
Jan. 25, 2023, 9:09 p.m. UTC
Add a i2c example with HDMI connector
Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
---
.../bindings/display/bridge/ti,tfp410.yaml | 42 ++++++++++++++++++++++
1 file changed, 42 insertions(+)
Comments
Hi Jonathan, Thank you for the patch. On Wed, Jan 25, 2023 at 04:09:09PM -0500, Jonathan Cormier wrote: > Add a i2c example with HDMI connector > > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com> > --- > .../bindings/display/bridge/ti,tfp410.yaml | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > index 4c5dd8ec2951..456214f14b47 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > @@ -116,4 +116,46 @@ examples: > }; > }; > > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; Please use 4 spaces for indentation, as in the other example. > + > + hdmi_encoder: tfp410@38 { > + compatible = "ti,tfp410"; > + reg = <0x38>; > + > + ports { > + address-cells = <1>; > + size-cells = <0>; > + > + port@0 { > + reg = <0>; > + tfp410_in: endpoint { > + remote-endpoint = <&dpi1_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + tfp410_out: endpoint { > + remote-endpoint = <&hdmi_connector_in>; > + }; > + }; > + }; > + }; > + }; > + > + hdmi: hdmi_connector { > + compatible = "hdmi-connector"; > + label = "hdmi"; > + type = "a"; > + ddc-i2c-bus = <&i2c1>; > + port { > + hdmi_connector_in: endpoint { > + remote-endpoint = <&tfp410_out>; > + }; > + }; > + }; > + You can drop the hdmi connector, the example will still validate. > ...
On Wed, Jan 25, 2023 at 4:24 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Jonathan, > > Thank you for the patch. > > On Wed, Jan 25, 2023 at 04:09:09PM -0500, Jonathan Cormier wrote: > > Add a i2c example with HDMI connector > > > > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com> > > --- > > .../bindings/display/bridge/ti,tfp410.yaml | 42 ++++++++++++++++++++++ > > 1 file changed, 42 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > > index 4c5dd8ec2951..456214f14b47 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > > @@ -116,4 +116,46 @@ examples: > > }; > > }; > > > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > Please use 4 spaces for indentation, as in the other example. Will do, the whole file is 2 space indents. I didn't notice the examples switch to 4 spaces. > > > + > > + hdmi_encoder: tfp410@38 { > > + compatible = "ti,tfp410"; > > + reg = <0x38>; > > + > > + ports { > > + address-cells = <1>; > > + size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + tfp410_in: endpoint { > > + remote-endpoint = <&dpi1_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + tfp410_out: endpoint { > > + remote-endpoint = <&hdmi_connector_in>; > > + }; > > + }; > > + }; > > + }; > > + }; > > + > > + hdmi: hdmi_connector { > > + compatible = "hdmi-connector"; > > + label = "hdmi"; > > + type = "a"; > > + ddc-i2c-bus = <&i2c1>; > > + port { > > + hdmi_connector_in: endpoint { > > + remote-endpoint = <&tfp410_out>; > > + }; > > + }; > > + }; > > + > > You can drop the hdmi connector, the example will still validate. Okay > > > ... > > -- > Regards, > > Laurent Pinchart
On Wed, 25 Jan 2023 16:09:09 -0500, Jonathan Cormier wrote: > Add a i2c example with HDMI connector > > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com> > --- > .../bindings/display/bridge/ti,tfp410.yaml | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/display/bridge/ti,tfp410.example.dts:77.37-79.19: ERROR (duplicate_label): /example-1/i2c/tfp410@38/ports/port@0/endpoint: Duplicate label 'tfp410_in' on /example-1/i2c/tfp410@38/ports/port@0/endpoint and /example-0/encoder/ports/port@0/endpoint Documentation/devicetree/bindings/display/bridge/ti,tfp410.example.dts:84.38-86.19: ERROR (duplicate_label): /example-1/i2c/tfp410@38/ports/port@1/endpoint: Duplicate label 'tfp410_out' on /example-1/i2c/tfp410@38/ports/port@1/endpoint and /example-0/encoder/ports/port@1/endpoint ERROR: Input tree has errors, aborting (use -f to force output) make[1]: *** [scripts/Makefile.lib:434: Documentation/devicetree/bindings/display/bridge/ti,tfp410.example.dtb] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1508: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230125-tfp410_i2c-v1-1-66a4d4e390b7@criticallink.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 25/01/2023 22:09, Jonathan Cormier wrote: > Add a i2c example with HDMI connector Why? It's the same - but more on this below. > > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com> You need to test the bindings before sending and fix the errors. > --- > .../bindings/display/bridge/ti,tfp410.yaml | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > index 4c5dd8ec2951..456214f14b47 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml > @@ -116,4 +116,46 @@ examples: > }; > }; > > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + hdmi_encoder: tfp410@38 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "ti,tfp410"; > + reg = <0x38>; > + > + ports { > + address-cells = <1>; > + size-cells = <0>; > + > + port@0 { > + reg = <0>; > + tfp410_in: endpoint { > + remote-endpoint = <&dpi1_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + tfp410_out: endpoint { > + remote-endpoint = <&hdmi_connector_in>; > + }; That's the same example as existing one, so it looks useless. I don't see benefits of this example. > + }; > + }; > + }; > + }; > + > + hdmi: hdmi_connector { Drop. Incorrect name and not really related. > + compatible = "hdmi-connector"; > + label = "hdmi"; > + type = "a"; > + ddc-i2c-bus = <&i2c1>; > + port { > + hdmi_connector_in: endpoint { > + remote-endpoint = <&tfp410_out>; > + }; > + }; > + }; > + > ... > Best regards, Krzysztof
On 26/01/2023 19:36, Jon Cormier wrote: > On Thu, Jan 26, 2023 at 10:40 AM Krzysztof Kozlowski < > krzysztof.kozlowski@linaro.org> wrote: > >> On 25/01/2023 22:09, Jonathan Cormier wrote: >>> Add a i2c example with HDMI connector >> >> Why? It's the same - but more on this below. >> > The existing example is for the previous setup where it was configured as > its own device. It seemed necessary now that the driver is going to > support being connected to an i2c bus to show it being used as such. > >> >>> >>> Signed-off-by: Jonathan Cormier <jcormier@criticallink.com> >> >> You need to test the bindings before sending and fix the errors. >> > Will do > >> >>> --- >>> .../bindings/display/bridge/ti,tfp410.yaml | 42 >> ++++++++++++++++++++++ >>> 1 file changed, 42 insertions(+) >>> >>> diff --git >> a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml >> b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml >>> index 4c5dd8ec2951..456214f14b47 100644 >>> --- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml >>> +++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml >>> @@ -116,4 +116,46 @@ examples: >>> }; >>> }; >>> >>> + - | >>> + i2c { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + hdmi_encoder: tfp410@38 { >> >> Node names should be generic. >> >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation >> >> Can do > >>> + compatible = "ti,tfp410"; >>> + reg = <0x38>; >>> + >>> + ports { >>> + address-cells = <1>; >>> + size-cells = <0>; >>> + >>> + port@0 { >>> + reg = <0>; >>> + tfp410_in: endpoint { >>> + remote-endpoint = <&dpi1_out>; >>> + }; >>> + }; >>> + >>> + port@1 { >>> + reg = <1>; >>> + tfp410_out: endpoint { >>> + remote-endpoint = <&hdmi_connector_in>; >>> + }; >> >> That's the same example as existing one, so it looks useless. I don't >> see benefits of this example. >> > It's mostly the same, except defined inside an i2c bus, with the reg value > set. Without the powerdown-gpios or ti,deskew. > And without the pclk-sample and bus-width (these are now read from i2c) > And I included the hdmi_connector so it would be a more complete and useful > example of how it could be used. hdmi_connector is being dropped because it is not related. > The TFP410 doesn't handle the ddc i2c bus > on its own so a separate connector node is needed. I'll drop it if that's > preferred. > If you had here different ports, it would be different case. But as of now the only important part is having reg and not having gpios, so basically almost the same example. No need for it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml index 4c5dd8ec2951..456214f14b47 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml @@ -116,4 +116,46 @@ examples: }; }; + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + hdmi_encoder: tfp410@38 { + compatible = "ti,tfp410"; + reg = <0x38>; + + ports { + address-cells = <1>; + size-cells = <0>; + + port@0 { + reg = <0>; + tfp410_in: endpoint { + remote-endpoint = <&dpi1_out>; + }; + }; + + port@1 { + reg = <1>; + tfp410_out: endpoint { + remote-endpoint = <&hdmi_connector_in>; + }; + }; + }; + }; + }; + + hdmi: hdmi_connector { + compatible = "hdmi-connector"; + label = "hdmi"; + type = "a"; + ddc-i2c-bus = <&i2c1>; + port { + hdmi_connector_in: endpoint { + remote-endpoint = <&tfp410_out>; + }; + }; + }; + ...