[v3,2/2] dt-bindings: hpet: add loongson2 hpet
Commit Message
Add the loongson2 High Precision Event Timer (HPET) binding
with DT schema format using json-schema.
Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
---
Change in v3:
1. Update dts that base on common clock framework.
.../bindings/timer/loongson,ls2k-hpet.yaml | 50 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
Comments
On Fri, 21 Oct 2022 09:09:25 +0800, Yinbo Zhu wrote:
> Add the loongson2 High Precision Event Timer (HPET) binding
> with DT schema format using json-schema.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> ---
> Change in v3:
> 1. Update dts that base on common clock framework.
>
> .../bindings/timer/loongson,ls2k-hpet.yaml | 50 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.example.dts:21:18: fatal error: dt-bindings/clock/loongson,ls2k-clk.h: No such file or directory
21 | #include <dt-bindings/clock/loongson,ls2k-clk.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1492: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
On 20/10/2022 21:09, Yinbo Zhu wrote:
> Add the loongson2 High Precision Event Timer (HPET) binding
> with DT schema format using json-schema.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> ---
> Change in v3:
> 1. Update dts that base on common clock framework.
>
> .../bindings/timer/loongson,ls2k-hpet.yaml | 50 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
>
> diff --git a/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
> new file mode 100644
> index 000000000000..01656048858a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/timer/loongson,ls2k-hpet.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson2 High Precision Event Timer (HPET)
> +
> +maintainers:
> + - Yinbo Zhu <zhuyinbo@loongson.cn>
> +
> +properties:
> + compatible:
> + const: loongson,ls2k-hpet
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: SoC apb clock
> +
> + clock-names:
> + items:
> + - const: apb_clk
Just: apb
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/loongson,ls2k-clk.h>
Your patchset is now untestable/unapplicable because you have a
dependency. You need to explain the dependencies in the cover letter or
in the patch changelog (---).
Best regards,
Krzysztof
new file mode 100644
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/loongson,ls2k-hpet.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Loongson2 High Precision Event Timer (HPET)
+
+maintainers:
+ - Yinbo Zhu <zhuyinbo@loongson.cn>
+
+properties:
+ compatible:
+ const: loongson,ls2k-hpet
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: SoC apb clock
+
+ clock-names:
+ items:
+ - const: apb_clk
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/loongson,ls2k-clk.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ timer@1fe24000 {
+ compatible = "loongson,ls2k-hpet";
+ reg = <0x1fe24000 0x15f>;
+ clocks = <&clk LOONGSON2_APB_CLK>;
+ clock-names = "apb_clk";
+ interrupt-parent = <&liointc0>;
+ interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
+ };
@@ -11919,6 +11919,7 @@ LOONGSON2 SOC SERIES HPET DRIVER
M: Yinbo Zhu <zhuyinbo@loongson.cn>
L: linux-kernel@vger.kernel.org
S: Maintained
+F: Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
F: drivers/clocksource/loongson2_hpet.c
LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)