| Message ID | 20230120090846.18172-1-alexandru.tachici@analog.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp94923wrn;
Fri, 20 Jan 2023 01:14:29 -0800 (PST)
X-Google-Smtp-Source:
AMrXdXvYUqy0mml9BUVk7UNFspXOm7Gon7h1ud38XgBoPxQWjBSfy2L9htqFs4JuTQUVU0Cb1teR
X-Received: by 2002:a05:6402:2055:b0:479:6c4f:40df with SMTP id
bc21-20020a056402205500b004796c4f40dfmr13130062edb.18.1674206068919;
Fri, 20 Jan 2023 01:14:28 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1674206068; cv=none;
d=google.com; s=arc-20160816;
b=uu34rNvvLv/HCXWQi2BcexDQBF+gSXzWsmtSB0UI1+HEKpIKrqWpKQ0BU15kLjXKPg
FNamnkEJc2zRZSTAtmux6XBYnQr8mBMUa8twMcdTaAL3YLvoQ5gkQpgq9wPc9hpMVyjb
M6p5lQ4d5zrvakxRlrshbj8LTy5v/q0wPrQReFzBQ1ncyR9ekstckEU31h2qMYZTsLpu
uxylion/i2FmljOmGX37aN0I382YoAyDJpMrDr2CRUXTestauTqMvABitOpkKuTCj43B
Dcl2+gcvodSwnBNF/+9roNWErLk0pUdhPDXtNo1augOT+dSlpCBRJKBjNWq3FmIivnYp
fNnQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=+NO8KpEgXHxFeM6i1SuHTGZEy0PAKiKkk7P6qZv/7Bw=;
b=sVntehgnulTajccSYyzagmzl2nVlDUKWkHn8nm+Fjv0Rbpi/aP4M7HC1Lojyb/rsc4
PfxDVzOzECKzjzjPPDGVVI1ip40nbG6O7bdtG4SIdT8VWyljvH7A8EoiCOuBvUnohX6U
Q3h0NK/wa97yt57y4aJMyuYNsr9eVGwRDzF43BZzxSJH5YTp723O/DvoqngS0iyFIT1r
1mBosUm2bTNJI8KQ8wS8lgWWZ12+Eq/YdPK2o1RNGr8JYgxeCzmrcBf1p7P+nbiodk2L
Ya/2uNGNtPFP42x2/ypgoDb9I1zTGaZCoV7s7ee0EtqBFQ8G//HYV9c6PzGb03tdrbGs
p2Sg==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
bd22-20020a056402207600b0046fbd084ea6si16019578edb.142.2023.01.20.01.14.05;
Fri, 20 Jan 2023 01:14:28 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=analog.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229812AbjATJKC (ORCPT <rfc822;changwoo.m@gmail.com> + 99 others);
Fri, 20 Jan 2023 04:10:02 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48338 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229730AbjATJKA (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 20 Jan 2023 04:10:00 -0500
Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com
[148.163.135.77])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64E6990B2A;
Fri, 20 Jan 2023 01:09:17 -0800 (PST)
Received: from pps.filterd (m0167089.ppops.net [127.0.0.1])
by mx0a-00128a01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
30K8fx3n023423;
Fri, 20 Jan 2023 04:09:04 -0500
Received: from pps.reinject (localhost [127.0.0.1])
by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3n7qnw03rv-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Fri, 20 Jan 2023 04:09:04 -0500
Received: from m0167089.ppops.net (m0167089.ppops.net [127.0.0.1])
by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 30K95qrd013945;
Fri, 20 Jan 2023 04:09:04 -0500
Received: from nwd2mta4.analog.com ([137.71.173.58])
by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 3n7qnw03rs-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Fri, 20 Jan 2023 04:09:04 -0500
Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5])
by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 30K993iu034540
(version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=FAIL);
Fri, 20 Jan 2023 04:09:03 -0500
Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com
(10.64.17.5) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Fri, 20 Jan
2023 04:09:02 -0500
Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com
(10.64.17.5) with Microsoft SMTP Server id 15.2.986.14 via Frontend
Transport; Fri, 20 Jan 2023 04:09:02 -0500
Received: from tachici-Precision-5530.ad.analog.com ([10.48.65.139])
by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 30K98oxo018971;
Fri, 20 Jan 2023 04:08:52 -0500
From: Alexandru Tachici <alexandru.tachici@analog.com>
To: <linux-kernel@vger.kernel.org>
CC: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<yangyingliang@huawei.com>
Subject: [net] net: ethernet: adi: adin1110: Fix multicast offloading
Date: Fri, 20 Jan 2023 11:08:46 +0200
Message-ID: <20230120090846.18172-1-alexandru.tachici@analog.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=US-ASCII
X-ADIRuleOP-NewSCL: Rule Triggered
X-Proofpoint-GUID: SXL9UAdmmlBKMA-1ukx0FdRF3AcEPssf
X-Proofpoint-ORIG-GUID: zjoizI9yYtZ2PwtWG9UkspSRsRcjU1Ne
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
definitions=2023-01-20_06,2023-01-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
impostorscore=0
lowpriorityscore=0 adultscore=0 mlxscore=0 bulkscore=0 phishscore=0
spamscore=0 priorityscore=1501 clxscore=1011 suspectscore=0 malwarescore=0
mlxlogscore=821 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2212070000 definitions=main-2301200086
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1755532303032775714?=
X-GMAIL-MSGID: =?utf-8?q?1755532303032775714?=
|
| Series |
[net] net: ethernet: adi: adin1110: Fix multicast offloading
|
|
Commit Message
Alexandru Tachici
Jan. 20, 2023, 9:08 a.m. UTC
Driver marked broadcast/multicast frames as offloaded incorrectly.
Mark them as offloaded only when HW offloading has been enabled.
This should happen only for ADIN2111 when both ports are bridged
by the software.
Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
drivers/net/ethernet/adi/adin1110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Jan 20, 2023 at 11:08:46AM +0200, Alexandru Tachici wrote: > Driver marked broadcast/multicast frames as offloaded incorrectly. > Mark them as offloaded only when HW offloading has been enabled. > This should happen only for ADIN2111 when both ports are bridged > by the software. > > Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support") > Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 20 Jan 2023 11:08:46 +0200 you wrote: > Driver marked broadcast/multicast frames as offloaded incorrectly. > Mark them as offloaded only when HW offloading has been enabled. > This should happen only for ADIN2111 when both ports are bridged > by the software. > > Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support") > Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com> > > [...] Here is the summary with links: - [net] net: ethernet: adi: adin1110: Fix multicast offloading https://git.kernel.org/netdev/net/c/8a4f6d023221 You are awesome, thank you!
diff --git a/drivers/net/ethernet/adi/adin1110.c b/drivers/net/ethernet/adi/adin1110.c index 0805f249fff2..c26b8597945b 100644 --- a/drivers/net/ethernet/adi/adin1110.c +++ b/drivers/net/ethernet/adi/adin1110.c @@ -356,7 +356,7 @@ static int adin1110_read_fifo(struct adin1110_port_priv *port_priv) if ((port_priv->flags & IFF_ALLMULTI && rxb->pkt_type == PACKET_MULTICAST) || (port_priv->flags & IFF_BROADCAST && rxb->pkt_type == PACKET_BROADCAST)) - rxb->offload_fwd_mark = 1; + rxb->offload_fwd_mark = port_priv->priv->forwarding; netif_rx(rxb);