Message ID | 20230120155404.323386-6-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp276574wrn; Fri, 20 Jan 2023 07:58:47 -0800 (PST) X-Google-Smtp-Source: AMrXdXvOW/+Z5lea9EK7zKc3klsC6tYfRsyP3OOzEMMuFSp8u9aNZfBOSnHUBC+yoN/Eh/SIltYx X-Received: by 2002:a17:907:cf48:b0:86b:914a:571 with SMTP id uv8-20020a170907cf4800b0086b914a0571mr16180281ejc.5.1674230327289; Fri, 20 Jan 2023 07:58:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674230327; cv=none; d=google.com; s=arc-20160816; b=T4+pH3DC3Lu+KwiaqfHPxk8rPKSpE/xcOx4oVS8s0HN+O2Q2IB+Hy4EcBkwbK0aJtn Ul7wxi8RaRZSypVu2XvTsQeCmalR+/8KfhCMT4XluEAK+Nhw/FoCpEONpElcoHYX2kqi r3D6zYy0qf9O9IfllXMHDh8PMm3xOvnXABlHyF1XQ9SNaRMUw/fmZmpLC5mVTm4Xx44y 42MlWvYAqsSrqOW+NfPWbILqXwtdzLl1DHZI4vID9Voucwb5wfCGB1tD/rveCrHMs8Vd GvAoPN2h7whgNrHsiGtlImXgwPyX82WZT6hY6cgrcqZIgUnoOIQL4pDTf83rXNTRQU1O MBqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/BOZzGkzYofIjRH5wSmH3Wx6pmMCQFDR6yFiN3AmUA4=; b=y50feG2l06IfZtuJI1c46qeAieetXnh1ofItCnM+eK4aYJchbdeHixK8yIIb7wmFpT 0iA4sq1sG/pGcVaLVmlotFVqi5Rl+YFpnvs20sEA8NiCOFExSIWi3IykQjMhZod/X9qq KqFXffh0xfa7RKZUPj0E2mi8kXT6MyOGBtF7qBOaC42Rn8WsKYhGxlI63Z9SftQtfd4X A4y5NmFsuWhYDof4dLgneJSnj4tvzIUYt1R26O7RGOvhUOOj6lLRbTsIqfExnYWj+LvF xojXMDDotG/t2SOMVmXYXyuZc3t6NwpaVGal1/HlcPvo/lz2UJCkSoXOhBEbwh6Tp8ok c//Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="I4/TwKIq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd11-20020a1709069b8b00b008775fc7095esi9247256ejc.899.2023.01.20.07.58.23; Fri, 20 Jan 2023 07:58:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="I4/TwKIq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231635AbjATPyh (ORCPT <rfc822;forouhar.m.panah2001@gmail.com> + 99 others); Fri, 20 Jan 2023 10:54:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231614AbjATPyZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 20 Jan 2023 10:54:25 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8999EDF955 for <linux-kernel@vger.kernel.org>; Fri, 20 Jan 2023 07:54:20 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id f25-20020a1c6a19000000b003da221fbf48so4034487wmc.1 for <linux-kernel@vger.kernel.org>; Fri, 20 Jan 2023 07:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/BOZzGkzYofIjRH5wSmH3Wx6pmMCQFDR6yFiN3AmUA4=; b=I4/TwKIqbnFoGjxUHbgYa6l+mCPpUztsUkDpqnKlHjuxkrEi7CK2V3B+F+xkF9wzTG Z6TGnN66HpL6VvrOzR8GKOA/QICVFbtxS6k3/68wdjX97mg3OKUkSKWPFPFr84tRR1hR UBbPXHY5uqq/bJT4ZULTvTHnUmNeh+kKdEwvfeadEKTOt7rkAs6MSYzztaigZYM5eyC0 fsQjbGY0ApKFQ9n60SDQXcnNuiLEKtDx9gmajbPJX8ogxOmqb8Qu9rKFIe5lbWY0oS36 Y/xKbNSPEqoy/PDW4j98QmEoLsd6JOAPrvlyg0qO/60xwb4j8J4GqM7rRfDh5KOX850p gx9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/BOZzGkzYofIjRH5wSmH3Wx6pmMCQFDR6yFiN3AmUA4=; b=z0glY9aW97W1xs4z++I3nyUlxh1OgN4TYnvzpgJZAP7LFEuk0Z14ciWjj1fOXPY3+h t7Vq5hO2uc5dAAxJqtP+jfej76/3VyHT9MNFAoMe0DJQwo7rTe0WeAss8z2+eFY1Nowv k/+tL9/qO4JG041B3nGhC+elxmexZuu+iTIghEg/q/bmhp/lE7/P3UzHwdAP4rRbDMGk i0yea9ZaK6XZKe14ZTaP7S9Jf66qODxecpH7dmuQkrQPk17Rg9oGe2bMYgMVVjECglFS v1WT/HDKzEL9MPjFJ83iotXpeqntDXUxM4SNN9KlXkY6y2l3ljynxGbioaaS8X+E5uXa GFXg== X-Gm-Message-State: AFqh2krjsVW+xq2KS0MVFZ0z3EvdyNZVMjzbp83GeBSeeYO4EpNb8xbc DduyhlAoLWEoGa0LBCNunf1GZg== X-Received: by 2002:a05:600c:1d8a:b0:3db:f0a:cfa1 with SMTP id p10-20020a05600c1d8a00b003db0f0acfa1mr11317502wms.9.1674230060091; Fri, 20 Jan 2023 07:54:20 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id n42-20020a05600c3baa00b003d96efd09b7sm3349596wms.19.2023.01.20.07.54.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 07:54:19 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com>, Inki Dae <inki.dae@samsung.com>, Kyungmin Park <kyungmin.park@samsung.com>, Kukjin Kim <kgene@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: replicant@osuosl.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Martin_J=C3=BCcker?= <martin.juecker@gmail.com>, Henrik Grimler <henrik@grimler.se>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [RFT 05/11] ARM: dts: exynos: add ports in HDMI bridge in Exynos4412 Midas Date: Fri, 20 Jan 2023 16:53:58 +0100 Message-Id: <20230120155404.323386-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230120155404.323386-1-krzysztof.kozlowski@linaro.org> References: <20230120155404.323386-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755557739142144482?= X-GMAIL-MSGID: =?utf-8?q?1755557739142144482?= |
Series |
ARM: dts: exynos: DT schema fixes
|
|
Commit Message
Krzysztof Kozlowski
Jan. 20, 2023, 3:53 p.m. UTC
The SII9234 HDMI bridge expects ports property:
exynos4412-i9305.dtb: hdmi-bridge@39: 'ports' is a required property
exynos4412-i9305.dtb: hdmi-bridge@39: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm/boot/dts/exynos4412-midas.dtsi | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
Comments
Hi, I see you have already merged this, but FWIW HDMI works as well as before on exynos4412-i9300, so: Tested-by: Henrik Grimler <henrik@grimler.se> Longer explanation: HDMI output only works on i9300 if MHL cable is attached before device boots, so probably bootloader sets up some settings that the sii9234 driver does not handle (correctly) if cable is hot plugged. Best regards, Henrik Grimler On Fri, Jan 20, 2023 at 04:53:58PM +0100, Krzysztof Kozlowski wrote: > The SII9234 HDMI bridge expects ports property: > > exynos4412-i9305.dtb: hdmi-bridge@39: 'ports' is a required property > exynos4412-i9305.dtb: hdmi-bridge@39: 'port' does not match any of the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm/boot/dts/exynos4412-midas.dtsi | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi > index 8e1c19a8ad06..a626d33d1330 100644 > --- a/arch/arm/boot/dts/exynos4412-midas.dtsi > +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi > @@ -273,9 +273,16 @@ sii9234: hdmi-bridge@39 { > interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; > reg = <0x39>; > > - port { > - mhl_to_hdmi: endpoint { > - remote-endpoint = <&hdmi_to_mhl>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + mhl_to_hdmi: endpoint { > + remote-endpoint = <&hdmi_to_mhl>; > + }; > }; > }; > }; > -- > 2.34.1 >
On 23/01/2023 16:34, Henrik Grimler wrote: > Hi, > > I see you have already merged this, but FWIW HDMI works as well as > before on exynos4412-i9300, so: > > Tested-by: Henrik Grimler <henrik@grimler.se> Great, thanks! I'll add your tag. > > Longer explanation: HDMI output only works on i9300 if MHL cable is > attached before device boots, so probably bootloader sets up some > settings that the sii9234 driver does not handle (correctly) if cable > is hot plugged. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi index 8e1c19a8ad06..a626d33d1330 100644 --- a/arch/arm/boot/dts/exynos4412-midas.dtsi +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi @@ -273,9 +273,16 @@ sii9234: hdmi-bridge@39 { interrupts = <5 IRQ_TYPE_LEVEL_HIGH>; reg = <0x39>; - port { - mhl_to_hdmi: endpoint { - remote-endpoint = <&hdmi_to_mhl>; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + mhl_to_hdmi: endpoint { + remote-endpoint = <&hdmi_to_mhl>; + }; }; }; };