mbox series

[GIT,PULL] gfs2 writepage fix

Message ID 20230122090115.1563753-1-agruenba@redhat.com
State New
Headers
Series [GIT,PULL] gfs2 writepage fix |

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.2-rc4-fix

Message

Andreas Gruenbacher Jan. 22, 2023, 9:01 a.m. UTC 
  From: Linus Torvalds <torvalds@linux-foundation.org>

Hi Linus,

please consider pulling the following gfs2 fix.

Thank you very much,
Andreas

The following changes since commit 5dc4c995db9eb45f6373a956eb1f69460e69e6d4:

  Linux 6.2-rc4 (2023-01-15 09:22:43 -0600)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.2-rc4-fix

for you to fetch changes up to 95ecbd0f162fc06ef4c4045a66f653f47b62a2d3:

  Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one" (2023-01-22 09:46:14 +0100)

----------------------------------------------------------------
gfs2 writepage fix

- Fix a regression introduced by commit "gfs2: stop using
  generic_writepages in gfs2_ail1_start_one".

----------------------------------------------------------------
Andreas Gruenbacher (1):
      Revert "gfs2: stop using generic_writepages in gfs2_ail1_start_one"

 fs/gfs2/log.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Linus Torvalds Jan. 22, 2023, 8:05 p.m. UTC | #1 
On Sun, Jan 22, 2023 at 1:01 AM Andreas Gruenbacher <agruenba@redhat.com> wrote:
>
> gfs2 writepage fix
>
> - Fix a regression introduced by commit "gfs2: stop using
>   generic_writepages in gfs2_ail1_start_one".

Hmm. I'm adding a few more people and linux-fsdevel to the reply,
because we had a number of filesystems remove writepages use lately,
including some that did it as a fix after the merge window.

Everybody involved seemed to claim it was just a no-brainer
switch-over, and I just took that on faith. Now it looks like that
wasn't true at least for gfs2 due to different semantics.

Maybe the gfs2 issue is purely because of how gfs2 did the conversion
(generic_writepages -> filemap_fdatawrite_wbc), but let's make people
look at their own cases.

                 Linus
pr-tracker-bot@kernel.org Jan. 22, 2023, 8:20 p.m. UTC | #2 
The pull request you sent on Sun, 22 Jan 2023 10:01:15 +0100:

> git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git tags/gfs2-v6.2-rc4-fix

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/3c006ad74d68be45ee36ca68fd9c053974fb6b0f

Thank you!
Jan Kara Jan. 23, 2023, 10:05 a.m. UTC | #3 
On Sun 22-01-23 12:05:53, Linus Torvalds wrote:
> On Sun, Jan 22, 2023 at 1:01 AM Andreas Gruenbacher <agruenba@redhat.com> wrote:
> >
> > gfs2 writepage fix
> >
> > - Fix a regression introduced by commit "gfs2: stop using
> >   generic_writepages in gfs2_ail1_start_one".
> 
> Hmm. I'm adding a few more people and linux-fsdevel to the reply,
> because we had a number of filesystems remove writepages use lately,
> including some that did it as a fix after the merge window.
> 
> Everybody involved seemed to claim it was just a no-brainer
> switch-over, and I just took that on faith. Now it looks like that
> wasn't true at least for gfs2 due to different semantics.
> 
> Maybe the gfs2 issue is purely because of how gfs2 did the conversion
> (generic_writepages -> filemap_fdatawrite_wbc), but let's make people
> look at their own cases.

Thanks for the heads up. So we had kind of a similar issue for ext4 but it
got caught by Ted during his regression runs so we've basically done what
GFS2 is doing for the merge window and now there's patchset pending to
convert the data=journal path as well because as Andreas states in his
changelog of the revert that's a bit more tricky. But at least for ext4
the conversion of data=journal path resulted in much cleaner and shorter
code.

								Honza
Theodore Ts'o Jan. 23, 2023, 4:03 p.m. UTC | #4 
On Mon, Jan 23, 2023 at 11:05:56AM +0100, Jan Kara wrote:
> Thanks for the heads up. So we had kind of a similar issue for ext4 but it
> got caught by Ted during his regression runs so we've basically done what
> GFS2 is doing for the merge window and now there's patchset pending to
> convert the data=journal path as well because as Andreas states in his
> changelog of the revert that's a bit more tricky. But at least for ext4
> the conversion of data=journal path resulted in much cleaner and shorter
> code.

https://thunk.org/tytso/images/firestarter-fs-development-without-testing.jpg

:-)

							- Ted