diff mbox series

agp/amd64: Fix full name of the GPL

Message ID 20230122181632.54267-1-didi.debian@cknow.org
State New
Headers
Series agp/amd64: Fix full name of the GPL |

Commit Message

Diederik de Haas Jan. 22, 2023, 6:16 p.m. UTC 
  Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 drivers/char/agp/amd64-agp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christophe JAILLET Jan. 22, 2023, 7:49 p.m. UTC | #1 
Le 22/01/2023 à 19:16, Diederik de Haas a écrit :
> Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
> ---
>   drivers/char/agp/amd64-agp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
> index ce8651436609..3020fd92fd00 100644
> --- a/drivers/char/agp/amd64-agp.c
> +++ b/drivers/char/agp/amd64-agp.c
> @@ -1,7 +1,7 @@
>   // SPDX-License-Identifier: GPL-2.0-only
>   /*
>    * Copyright 2001-2003 SuSE Labs.
> - * Distributed under the GNU public license, v2.
> + * Distributed under the GNU General Public License, v2.
>    *
>    * This is a GART driver for the AMD Opteron/Athlon64 on-CPU northbridge.
>    * It also includes support for the AMD 8151 AGP bridge,

Hi,

maybe the line can just be removed.
There is already a SPDX-License-Identifier above.

CJ
Diederik de Haas Jan. 23, 2023, 2:35 p.m. UTC | #2 
On Sunday, 22 January 2023 20:49:22 CET Christophe JAILLET wrote:
> Le 22/01/2023 à 19:16, Diederik de Haas a écrit :
> > Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
> > ---
> > 
> >   drivers/char/agp/amd64-agp.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
> > index ce8651436609..3020fd92fd00 100644
> > --- a/drivers/char/agp/amd64-agp.c
> > +++ b/drivers/char/agp/amd64-agp.c
> > @@ -1,7 +1,7 @@
> > 
> >   // SPDX-License-Identifier: GPL-2.0-only
> >   /*
> >   
> >    * Copyright 2001-2003 SuSE Labs.
> > 
> > - * Distributed under the GNU public license, v2.
> > + * Distributed under the GNU General Public License, v2.
> > 
> >    *
> >    * This is a GART driver for the AMD Opteron/Athlon64 on-CPU
> >    northbridge.
> >    * It also includes support for the AMD 8151 AGP bridge,
> 
> maybe the line can just be removed.
> There is already a SPDX-License-Identifier above.

Hi,

That does sound reasonable, but I'm now seeing it as a legal issue [1] and no
longer as a spelling one. Strictly speaking it seems there is a discrepancy
between the SPDX identifier and the 'full' license statement.
While it may be reasonable to *assume* the "GNU General Public License, v2"
was meant, when it comes to license/legal stuff, I think that does not suffice.

So I'd like to retract my patch submission and want to leave it up to people
who are in a position to resolve this issue, if that needs to be done.

Apologies for the noise.

Diederik

[1] https://lore.kernel.org/lkml/ad99d227-ce82-319b-6323-b70ac009d0e7@roeck-us.net/
diff mbox series

Patch

diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index ce8651436609..3020fd92fd00 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -1,7 +1,7 @@ 
 // SPDX-License-Identifier: GPL-2.0-only
 /*
  * Copyright 2001-2003 SuSE Labs.
- * Distributed under the GNU public license, v2.
+ * Distributed under the GNU General Public License, v2.
  *
  * This is a GART driver for the AMD Opteron/Athlon64 on-CPU northbridge.
  * It also includes support for the AMD 8151 AGP bridge,