Message ID | 563ff850-9966-b790-96d4-bb0557e1152c@mkarcher.dialup.fu-berlin.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1222150wrn; Sun, 22 Jan 2023 08:37:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXtK0/q+kMv8T0m7AF+rhw+4v1QGjszLjWbxEXDEiUKK8zDgP8tJaYFSLFzkpDnC17evvDAe X-Received: by 2002:a17:906:368b:b0:877:5938:6f6d with SMTP id a11-20020a170906368b00b0087759386f6dmr18696310ejc.56.1674405473795; Sun, 22 Jan 2023 08:37:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674405473; cv=none; d=google.com; s=arc-20160816; b=HZxV81992UQXuUM3TM9OwfXryhScG9LoDvUYtA2JHnDJcPkF7H3jahlbWLCGdhzjcW iGuE7LrAJvRja6X8bm1ew5pk2URfT7HOKYbbfqo9q+sySpYoT/QTE+ivcWO5RLL0WwTL TG8F9UHPRUuaTzySRGbcu0bEwdYN7ef2ToWJlxRLH3ydUcAnWnfpUy8qcB2ttCHjuweP Q3Qbde1VRYXptfQUQZXcKPmBlvyl8lQox8CPlNy4ZS4tdKgfp79VDA6RyL6+8ufW4z0z XlysGOeQQZW1+lYIlmueLZ4C4WZwwaqudzI6ses0qqyD5I9LR51eif8DC/GLvrlHPBUO or4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:subject:from:to :user-agent:mime-version:date:message-id; bh=osX2Xd5T7dh2EfgJvKa/TgXP/aZAaBDNQtrOvpNrrVE=; b=OCft/FfIcgoz7CLCKG9YD+eGLD64jF/urby6DJVXbnaq36HyBiZ1fToIo7+6mLLSGN 2wmZdZ/hsd0JSU1Xx3A+oGvdhr4jc1TnEeS0UMJsKRqc5TCXMVP49k9imhOT2aAY28uZ mr7KY18Dec1W5Tal3L+yuMQnEqJKT3fhwts8Cn8oeGE+9pwUG1Qn+DWjKuGCTGNN3SMZ 9WD0iZYCbcPppZSpzLC5CZElrCPt+JCQ8PONkeX1eX9ScEIOwm6Z3vD45ICZiR/h1n3j WdtrRb62FlyfT3kKyXBJbSketBwIAehwBE7kb1AIDn/V5dKma9VVuOM0Dx27lbl1QkTu KpVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q26-20020a170906b29a00b0087532d0249dsi13397974ejz.77.2023.01.22.08.37.30; Sun, 22 Jan 2023 08:37:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230365AbjAVQ1S (ORCPT <rfc822;forouhar.linux@gmail.com> + 99 others); Sun, 22 Jan 2023 11:27:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbjAVQ1R (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 22 Jan 2023 11:27:17 -0500 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F21D21A1D; Sun, 22 Jan 2023 08:27:16 -0800 (PST) Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.95) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from <mkarcher@zedat.fu-berlin.de>) id 1pJdBZ-0007tz-05; Sun, 22 Jan 2023 17:27:13 +0100 Received: from pd9f631ca.dip0.t-ipconnect.de ([217.246.49.202] helo=[192.168.144.87]) by inpost2.zedat.fu-berlin.de (Exim 4.95) with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (envelope-from <kernel@mkarcher.dialup.fu-berlin.de>) id 1pJdBY-000Fm8-MV; Sun, 22 Jan 2023 17:27:12 +0100 Message-ID: <563ff850-9966-b790-96d4-bb0557e1152c@mkarcher.dialup.fu-berlin.de> Date: Sun, 22 Jan 2023 17:27:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 To: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Segher Boessenkool <segher@kernel.crashing.org>, Rich Felker <dalias@libc.org>, Yoshinori Sato <ysato@users.sourceforge.jp>, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> From: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de> Subject: [PATCH v2 1/1] arch/sh: avoid spurious sizeof-pointer-div warning Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Original-Sender: kernel@mkarcher.dialup.fu-berlin.de X-Originating-IP: 217.246.49.202 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755741393871348323?= X-GMAIL-MSGID: =?utf-8?q?1755741393871348323?= |
Series |
[v2,1/1] arch/sh: avoid spurious sizeof-pointer-div warning
|
|
Commit Message
Michael Karcher
Jan. 22, 2023, 4:27 p.m. UTC
Gcc warns about the pattern sizeof(void*)/sizeof(void), as it looks like
the abuse of a pattern to calculate the array size. This pattern appears
in the unevaluated part of the ternary operator in _INTC_ARRAY if the
parameter is NULL.
The replacement uses an alternate approach to return 0 in case of NULL
which does not generate the pattern sizeof(void*)/sizeof(void), but still
emits the warning if _INTC_ARRAY is called with a nonarray parameter.
This patch is required for successful compilation with -Werror enabled.
The idea to use _Generic for type distinction is taken from Comment #7
in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108483 by Jakub Jelinek
Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
---
History:
v2:
- improve title and remove mostly redundant first sentence of the
description
- adjust formatting of the _Generic construction
Comments
Hi, On 1/22/23 08:27, Michael Karcher wrote: > Gcc warns about the pattern sizeof(void*)/sizeof(void), as it looks like > the abuse of a pattern to calculate the array size. This pattern appears > in the unevaluated part of the ternary operator in _INTC_ARRAY if the > parameter is NULL. > > The replacement uses an alternate approach to return 0 in case of NULL > which does not generate the pattern sizeof(void*)/sizeof(void), but still > emits the warning if _INTC_ARRAY is called with a nonarray parameter. > > This patch is required for successful compilation with -Werror enabled. > > The idea to use _Generic for type distinction is taken from Comment #7 > in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108483 by Jakub Jelinek > > Signed-off-by: Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de> There are lots of non-ASCII characters in the new patch. This is one example from over 20,000 lines of warnings: ../include/linux/sh_intc.h:102:27: error: stray '\302' in program 102 | <U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0> default:<U+00A0><U+00A0><U+00A0><U+00A0><U+00A0><U+00A0> sizeof(*a))) | ^~~~~~~~ With all of those changed to tabs or spaces: Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > History: > v2: > - improve title and remove mostly redundant first sentence of the > description > - adjust formatting of the _Generic construction > > diff --git a/include/linux/sh_intc.h b/include/linux/sh_intc.h > index c255273b0281..98d1da0d8e36 100644 > --- a/include/linux/sh_intc.h > +++ b/include/linux/sh_intc.h > @@ -97,7 +97,9 @@ struct intc_hw_desc { > unsigned int nr_subgroups; > }; > > -#define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) > +#define _INTC_ARRAY(a) a, sizeof(a) / (_Generic(a, \ > + typeof(NULL): (size_t)-1, \ > + default: sizeof(*a))) > > #define INTC_HW_DESC(vectors, groups, mask_regs, \ > prio_regs, sense_regs, ack_regs) \ >
diff --git a/include/linux/sh_intc.h b/include/linux/sh_intc.h index c255273b0281..98d1da0d8e36 100644 --- a/include/linux/sh_intc.h +++ b/include/linux/sh_intc.h @@ -97,7 +97,9 @@ struct intc_hw_desc { unsigned int nr_subgroups; }; -#define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) +#define _INTC_ARRAY(a) a, sizeof(a) / (_Generic(a, \ + typeof(NULL): (size_t)-1, \ + default: sizeof(*a))) #define INTC_HW_DESC(vectors, groups, mask_regs, \ prio_regs, sense_regs, ack_regs) \