Message ID | 20230119140453.3942340-10-abel.vesa@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp346075wrn; Thu, 19 Jan 2023 06:07:09 -0800 (PST) X-Google-Smtp-Source: AMrXdXutXWH+gWRvZa7VMRqsu7wsESH92RZ2I0Jyk7pYTErOeWz5gGomppmkq15QP0UK6wChfKYE X-Received: by 2002:a17:902:a706:b0:194:87fe:c8f9 with SMTP id w6-20020a170902a70600b0019487fec8f9mr11238004plq.38.1674137228734; Thu, 19 Jan 2023 06:07:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674137228; cv=none; d=google.com; s=arc-20160816; b=uYaDGRR5MCJ74PfSjXPycDmMmQHegjloUHi5xun4CDsMjAfRHeOI21URO1QAx2/7Vo hzxT4claS3+GMYocdwkqE2gED9XXKqwrEI+lUeurW1iXXaxSy1BPF8QwEeng3zVHG+Ux TltB/un+p6zaLHqC0Y48TBUVwl1tgRXxhnzvjIhbrycJOZdf0sLcXa5q4LbNziCBhcQ+ 26rV8oXiZmZIK25R6Ci+Xn+M0aPYq1jPl9xvODBTmC46ggZW4E7IPrgyaogLuslRzUUI cYvb11AdOGgPIXilqN0k6rwyQPWkMRO/duvjFQptTQf+/ftaN0d9AG1bco4Dl9uXh2+3 7/jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rmxDEmjJAIZF6pBIcHDYYCg28aDDwgUhbVh1uCP6umk=; b=eU8bW+coz7UqkC6QBLEUEy4sP3OftcyaBr+pUFTKovRxp4hDKa9mXBp7ZmBozURnEv CJzhglEnU5VC8fCGigOtvQT+EESI3oEWMwNO4aV2mqYuEYsa6wzLrI+L0HrTjZZpNxe6 MPqj/wzDXsihgDKBuFXEAWeZuJrW/K1r59+5M4t8SdzbRK7OF9NOWoGSaubLFzXYi1PB 7cLqWVNw6trAaT+hhv/SWaQqgP2slRpfl56I92CSDaCz6ykZmHxO/LqqSUL6Ffqe1Mm7 P+G0pSVeG2q66oFXtn7ceOlrLrl3f3Z0+8Aznv0+Wdva0XpdYm4fFhbwO1QmkC30H1Ml tMrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ijj1Sbml; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i5-20020a63e445000000b004792b08adaasi39470153pgk.418.2023.01.19.06.06.55; Thu, 19 Jan 2023 06:07:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ijj1Sbml; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231561AbjASOG3 (ORCPT <rfc822;pfffrao@gmail.com> + 99 others); Thu, 19 Jan 2023 09:06:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231490AbjASOFw (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 19 Jan 2023 09:05:52 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 686AD80888 for <linux-kernel@vger.kernel.org>; Thu, 19 Jan 2023 06:05:23 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso1337715wmq.5 for <linux-kernel@vger.kernel.org>; Thu, 19 Jan 2023 06:05:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rmxDEmjJAIZF6pBIcHDYYCg28aDDwgUhbVh1uCP6umk=; b=ijj1Sbml5IM/ADUkkgnEpuWAxJxQdH8gs5DcECvy0wOc6ZyyHF9E1qt+kClZERSR1I 1tFs5yeziEVIG0YXwpVxRZwhjctqmXUXNSZzRrHvliOdrfFVex5wq6tIPi+1FhaLCmY2 pQNTojW31NEbzA2SEaXoJvWFsP8apB6lF4dYxMkMNY2L4dMTyfvJBmkY8I1BdJtjUJe9 gbMV81bvemhMsjTqBEOQJUo6Ta13+88ubzvbeFhsykw4/wrERB+JldyeigHqRavbS8e+ 8ZdrkvYk83H+/BYl0I5sRb+xjYUE5wT+n92/EigxuZ0vhmlcvDLI3BT/dI6GtPa4FBgl REpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rmxDEmjJAIZF6pBIcHDYYCg28aDDwgUhbVh1uCP6umk=; b=jkiOCWfJEqYob2HjGv09h0Cq7xroX/OW1Wl7+vhDf8rvloX+8YhKgaO5ydp6VHWsqC 99KuJTIRMQ1dkpvHjINxsSSWanmofhBnOZIUgqO9N5w8luNtF8+s9K2lsAgF4zEzkEru N4a5yVhsrEoGnP0bUPaGoxL1ZypSJeh7PJ9KMqoeW6VxH37A7VmCBDH2Yk9w9EN7AvuF 74GZyStMpo3svfX3i4bVteakK8nRQCY/8hyn5HT95Sn3WnDXasSqsAfu024IQwGzAVsF LCfl5OZtmpFDjYzO66aAZsyehC7r6XBiK4mWpFETz4xH/7TEmqkzt+5OvwQ5sxwNvGIm RWLw== X-Gm-Message-State: AFqh2kqGxX6h46IKiApWb9hTlsZlintGqiPWn4Q6PZ90jk9Zn55NL/Ed 9taCWMo5b6DxFBrvx2Ss+Cteag== X-Received: by 2002:a05:600c:4d91:b0:3da:fb96:53d with SMTP id v17-20020a05600c4d9100b003dafb96053dmr10097926wmp.4.1674137121358; Thu, 19 Jan 2023 06:05:21 -0800 (PST) Received: from hackbox.lan ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id m10-20020a05600c4f4a00b003d96efd09b7sm5263883wmq.19.2023.01.19.06.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 06:05:20 -0800 (PST) From: Abel Vesa <abel.vesa@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Rob Herring <robh@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>, Bjorn Helgaas <bhelgaas@google.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Lorenzo Pieralisi <lpieralisi@kernel.org>, "vkoul@kernel.org" <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@kernel.org>, Manivannan Sadhasivam <mani@kernel.org> Cc: linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: [PATCH v4 09/12] dt-bindings: PCI: qcom: Add SM8550 compatible Date: Thu, 19 Jan 2023 16:04:50 +0200 Message-Id: <20230119140453.3942340-10-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230119140453.3942340-1-abel.vesa@linaro.org> References: <20230119140453.3942340-1-abel.vesa@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755460118331858588?= X-GMAIL-MSGID: =?utf-8?q?1755460118331858588?= |
Series |
sm8550: Add PCIe HC and PHY support
|
|
Commit Message
Abel Vesa
Jan. 19, 2023, 2:04 p.m. UTC
Add the SM8550 platform to the binding.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
The v3 of this patchset is:
https://lore.kernel.org/all/20230119112453.3393911-1-abel.vesa@linaro.org/
Changes since v3:
* renamed noc_aggr to noc_aggr_4, as found in the driver
Changes since v2:
* dropped the pipe from clock-names
* removed the pcie instance number from aggre clock-names comment
* renamed aggre clock-names to noc_aggr
* dropped the _pcie infix from cnoc_pcie_sf_axi
* renamed pcie_1_link_down_reset to simply link_down
* added enable-gpios back, since pcie1 node will use it
Changes since v1:
* Switched to single compatible for both PCIes (qcom,pcie-sm8550)
* dropped enable-gpios property
* dropped interconnects related properties, the power-domains
* properties
and resets related properties the sm8550 specific allOf:if:then
* dropped pipe_mux, phy_pipe and ref clocks from the sm8550 specific
allOf:if:then clock-names array and decreased the minItems and
maxItems for clocks property accordingly
* added "minItems: 1" to interconnects, since sm8550 pcie uses just
* one,
same for interconnect-names
.../devicetree/bindings/pci/qcom,pcie.yaml | 44 +++++++++++++++++++
1 file changed, 44 insertions(+)
Comments
On 19/01/2023 15:04, Abel Vesa wrote: > Add the SM8550 platform to the binding. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > > The v3 of this patchset is: > https://lore.kernel.org/all/20230119112453.3393911-1-abel.vesa@linaro.org/ > > Changes since v3: > * renamed noc_aggr to noc_aggr_4, as found in the driver > > Changes since v2: > * dropped the pipe from clock-names > * removed the pcie instance number from aggre clock-names comment > * renamed aggre clock-names to noc_aggr > * dropped the _pcie infix from cnoc_pcie_sf_axi > * renamed pcie_1_link_down_reset to simply link_down > * added enable-gpios back, since pcie1 node will use it > > Changes since v1: > * Switched to single compatible for both PCIes (qcom,pcie-sm8550) > * dropped enable-gpios property > * dropped interconnects related properties, the power-domains > * properties > and resets related properties the sm8550 specific allOf:if:then > * dropped pipe_mux, phy_pipe and ref clocks from the sm8550 specific > allOf:if:then clock-names array and decreased the minItems and > maxItems for clocks property accordingly > * added "minItems: 1" to interconnects, since sm8550 pcie uses just > * one, > same for interconnect-names > > > .../devicetree/bindings/pci/qcom,pcie.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index a5859bb3dc28..58f926666332 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -34,6 +34,7 @@ properties: > - qcom,pcie-sm8250 > - qcom,pcie-sm8450-pcie0 > - qcom,pcie-sm8450-pcie1 > + - qcom,pcie-sm8550 > - qcom,pcie-ipq6018 > > reg: > @@ -65,9 +66,11 @@ properties: > dma-coherent: true > > interconnects: > + minItems: 1 > maxItems: 2 > I don't see my concerns from v3 answered. This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof
On 23-01-22 15:10:59, Krzysztof Kozlowski wrote: > On 19/01/2023 15:04, Abel Vesa wrote: > > Add the SM8550 platform to the binding. > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > > > The v3 of this patchset is: > > https://lore.kernel.org/all/20230119112453.3393911-1-abel.vesa@linaro.org/ > > > > Changes since v3: > > * renamed noc_aggr to noc_aggr_4, as found in the driver > > > > Changes since v2: > > * dropped the pipe from clock-names > > * removed the pcie instance number from aggre clock-names comment > > * renamed aggre clock-names to noc_aggr > > * dropped the _pcie infix from cnoc_pcie_sf_axi > > * renamed pcie_1_link_down_reset to simply link_down > > * added enable-gpios back, since pcie1 node will use it > > > > Changes since v1: > > * Switched to single compatible for both PCIes (qcom,pcie-sm8550) > > * dropped enable-gpios property > > * dropped interconnects related properties, the power-domains > > * properties > > and resets related properties the sm8550 specific allOf:if:then > > * dropped pipe_mux, phy_pipe and ref clocks from the sm8550 specific > > allOf:if:then clock-names array and decreased the minItems and > > maxItems for clocks property accordingly > > * added "minItems: 1" to interconnects, since sm8550 pcie uses just > > * one, > > same for interconnect-names > > > > > > .../devicetree/bindings/pci/qcom,pcie.yaml | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > index a5859bb3dc28..58f926666332 100644 > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > @@ -34,6 +34,7 @@ properties: > > - qcom,pcie-sm8250 > > - qcom,pcie-sm8450-pcie0 > > - qcom,pcie-sm8450-pcie1 > > + - qcom,pcie-sm8550 > > - qcom,pcie-ipq6018 > > > > reg: > > @@ -65,9 +66,11 @@ properties: > > dma-coherent: true > > > > interconnects: > > + minItems: 1 > > maxItems: 2 > > > > I don't see my concerns from v3 answered. Check the dates for v4 and your reply to v3. v4 was sent a day before you sent your v3 comments. :) > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. Will address your comments in next version. > > Thank you. > > Best regards, > Krzysztof >
On 23/01/2023 11:44, Abel Vesa wrote: > On 23-01-22 15:10:59, Krzysztof Kozlowski wrote: >> On 19/01/2023 15:04, Abel Vesa wrote: >>> Add the SM8550 platform to the binding. >>> >>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >>> --- >>> >>> The v3 of this patchset is: >>> https://lore.kernel.org/all/20230119112453.3393911-1-abel.vesa@linaro.org/ >>> >>> Changes since v3: >>> * renamed noc_aggr to noc_aggr_4, as found in the driver >>> >>> Changes since v2: >>> * dropped the pipe from clock-names >>> * removed the pcie instance number from aggre clock-names comment >>> * renamed aggre clock-names to noc_aggr >>> * dropped the _pcie infix from cnoc_pcie_sf_axi >>> * renamed pcie_1_link_down_reset to simply link_down >>> * added enable-gpios back, since pcie1 node will use it >>> >>> Changes since v1: >>> * Switched to single compatible for both PCIes (qcom,pcie-sm8550) >>> * dropped enable-gpios property >>> * dropped interconnects related properties, the power-domains >>> * properties >>> and resets related properties the sm8550 specific allOf:if:then >>> * dropped pipe_mux, phy_pipe and ref clocks from the sm8550 specific >>> allOf:if:then clock-names array and decreased the minItems and >>> maxItems for clocks property accordingly >>> * added "minItems: 1" to interconnects, since sm8550 pcie uses just >>> * one, >>> same for interconnect-names >>> >>> >>> .../devicetree/bindings/pci/qcom,pcie.yaml | 44 +++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>> index a5859bb3dc28..58f926666332 100644 >>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>> @@ -34,6 +34,7 @@ properties: >>> - qcom,pcie-sm8250 >>> - qcom,pcie-sm8450-pcie0 >>> - qcom,pcie-sm8450-pcie1 >>> + - qcom,pcie-sm8550 >>> - qcom,pcie-ipq6018 >>> >>> reg: >>> @@ -65,9 +66,11 @@ properties: >>> dma-coherent: true >>> >>> interconnects: >>> + minItems: 1 >>> maxItems: 2 >>> >> >> I don't see my concerns from v3 answered. > > Check the dates for v4 and your reply to v3. > > v4 was sent a day before you sent your v3 comments. :) > >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all >> requested changes or keep discussing them. > > Will address your comments in next version. Ah, then ok :) Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index a5859bb3dc28..58f926666332 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -34,6 +34,7 @@ properties: - qcom,pcie-sm8250 - qcom,pcie-sm8450-pcie0 - qcom,pcie-sm8450-pcie1 + - qcom,pcie-sm8550 - qcom,pcie-ipq6018 reg: @@ -65,9 +66,11 @@ properties: dma-coherent: true interconnects: + minItems: 1 maxItems: 2 interconnect-names: + minItems: 1 items: - const: pcie-mem - const: cpu-pcie @@ -102,6 +105,10 @@ properties: power-domains: maxItems: 1 + enable-gpios: + description: GPIO controlled connection to ENABLE# signal + maxItems: 1 + perst-gpios: description: GPIO controlled connection to PERST# signal maxItems: 1 @@ -197,6 +204,7 @@ allOf: - qcom,pcie-sm8250 - qcom,pcie-sm8450-pcie0 - qcom,pcie-sm8450-pcie1 + - qcom,pcie-sm8550 then: properties: reg: @@ -611,6 +619,41 @@ allOf: items: - const: pci # PCIe core reset + - if: + properties: + compatible: + contains: + enum: + - qcom,pcie-sm8550 + then: + properties: + clocks: + minItems: 7 + maxItems: 8 + clock-names: + minItems: 7 + items: + - const: aux # Auxiliary clock + - const: cfg # Configuration clock + - const: bus_master # Master AXI clock + - const: bus_slave # Slave AXI clock + - const: slave_q2a # Slave Q2A clock + - const: ddrss_sf_tbu # PCIe SF TBU clock + - const: noc_aggr_4 # Aggre NoC PCIe AXI clock + - const: cnoc_sf_axi # Config NoC PCIe1 AXI clock + iommus: + maxItems: 1 + iommu-map: + maxItems: 2 + resets: + minItems: 1 + maxItems: 2 + reset-names: + minItems: 1 + items: + - const: pci # PCIe core reset + - const: link_down # PCIe link down reset + - if: properties: compatible: @@ -694,6 +737,7 @@ allOf: - qcom,pcie-sm8250 - qcom,pcie-sm8450-pcie0 - qcom,pcie-sm8450-pcie1 + - qcom,pcie-sm8550 then: oneOf: - properties: