[v7,1/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight
Commit Message
Add Kinetic KTZ8866 backlight binding documentation.
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
Changes in v2:
- Remove "items" between "compatible" and "const: kinetic,ktz8866".
- Change "additionalProperties" to "unevaluatedProperties".
Changes in v3:
- Add Krzysztof's R-b.
Changes in v4:
- Drop Krzysztof's R-b.
- Add some new properties.
Changes in v5:
- Add missing enum under property description.
- Rename uncorrect properties.
Changes in v6:
- Correct wrong property suffix and description.
Changes in v7:
- Add vddpos and vddeg supply.
- Use enable-gpios instead of defining enable pin.
.../leds/backlight/kinetic,ktz8866.yaml | 74 +++++++++++++++++++
1 file changed, 74 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
Comments
On 20/01/2023 10:47, Jianhua Lu wrote:
> Add Kinetic KTZ8866 backlight binding documentation.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> Changes in v2:
> - Remove "items" between "compatible" and "const: kinetic,ktz8866".
> - Change "additionalProperties" to "unevaluatedProperties".
>
> Changes in v3:
> - Add Krzysztof's R-b.
>
> Changes in v4:
> - Drop Krzysztof's R-b.
> - Add some new properties.
>
> Changes in v5:
> - Add missing enum under property description.
> - Rename uncorrect properties.
>
> Changes in v6:
> - Correct wrong property suffix and description.
>
> Changes in v7:
> - Add vddpos and vddeg supply.
> - Use enable-gpios instead of defining enable pin.
>
> .../leds/backlight/kinetic,ktz8866.yaml | 74 +++++++++++++++++++
> 1 file changed, 74 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> new file mode 100644
> index 000000000000..b1d0ade0dfb6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Kinetic Technologies KTZ8866 backlight
> +
> +maintainers:
> + - Jianhua Lu <lujianhua000@gmail.com>
> +
> +description: |
> + The Kinetic Technologies KTZ8866 is a high efficiency 6-channels-current-sinks
> + led backlight with dual lcd bias power.
> + https://www.kinet-ic.com/ktz8866/
> +
> +allOf:
> + - $ref: common.yaml#
> +
> +properties:
> + compatible:
> + const: kinetic,ktz8866
> +
> + vddpos-supply:
> + description: positive boost supply regulator.
> +
> + vddneg-supply:
> + description: negative boost supply regulator.
> +
> + enable-gpios:
> + description: GPIO to use to enable/disable the backlight (HWEN pin).
> + maxItems: 1
> +
> + current-num-sinks:
> + description: number of the LED current sinks' channels.
> + enum: [1, 2, 3, 4, 5, 6]
> +
> + current-ramping-time-ms:
> + description: LED current ramping time in milliseconds.
> + enum: [2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640]
kinetic,current-ramp-delay-ms
> +
> + led-ramping-time-ms:
kinetic,led-enable-ramp-delay-ms
So both are similar to existing regulator properties.
Best regards,
Krzysztof
On Fri, Jan 20, 2023 at 11:18:56AM +0100, Krzysztof Kozlowski wrote:
> On 20/01/2023 10:47, Jianhua Lu wrote:
> > Add Kinetic KTZ8866 backlight binding documentation.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> > Changes in v2:
> > - Remove "items" between "compatible" and "const: kinetic,ktz8866".
> > - Change "additionalProperties" to "unevaluatedProperties".
> >
> > Changes in v3:
> > - Add Krzysztof's R-b.
> >
> > Changes in v4:
> > - Drop Krzysztof's R-b.
> > - Add some new properties.
> >
> > Changes in v5:
> > - Add missing enum under property description.
> > - Rename uncorrect properties.
> >
> > Changes in v6:
> > - Correct wrong property suffix and description.
> >
> > Changes in v7:
> > - Add vddpos and vddeg supply.
> > - Use enable-gpios instead of defining enable pin.
> >
> > .../leds/backlight/kinetic,ktz8866.yaml | 74 +++++++++++++++++++
> > 1 file changed, 74 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > new file mode 100644
> > index 000000000000..b1d0ade0dfb6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > @@ -0,0 +1,74 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Kinetic Technologies KTZ8866 backlight
> > +
> > +maintainers:
> > + - Jianhua Lu <lujianhua000@gmail.com>
> > +
> > +description: |
> > + The Kinetic Technologies KTZ8866 is a high efficiency 6-channels-current-sinks
> > + led backlight with dual lcd bias power.
> > + https://www.kinet-ic.com/ktz8866/
> > +
> > +allOf:
> > + - $ref: common.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: kinetic,ktz8866
> > +
> > + vddpos-supply:
> > + description: positive boost supply regulator.
> > +
> > + vddneg-supply:
> > + description: negative boost supply regulator.
> > +
> > + enable-gpios:
> > + description: GPIO to use to enable/disable the backlight (HWEN pin).
> > + maxItems: 1
> > +
> > + current-num-sinks:
> > + description: number of the LED current sinks' channels.
> > + enum: [1, 2, 3, 4, 5, 6]
> > +
> > + current-ramping-time-ms:
> > + description: LED current ramping time in milliseconds.
> > + enum: [2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640]
>
> kinetic,current-ramp-delay-ms
>
> > +
> > + led-ramping-time-ms:
>
> kinetic,led-enable-ramp-delay-ms
>
> So both are similar to existing regulator properties.
>
reasonable suggestion.
> Best regards,
> Krzysztof
>
On Fri, Jan 20, 2023 at 05:47:27PM +0800, Jianhua Lu wrote:
> Add Kinetic KTZ8866 backlight binding documentation.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> [...]
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> new file mode 100644
> index 000000000000..b1d0ade0dfb6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> @@ -0,0 +1,74 @@
> [...]
> + current-ramping-time-ms:
> + description: LED current ramping time in milliseconds.
> + enum: [2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640]
This doesn't look like it goes low enough (wasn't there a value lower
than 2?).
Daniel.
On Fri, Jan 20, 2023 at 03:22:09PM +0000, Daniel Thompson wrote:
> On Fri, Jan 20, 2023 at 05:47:27PM +0800, Jianhua Lu wrote:
> > Add Kinetic KTZ8866 backlight binding documentation.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > [...]
> >
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > new file mode 100644
> > index 000000000000..b1d0ade0dfb6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > @@ -0,0 +1,74 @@
> > [...]
> > + current-ramping-time-ms:
> > + description: LED current ramping time in milliseconds.
> > + enum: [2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640]
>
> This doesn't look like it goes low enough (wasn't there a value lower
> than 2?).
>
Yes, I have sent a v8 patch to add it.
Thanks for reply.
>
> Daniel.
On Fri, Jan 20, 2023 at 03:22:09PM +0000, Daniel Thompson wrote:
> On Fri, Jan 20, 2023 at 05:47:27PM +0800, Jianhua Lu wrote:
> > Add Kinetic KTZ8866 backlight binding documentation.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > [...]
> >
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > new file mode 100644
> > index 000000000000..b1d0ade0dfb6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > @@ -0,0 +1,74 @@
> > [...]
> > + current-ramping-time-ms:
> > + description: LED current ramping time in milliseconds.
> > + enum: [2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640]
>
> This doesn't look like it goes low enough (wasn't there a value lower
> than 2?).
Sorry, I sent a wrong message, it isn't be fixed in v8,
I send a v9 patch to add it.
>
>
> Daniel.
new file mode 100644
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Kinetic Technologies KTZ8866 backlight
+
+maintainers:
+ - Jianhua Lu <lujianhua000@gmail.com>
+
+description: |
+ The Kinetic Technologies KTZ8866 is a high efficiency 6-channels-current-sinks
+ led backlight with dual lcd bias power.
+ https://www.kinet-ic.com/ktz8866/
+
+allOf:
+ - $ref: common.yaml#
+
+properties:
+ compatible:
+ const: kinetic,ktz8866
+
+ vddpos-supply:
+ description: positive boost supply regulator.
+
+ vddneg-supply:
+ description: negative boost supply regulator.
+
+ enable-gpios:
+ description: GPIO to use to enable/disable the backlight (HWEN pin).
+ maxItems: 1
+
+ current-num-sinks:
+ description: number of the LED current sinks' channels.
+ enum: [1, 2, 3, 4, 5, 6]
+
+ current-ramping-time-ms:
+ description: LED current ramping time in milliseconds.
+ enum: [2, 4, 8, 16, 32, 64, 128, 192, 256, 320, 384, 448, 512, 576, 640]
+
+ led-ramping-time-ms:
+ description: |
+ LED on/off ramping time in milliseconds, note that the case 0 will be mapped
+ to 512μs because ktz8866 can't ramp faster than it.
+ enum: [0, 1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16384]
+
+ kinetic,enable-lcd-bias:
+ description: Set if we want to output bias power supply for LCD.
+ type: boolean
+
+required:
+ - compatible
+ - vddpos-supply
+ - vddneg-supply
+ - enable-gpios
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ backlight {
+ compatible = "kinetic,ktz8866";
+
+ vddpos-supply = <&bl_vddpos_5p5>;
+ vddneg-supply = <&bl_vddneg_5p5>;
+ enable-gpios = <&tlmm 139 GPIO_ACTIVE_HIGH>;
+ current-num-sinks = <5>;
+ current-ramping-time-ms = <128>;
+ led-ramping-time-ms = <1>;
+ kinetic,enable-lcd-bias;
+ };