diff mbox series

[1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings

Message ID 20221020130957.25197-2-fchiby@baylibre.com
State New
Headers
Series mediatek: pwrap: Add mt8365 pwrap support |

Commit Message

Fadwa Chiby Oct. 20, 2022, 1:09 p.m. UTC 
  From: Fabien Parent <fparent@baylibre.com>

Add pwrap binding documentation for

Signed-off-by: Fabien Parent <fparent@baylibre.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Oct. 20, 2022, 4:19 p.m. UTC | #1 
On 20/10/2022 09:09, fchiby@baylibre.com wrote:
> From: Fabien Parent <fparent@baylibre.com>
> 
> Add pwrap binding documentation for
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Acked-by: Rob Herring <robh@kernel.org>

This is not exactly v1 then. Please use patch versioning and add
changelog (to cover letter or to individual patches).

Best regards,
Krzysztof
Krzysztof Kozlowski Oct. 20, 2022, 4:19 p.m. UTC | #2 
On 20/10/2022 09:09, fchiby@baylibre.com wrote:
> From: Fabien Parent <fparent@baylibre.com>
> 
> Add pwrap binding documentation for
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Acked-by: Rob Herring <robh@kernel.org>

Ah, and one more issue - your SoB is missing in all patches.

Best regards,
Krzysztof
Fadwa Chiby Oct. 24, 2022, 1:24 p.m. UTC | #3 
Le jeu. 20 oct. 2022 à 18:19, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> a écrit :
>
> On 20/10/2022 09:09, fchiby@baylibre.com wrote:
> > From: Fabien Parent <fparent@baylibre.com>
> >
> > Add pwrap binding documentation for
> >
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > Acked-by: Rob Herring <robh@kernel.org>
>
> This is not exactly v1 then. Please use patch versioning and add
> changelog (to cover letter or to individual patches).
>
> Best regards,
> Krzysztof
>

Hello,

Thanks for your feedback. Everything is fixed in a new series.

Regards,
Fadwa CHIBY
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
index d24e2bc444be..8424b93c432e 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
+++ b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
@@ -30,6 +30,7 @@  Required properties in pwrap device node.
 	"mediatek,mt8186-pwrap" for MT8186 SoCs
 	"mediatek,mt8188-pwrap", "mediatek,mt8195-pwrap" for MT8188 SoCs
 	"mediatek,mt8195-pwrap" for MT8195 SoCs
+	"mediatek,mt8365-pwrap" for MT8365 SoCs
 	"mediatek,mt8516-pwrap" for MT8516 SoCs
 - interrupts: IRQ for pwrap in SOC
 - reg-names: "pwrap" is required; "pwrap-bridge" is optional.
@@ -39,6 +40,8 @@  Required properties in pwrap device node.
 - clock-names: Must include the following entries:
   "spi": SPI bus clock
   "wrap": Main module clock
+  "sys": System module clock (for MT8365 SoC)
+  "tmr": Timer module clock (for MT8365 SoC)
 - clocks: Must contain an entry for each entry in clock-names.
 
 Optional properities: