MAINTAINERS: git://github -> https://github.com for cschaufler

Message ID 20221013214637.30807-1-palmer@rivosinc.com
State New
Headers
Series MAINTAINERS: git://github -> https://github.com for cschaufler |

Commit Message

Palmer Dabbelt Oct. 13, 2022, 9:46 p.m. UTC
  Github deprecated the git:// links about a year ago, so let's move to
the https:// URLs instead.

Reported-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://github.blog/2021-09-01-improving-git-protocol-security-github/
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
I've split these up by github username so folks can take them
independently, as some of these repos have been renamed at github and
thus need more than just a sed to fix them.
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Paul Moore Oct. 13, 2022, 9:54 p.m. UTC | #1
On Thu, Oct 13, 2022 at 5:49 PM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> Github deprecated the git:// links about a year ago, so let's move to
> the https:// URLs instead.
>
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Link: https://github.blog/2021-09-01-improving-git-protocol-security-github/
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> I've split these up by github username so folks can take them
> independently, as some of these repos have been renamed at github and
> thus need more than just a sed to fix them.
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Casey is the one who needs to ACK this (and he has an email delay at
the moment), but the URL looks good to me.

Reviewed-by: Paul Moore <paul@paul-moore.com>

> diff --git a/MAINTAINERS b/MAINTAINERS
> index daadd0de77a9..019cdb48e254 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18723,7 +18723,7 @@ M:      Casey Schaufler <casey@schaufler-ca.com>
>  L:     linux-security-module@vger.kernel.org
>  S:     Maintained
>  W:     http://schaufler-ca.com
> -T:     git git://github.com/cschaufler/smack-next
> +T:     git https://github.com/cschaufler/smack-next
>  F:     Documentation/admin-guide/LSM/Smack.rst
>  F:     security/smack/
>
> --
> 2.38.0
  
Palmer Dabbelt Oct. 14, 2022, 3:51 a.m. UTC | #2
On Thu, 13 Oct 2022 14:54:00 PDT (-0700), paul@paul-moore.com wrote:
> On Thu, Oct 13, 2022 at 5:49 PM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>>
>> Github deprecated the git:// links about a year ago, so let's move to
>> the https:// URLs instead.
>>
>> Reported-by: Conor Dooley <conor.dooley@microchip.com>
>> Link: https://github.blog/2021-09-01-improving-git-protocol-security-github/
>> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
>> ---
>> I've split these up by github username so folks can take them
>> independently, as some of these repos have been renamed at github and
>> thus need more than just a sed to fix them.
>> ---
>>  MAINTAINERS | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Casey is the one who needs to ACK this (and he has an email delay at
> the moment), but the URL looks good to me.

No worries, I'm in no rush to merge this.  Conor just pointed out the 
RISC-V KVM URL having this issue so I scripted a patch for everyone.   
Feel free to just take it through your tree if you want, otherwise I'll 
keep it around locally and hopefully remember to send something once 
it's Ack'd.

Just note that "MAINTAINERS: git://github -> https://github.com for" was 
a scripting mistake, it should probably be "MAINTAINERS: 
git://github.com -> https://github.com".  If I have to re-spin this I'll 
fix it, but if someone else is taking it then it's probably best to 
fixup.

> Reviewed-by: Paul Moore <paul@paul-moore.com>
>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index daadd0de77a9..019cdb48e254 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -18723,7 +18723,7 @@ M:      Casey Schaufler <casey@schaufler-ca.com>
>>  L:     linux-security-module@vger.kernel.org
>>  S:     Maintained
>>  W:     http://schaufler-ca.com
>> -T:     git git://github.com/cschaufler/smack-next
>> +T:     git https://github.com/cschaufler/smack-next
>>  F:     Documentation/admin-guide/LSM/Smack.rst
>>  F:     security/smack/
>>
>> --
>> 2.38.0
  
Casey Schaufler Oct. 20, 2022, 4:19 p.m. UTC | #3
On 10/13/2022 2:46 PM, Palmer Dabbelt wrote:
> Github deprecated the git:// links about a year ago, so let's move to
> the https:// URLs instead.
>
> Reported-by: Conor Dooley <conor.dooley@microchip.com>
> Link: https://github.blog/2021-09-01-improving-git-protocol-security-github/
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>

Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>

Do you want to apply this to your tree, or would you like me to
take it by the Smack tree? I'm fine either way.

> ---
> I've split these up by github username so folks can take them
> independently, as some of these repos have been renamed at github and
> thus need more than just a sed to fix them.
> ---
>  MAINTAINERS | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index daadd0de77a9..019cdb48e254 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18723,7 +18723,7 @@ M:	Casey Schaufler <casey@schaufler-ca.com>
>  L:	linux-security-module@vger.kernel.org
>  S:	Maintained
>  W:	http://schaufler-ca.com
> -T:	git git://github.com/cschaufler/smack-next
> +T:	git https://github.com/cschaufler/smack-next
>  F:	Documentation/admin-guide/LSM/Smack.rst
>  F:	security/smack/
>
  

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index daadd0de77a9..019cdb48e254 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18723,7 +18723,7 @@  M:	Casey Schaufler <casey@schaufler-ca.com>
 L:	linux-security-module@vger.kernel.org
 S:	Maintained
 W:	http://schaufler-ca.com
-T:	git git://github.com/cschaufler/smack-next
+T:	git https://github.com/cschaufler/smack-next
 F:	Documentation/admin-guide/LSM/Smack.rst
 F:	security/smack/