Message ID | 1674192352-4473-3-git-send-email-hongxing.zhu@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp31408wrn; Thu, 19 Jan 2023 21:55:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXtwp0cSw+I6RS+Qabne2h/RdkzcJehr5U6xH4AZ01AQ5p97wFaL2z7I+9AfgGFRlMLoBXhc X-Received: by 2002:a17:90a:9283:b0:226:30c5:3e61 with SMTP id n3-20020a17090a928300b0022630c53e61mr14150872pjo.6.1674194150108; Thu, 19 Jan 2023 21:55:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674194150; cv=none; d=google.com; s=arc-20160816; b=aYAySx77XXej0cDe7HPnUwLHQTll1let2gFxxTEjJglu5KIpt0W+gETwZmvSt0U5g5 +1l51h1+ESa6BXWPeS9EYXFQpWvpD/BockXFHvZZMJaKm2dbYih+1pWZ0JDZs4ESbWtI QamXpK2FLdbo6HNw2nxGGTBPA8VQPWXDF781RT22Flpl9+0ylGAqJJkJ7Ah0yMlxmNwb vf+cTMOR6HXDi270lqdxTvpGFxEvgrGkgSRh52vyGCADjrFcRsGwvbh3ov+FPgQfoCZF Rr6iv1E6BRuiVWRHnAjKCTMNdl31DhFY3JqNCIRB4WK07R7/NSTnij4ks+i7VFA9YpEb jjcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=XoWnKkGtAyKCz4NPX6x1fw6xNfI9OJr+oygHRa2DvYI=; b=Phy4GbR6i3mRmPuuopD8Ou8B7+18CfbEbNfZ99okfusKhcnv+P0JYtMLXRZi97iE0Y GsP3xfs/iGgQ5V3MKMq/dOeZc8Mwed3Ji/GthXaTRfjEQ2+FO+xJqo5FK+QWG2bd87ug 2R6JkAGJhwOiemh2fjfivVyfQMM+6GiDHgvj+IwXlChz3bGrgcPvDGZzcSJL8CjdC9OJ bg4ojj6chynNEfVh7+BLfMiGb0bTRbQWRw9SS+e+PK64of19hsRIjxXArEweXF9ucPxq 1mU3fW7lX4JwbX0SjvoH3LqHyzPT945fY0hLvj7VX+4p7xfhB0T6xugnJz0a7ijHsejm Xc4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p5-20020a17090a74c500b00200435da17asi1418488pjl.128.2023.01.19.21.55.37; Thu, 19 Jan 2023 21:55:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231223AbjATFup (ORCPT <rfc822;xxoosimple@gmail.com> + 99 others); Fri, 20 Jan 2023 00:50:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230285AbjATFuj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 20 Jan 2023 00:50:39 -0500 Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C12F11664; Thu, 19 Jan 2023 21:50:38 -0800 (PST) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 27C80200064; Fri, 20 Jan 2023 06:50:37 +0100 (CET) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id E40E4200070; Fri, 20 Jan 2023 06:50:36 +0100 (CET) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 7A2AF180327D; Fri, 20 Jan 2023 13:50:35 +0800 (+08) From: Richard Zhu <hongxing.zhu@nxp.com> To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, peng.fan@nxp.com, marex@denx.de, marcel.ziswiler@toradex.com, tharvey@gateworks.com, frank.li@nxp.com Cc: lorenzo.pieralisi@arm.com, hongxing.zhu@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: [PATCH v6 2/6] arm64: dts: Add i.MX8MM PCIe EP support on EVK board Date: Fri, 20 Jan 2023 13:25:48 +0800 Message-Id: <1674192352-4473-3-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1674192352-4473-1-git-send-email-hongxing.zhu@nxp.com> References: <1674192352-4473-1-git-send-email-hongxing.zhu@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755519805178359087?= X-GMAIL-MSGID: =?utf-8?q?1755519805178359087?= |
Series |
Add i.MX PCIe EP mode support
|
|
Commit Message
Richard Zhu
Jan. 20, 2023, 5:25 a.m. UTC
Add i.MX8MM PCIe EP support on EVK board.
Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
Comments
On 20/01/2023 06:25, Richard Zhu wrote: > Add i.MX8MM PCIe EP support on EVK board. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > index 0ce3005d578d..9d65b70939fa 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > @@ -371,6 +371,19 @@ &pcie0 { > status = "okay"; > }; > > +&pcie0_ep{ > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pcie0>; > + clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&pcie0_refclk>, > + <&clk IMX8MM_CLK_PCIE1_AUX>; > + assigned-clocks = <&clk IMX8MM_CLK_PCIE1_AUX>, > + <&clk IMX8MM_CLK_PCIE1_CTRL>; > + assigned-clock-rates = <10000000>, <250000000>; > + assigned-clock-parents = <&clk IMX8MM_SYS_PLL2_50M>, > + <&clk IMX8MM_SYS_PLL2_250M>; > + status = "disabled"; It's already disabled. What are you doing here? Having disabled node is useless, so entire patch should be dropped. Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2023年1月20日 16:09 > To: Hongxing Zhu <hongxing.zhu@nxp.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; Peng Fan > <peng.fan@nxp.com>; marex@denx.de; Marcel Ziswiler > <marcel.ziswiler@toradex.com>; tharvey@gateworks.com; Frank Li > <frank.li@nxp.com> > Cc: lorenzo.pieralisi@arm.com; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; > kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH v6 2/6] arm64: dts: Add i.MX8MM PCIe EP support on EVK > board > > On 20/01/2023 06:25, Richard Zhu wrote: > > Add i.MX8MM PCIe EP support on EVK board. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > index 0ce3005d578d..9d65b70939fa 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > @@ -371,6 +371,19 @@ &pcie0 { > > status = "okay"; > > }; > > > > +&pcie0_ep{ > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_pcie0>; > > + clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&pcie0_refclk>, > > + <&clk IMX8MM_CLK_PCIE1_AUX>; > > + assigned-clocks = <&clk IMX8MM_CLK_PCIE1_AUX>, > > + <&clk IMX8MM_CLK_PCIE1_CTRL>; > > + assigned-clock-rates = <10000000>, <250000000>; > > + assigned-clock-parents = <&clk IMX8MM_SYS_PLL2_50M>, > > + <&clk IMX8MM_SYS_PLL2_250M>; > > + status = "disabled"; > > It's already disabled. What are you doing here? Having disabled node is useless, > so entire patch should be dropped. Okay, the 2/4/6 patches would be dropped. Thanks. Best Regards Richard Zhu > > Best regards, > Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi index 0ce3005d578d..9d65b70939fa 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi @@ -371,6 +371,19 @@ &pcie0 { status = "okay"; }; +&pcie0_ep{ + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_pcie0>; + clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&pcie0_refclk>, + <&clk IMX8MM_CLK_PCIE1_AUX>; + assigned-clocks = <&clk IMX8MM_CLK_PCIE1_AUX>, + <&clk IMX8MM_CLK_PCIE1_CTRL>; + assigned-clock-rates = <10000000>, <250000000>; + assigned-clock-parents = <&clk IMX8MM_SYS_PLL2_50M>, + <&clk IMX8MM_SYS_PLL2_250M>; + status = "disabled"; +}; + &sai2 { #sound-dai-cells = <0>; pinctrl-names = "default";