Message ID | 20230119-topic-sm8550-vtdr6130-fixup-v1-1-82c4fb008138@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp345163wrn; Thu, 19 Jan 2023 06:05:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXs0cUwqsFWoF1VSqpbrxJU+Ya1J8Y/A9ldwe2EuMllnf1lAkAvHYtC9kkpMUVvvY9GG8GH2 X-Received: by 2002:a17:903:2306:b0:193:3540:c54d with SMTP id d6-20020a170903230600b001933540c54dmr15236598plh.26.1674137139901; Thu, 19 Jan 2023 06:05:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674137139; cv=none; d=google.com; s=arc-20160816; b=RjFSk2pbVXfqk9IIoSJ6dJfMCT3vx5uAveM9G7q1R1+twbi7qkpnNYYFXjWmg9pmdw eej77bjEE814Y5Qnd6UlYjBPZhMGxEZTCe3SJztKeK76r7s5VaOX8nvGIQ+puuV8x+o8 F6Jp8NEN32d3tSr77WyIZ3sPEcW6nQ+oG0LJtHnxVy7c45zhEzqoVU6I/5HAyykbIlzu Ix3re3iwoH+QKHMwbcrlbDVStVQKKfw0QI1buQRTUcQErmX9tzgitrS+Nz1kcwwh7/IW HtxVrRU6+MASq3doc3DSrYHQq71f+9MamMg6SVSDDeka3KdJkDzJw1wGoMG+Wd3lWhw3 t/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:message-id:content-transfer-encoding :mime-version:subject:date:from:dkim-signature; bh=GC/mI6lQCD2v+9Dq5VgRk4R+zYjXPgjV01+G3TFhd9g=; b=a+lCHXgLdkxoCUpK2w4HG9sTJyLNhR3lTfJyxf046Zpg4gjo9yN2eMlRmZttraej5d fSOiom4M5l+f40LLNcZbLDiXdEENuGAekzi7XS2bOWsOoaiqycrAlfUMG3Hjr3sBST8b jON2/h7f3NhbYm6zLqaVD9PAPlgH593JwWvNP3S4axYnZ/DkZERZaeJZ4lfScaJWplLx EbfEHWGHVFGLZ1/WqB91kVy0iwfd772ZCCmyzJ2NaY5BJPM/Y9mKTaMv7g9bnPHKBVJ5 BVvbQ46mD9BATMxFwP6z74ixPy92CEYuyvdYUuxlResRRjJHd762xUypgb0SdU6DDR9a sMww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XtK71Opt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e7-20020a170903240700b00170f6f728d4si37408581plo.543.2023.01.19.06.05.26; Thu, 19 Jan 2023 06:05:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XtK71Opt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230463AbjASOEY (ORCPT <rfc822;pfffrao@gmail.com> + 99 others); Thu, 19 Jan 2023 09:04:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229787AbjASOES (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 19 Jan 2023 09:04:18 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28C9826B0 for <linux-kernel@vger.kernel.org>; Thu, 19 Jan 2023 06:04:17 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id k16so1624371wms.2 for <linux-kernel@vger.kernel.org>; Thu, 19 Jan 2023 06:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=GC/mI6lQCD2v+9Dq5VgRk4R+zYjXPgjV01+G3TFhd9g=; b=XtK71Opt18vNIARTivzkJYj2xOJEeq/DrEEoTVl6Za7cfOLg3bma08hATH9TDvqnIc upybtOXxL6DwFWG+no4XduzSAeo4eUPKO2YgdpjBqA/tCjMVKMCqc8gsLuu1oWWarnxs zl6QA5XxQNB6YAn92JHG2ZwkfvLN2Up6SF4yXa/tOCr65ZB2Y4WLDch/AaVo3mWz0zGR chrKM6Nqmx+k8yWtlPtkgHq3nZMKIoOOSA3GgLeuoOLK+PV6pnF1nEPnE99sVumOdTfE lvNZc+OkFvRtOf1gCCM4NwIIAKtHdBCizFv7iMoMQCSeBf2WZH49T8jLBxVUmgHkw2Wc usDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GC/mI6lQCD2v+9Dq5VgRk4R+zYjXPgjV01+G3TFhd9g=; b=vum/RbuHr/id5BwAy3m2BP26dN8cXPoV1K/XVwDCvFwfk5/LrWtFU+TipKpeGreXt3 sRyMVdj3aMgJl/M+VDqQpJpHJ6G78pEYbGj6LrLH5a1QctZMuOsU5avdViMNC+EKsv9E O+FJlDUp9DWjw1uadteHrHuDQrK6M6Ndjn2hMJfqZSfp0jUyk9A1QsOwo69bc72z1D// BG/xNDDStEZTpWeXfsfKMZuHyyvyZWlveojQEft19vd6kQag3o0/nw7bDPdvEJk0wdje LEaAXoglSWGMgI04CbYqEpeIqgCvaX+v0E4KgSz0gZZJ6iE9W3vF927WjZ8ZfqzYZAPc oKYg== X-Gm-Message-State: AFqh2kprWtigM9m4N3QRZ1BV0KkYdVmRxU4ukBMg6B7hoWVCg0/y9j4e itlSjYCw54SQ7xOjxi3AnIQlIA== X-Received: by 2002:a05:600c:2255:b0:3da:f950:8168 with SMTP id a21-20020a05600c225500b003daf9508168mr9983502wmm.35.1674137055705; Thu, 19 Jan 2023 06:04:15 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id az9-20020a05600c600900b003b3307fb98fsm5273206wmb.24.2023.01.19.06.04.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 06:04:15 -0800 (PST) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Thu, 19 Jan 2023 15:04:12 +0100 Subject: [PATCH] drm/panel: vtdr6130: fix unused ret in visionox_vtdr6130_bl_update_status MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230119-topic-sm8550-vtdr6130-fixup-v1-1-82c4fb008138@linaro.org> X-B4-Tracking: v=1; b=H4sIANxNyWMC/x2NQQqDMBBFryKz7kASSdBepXSRxEkdsDEkKoJ49 w5dvsfn/QsaVaYGz+6CSgc3XrOAfnQQZ58/hDwJg1GmV1qPuK2FI7bvYK3CY5uq073CxOdeMAVj kxtc8HYEKQTfCEP1Oc7SyPuyiCyVZP2/fL3v+wcSkV3rggAAAA== To: Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>, Richard Acayan <mailingradian@gmail.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>, kernel test robot <lkp@intel.com>, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.11.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755460025568130144?= X-GMAIL-MSGID: =?utf-8?q?1755460025568130144?= |
Series |
drm/panel: vtdr6130: fix unused ret in visionox_vtdr6130_bl_update_status
|
|
Commit Message
Neil Armstrong
Jan. 19, 2023, 2:04 p.m. UTC
Fix the following warning:
panel-visionox-vtdr6130.c:249:12: warning: 'ret' is used uninitialized [-Wuninitialized]
Fixes: 9402cde9347e ("drm/panel: vtdr6130: Use 16-bit brightness function")
Reported-by: Daniel Vetter <daniel@ffwll.ch>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
---
base-commit: 43bde505d66a41c2ad706d603e97b2c8aa2fbe4a
change-id: 20230119-topic-sm8550-vtdr6130-fixup-fb25f686ba59
Best regards,
Comments
On Thu, Jan 19, 2023 at 03:04:12PM +0100, Neil Armstrong wrote: > Fix the following warning: > panel-visionox-vtdr6130.c:249:12: warning: 'ret' is used uninitialized [-Wuninitialized] > > Fixes: 9402cde9347e ("drm/panel: vtdr6130: Use 16-bit brightness function") > Reported-by: Daniel Vetter <daniel@ffwll.ch> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > --- > drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c > index 1092075b31a5..bb0dfd86ea67 100644 > --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c > +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c > @@ -243,13 +243,8 @@ static int visionox_vtdr6130_bl_update_status(struct backlight_device *bl) > { > struct mipi_dsi_device *dsi = bl_get_data(bl); > u16 brightness = backlight_get_brightness(bl); > - int ret; > > - mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); > - if (ret < 0) > - return ret; > - > - return 0; > + return mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); > } > > static const struct backlight_ops visionox_vtdr6130_bl_ops = { > > --- > base-commit: 43bde505d66a41c2ad706d603e97b2c8aa2fbe4a > change-id: 20230119-topic-sm8550-vtdr6130-fixup-fb25f686ba59 > > Best regards, > -- > Neil Armstrong <neil.armstrong@linaro.org>
Hi, On Thu, 19 Jan 2023 15:04:12 +0100, Neil Armstrong wrote: > Fix the following warning: > panel-visionox-vtdr6130.c:249:12: warning: 'ret' is used uninitialized [-Wuninitialized] > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/panel: vtdr6130: fix unused ret in visionox_vtdr6130_bl_update_status https://cgit.freedesktop.org/drm/drm-misc/commit/?id=ebd05c0e12edc568243056711ce00f79e19eab68
diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c index 1092075b31a5..bb0dfd86ea67 100644 --- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c +++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c @@ -243,13 +243,8 @@ static int visionox_vtdr6130_bl_update_status(struct backlight_device *bl) { struct mipi_dsi_device *dsi = bl_get_data(bl); u16 brightness = backlight_get_brightness(bl); - int ret; - mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); - if (ret < 0) - return ret; - - return 0; + return mipi_dsi_dcs_set_display_brightness_large(dsi, brightness); } static const struct backlight_ops visionox_vtdr6130_bl_ops = {