Message ID | 20230118122817.42466-3-francesco@dolcini.it |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2331815wrn; Wed, 18 Jan 2023 05:18:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXsyaoo+bvuFfPUND0RZoJMGWuAfpDFcehtxKLRk8G5/Nncuz22rw9puQK6LHBXeJuQTEkbE X-Received: by 2002:a17:907:6c16:b0:86f:3dfa:4016 with SMTP id rl22-20020a1709076c1600b0086f3dfa4016mr8104035ejc.7.1674047908461; Wed, 18 Jan 2023 05:18:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674047908; cv=none; d=google.com; s=arc-20160816; b=bj/uQ4/ojV12KoQnml2lQT2pkX+0vuRxqQVNBODwqlYVc7Nqxo7SeRFVtsIFu0sXbw QgpK94EKb9WJUnGb+SS3AiNzQ6OWB8ehWuX2a80dwc2vWRYM10nXK0ioPZpgSpdzTEpn Xy2/BgHWhxZe31ydq768oxrWRGZg2rQIteEu/NgpPBbjQ8maj9JQVtlzHQJlBpUkQ7AU RDsChJvN58zOYc8iTq45i8U4Q0ltpbXRVPg6D/Y+XZKfkSbWOl+2vzknX7urvWbmrohu xBFEoJWqueiL5rJ4g0abcnGR/1DYFs6+dWd3HgJCqC7vImcN68qlxD18QZGaqV/tI3w8 70+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MtzVZMO4bwC34jITZq447mMjjaIDTR1MhnC+OT1hMaM=; b=lce0MNqBcL0hY3jtM7efw+mvJPWctADHsZ0gDVcppjTewLd5GzuEP4rJ8wh+R5ht4B FennSD4mJG92jwYMixpi/RRwSPA8bH86LzafTC2HAA5ROObrzquj/h6CAVfrWyFRMGPo vGd2wvxmNQeKu6FrxtuDAXZRy7P79q5HWG16cwt7FZlgWbrmskHNxNTvdwl7aea1NYFL R9um5fLIF7j9PWXvlffF2ygtYzXmJgFrg93HnQTQG8+snEyanxODUGfb9SDu0LBD9cPE yD9qP4LXyl8a6DmWLzLtEZ8cTA3VFScA8AV8/whNytUYDnlAK7kfB1NFc0YsSu7E5/ZO 9ORQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailserver.it header.s=mailsrv header.b=gtaXP8+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gb36-20020a170907962400b0086c7dc4fd9bsi17747521ejc.538.2023.01.18.05.18.04; Wed, 18 Jan 2023 05:18:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailserver.it header.s=mailsrv header.b=gtaXP8+m; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229584AbjARNHh (ORCPT <rfc822;pfffrao@gmail.com> + 99 others); Wed, 18 Jan 2023 08:07:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbjARNHB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 18 Jan 2023 08:07:01 -0500 Received: from smtp-out-01.comm2000.it (smtp-out-01.comm2000.it [212.97.32.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4106559D3; Wed, 18 Jan 2023 04:29:08 -0800 (PST) Received: from francesco-nb.toradex.int (31-10-206-125.static.upc.ch [31.10.206.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: francesco@dolcini.it) by smtp-out-01.comm2000.it (Postfix) with ESMTPSA id 6EDB8843650; Wed, 18 Jan 2023 13:28:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailserver.it; s=mailsrv; t=1674044946; bh=bjC01oSWRrukRi0FK/TP4lp7hs5che5aWaE7C4SjpZQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gtaXP8+mXEp6XCT+KrIjjks/aYQnMYzgSITxTjoJuyrOpWAKbuwIHCkqe/2apjSn6 jdHsZnJYBLgrFmoqBNBpkhwBu0WEXUlXKfeD1e1mH1Uzm/Bm6G5/H/brVdj8PKNOGf WK4EBlvkNmhmjcLIyPZb1iMSq8pZJnt+lWLNqfGGKh3VZPVycGsrTLesyMaoOBPwqQ h9bmnSCsVfNBsbl5p4juZnQrTnTv2sdj04QHlFNA1Esz+MXhDsDx29VcT0I+XB5+wm s2574muvScFk92dSatCN/jdnbLmUsyX91M39FEmZbY88V9n9s1G3D9c8h2XRDkJ+wQ +vsxAl1hoUY+A== From: Francesco Dolcini <francesco@dolcini.it> To: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>, Luiz Augusto von Dentz <luiz.dentz@gmail.com> Cc: Stefan Eichenberger <stefan.eichenberger@toradex.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Johan Hedberg <johan.hedberg@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>, Francesco Dolcini <francesco.dolcini@toradex.com> Subject: [PATCH v1 2/4] dt-bindings: bluetooth: marvell: add max-speed property Date: Wed, 18 Jan 2023 13:28:15 +0100 Message-Id: <20230118122817.42466-3-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230118122817.42466-1-francesco@dolcini.it> References: <20230118122817.42466-1-francesco@dolcini.it> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755366459781805161?= X-GMAIL-MSGID: =?utf-8?q?1755366459781805161?= |
Series |
Bluetooth: hci_mrvl: Add serdev support for 88W8997
|
|
Commit Message
Francesco Dolcini
Jan. 18, 2023, 12:28 p.m. UTC
From: Stefan Eichenberger <stefan.eichenberger@toradex.com> The 88W8997 bluetooth module supports setting the max-speed property. Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> --- .../bindings/net/marvell-bluetooth.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
Comments
On 18/01/2023 13:28, Francesco Dolcini wrote: > From: Stefan Eichenberger <stefan.eichenberger@toradex.com> > > The 88W8997 bluetooth module supports setting the max-speed property. > > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../bindings/net/marvell-bluetooth.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml > index 83b64ed730f5..2fccea30c58d 100644 > --- a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml > @@ -19,9 +19,25 @@ properties: > - mrvl,88w8897 > - mrvl,88w8997 > > + max-speed: > + description: see Documentation/devicetree/bindings/serial/serial.yaml > + > required: > - compatible > > +allOf: > + - if: > + properties: Wrong indentation, missing two spaces. Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
On Wed, 18 Jan 2023 13:28:15 +0100, Francesco Dolcini wrote: > From: Stefan Eichenberger <stefan.eichenberger@toradex.com> > > The 88W8997 bluetooth module supports setting the max-speed property. > > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../bindings/net/marvell-bluetooth.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/net/marvell-bluetooth.yaml:29:8: [error] empty value in block mapping (empty-values) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml: allOf:0:if: None is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml: ignoring, error in schema: allOf: 0: if Documentation/devicetree/bindings/net/marvell-bluetooth.example.dtb: /example-0/serial/bluetooth: failed to match any schema with compatible: ['mrvl,88w8897'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230118122817.42466-3-francesco@dolcini.it The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml index 83b64ed730f5..2fccea30c58d 100644 --- a/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/marvell-bluetooth.yaml @@ -19,9 +19,25 @@ properties: - mrvl,88w8897 - mrvl,88w8997 + max-speed: + description: see Documentation/devicetree/bindings/serial/serial.yaml + required: - compatible +allOf: + - if: + properties: + compatible: + contains: + const: mrvl,88w8997 + then: + properties: + max-speed: true + else: + properties: + max-speed: false + additionalProperties: false examples: