of: fix repeated words in comments

  Delete the redundant word 'of'.

Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
---
 drivers/of/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

On 10/19/22 06:02, Jilin Yuan wrote:
> Delete the redundant word 'of'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
>  drivers/of/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/device.c b/drivers/of/device.c
> index 8cefe5a7d04e..16c7e5a2a868 100644
> --- a/drivers/of/device.c
> +++ b/drivers/of/device.c
> @@ -19,7 +19,7 @@
>  
>  /**
>   * of_match_device - Tell if a struct device matches an of_device_id list
> - * @matches: array of of device match structures to search in
> + * @matches: array of device match structures to search in

Hi,
Rob has already explained this at least 2 times.

The second "of" is "open firmware".
I would write it
              array of OF device match structures to search in
:)

>   * @dev: the of device structure to match against
>   *
>   * Used by a driver to check whether an platform_device present in the
  

On 19/10/2022 19:53, Randy Dunlap wrote:
> 
> 
> On 10/19/22 06:02, Jilin Yuan wrote:
>> Delete the redundant word 'of'.
>>
>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>> ---
>>  drivers/of/device.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/of/device.c b/drivers/of/device.c
>> index 8cefe5a7d04e..16c7e5a2a868 100644
>> --- a/drivers/of/device.c
>> +++ b/drivers/of/device.c
>> @@ -19,7 +19,7 @@
>>  
>>  /**
>>   * of_match_device - Tell if a struct device matches an of_device_id list
>> - * @matches: array of of device match structures to search in
>> + * @matches: array of device match structures to search in
> 
> Hi,
> Rob has already explained this at least 2 times.
> 
> The second "of" is "open firmware".
> I would write it
>               array of OF device match structures to search in
> :)

Good luck getting a response out of these guys, at this point
you've gotta wonder if they're real people or bots.

> 
>>   * @dev: the of device structure to match against
>>   *
>>   * Used by a driver to check whether an platform_device present in the
>
  

On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
> 
> On 10/19/22 06:02, Jilin Yuan wrote:
> > Delete the redundant word 'of'.
> > 
> > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> > ---
> >  drivers/of/device.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > index 8cefe5a7d04e..16c7e5a2a868 100644
> > --- a/drivers/of/device.c
> > +++ b/drivers/of/device.c
> > @@ -19,7 +19,7 @@
> >  
> >  /**
> >   * of_match_device - Tell if a struct device matches an of_device_id list
> > - * @matches: array of of device match structures to search in
> > + * @matches: array of device match structures to search in
> 
> Hi,
> Rob has already explained this at least 2 times.
> 
> The second "of" is "open firmware".
> I would write it
>               array of OF device match structures to search in
> :)

Actually, I'd probably do something like

    	     array of Open Firmware (OF) device match structures...

This is the first place in that file (at least in a comment) where OF
gets used, and I've always been a big fan of using the fully expanded
acronym before using the acronym form.  Remember, PCMCIA stands for
People Can't Memorize Computer Industry Acronyms.  :-)

(Actually, it's Personal Computer Memory Chip Industry Association,
but most people don't know that, because using acronyms without
defining them first makes you feel like you're an "insider".  :-)

	     	      	   	    - Ted
  

On 10/19/22 18:39, Theodore Ts'o wrote:
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
>>
>> On 10/19/22 06:02, Jilin Yuan wrote:
>>> Delete the redundant word 'of'.
>>>
>>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>>> ---
>>>  drivers/of/device.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/of/device.c b/drivers/of/device.c
>>> index 8cefe5a7d04e..16c7e5a2a868 100644
>>> --- a/drivers/of/device.c
>>> +++ b/drivers/of/device.c
>>> @@ -19,7 +19,7 @@
>>>  
>>>  /**
>>>   * of_match_device - Tell if a struct device matches an of_device_id list
>>> - * @matches: array of of device match structures to search in
>>> + * @matches: array of device match structures to search in
>>
>> Hi,
>> Rob has already explained this at least 2 times.
>>
>> The second "of" is "open firmware".
>> I would write it
>>               array of OF device match structures to search in
>> :)
> 
> Actually, I'd probably do something like
> 
>     	     array of Open Firmware (OF) device match structures...

Sure, that's good.

> This is the first place in that file (at least in a comment) where OF
> gets used, and I've always been a big fan of using the fully expanded
> acronym before using the acronym form.  Remember, PCMCIA stands for
> People Can't Memorize Computer Industry Acronyms.  :-)
> 
> (Actually, it's Personal Computer Memory Chip Industry Association,

                                           Card International Association :)

> but most people don't know that, because using acronyms without
> defining them first makes you feel like you're an "insider".  :-)
  

On Wed, Oct 19, 2022 at 8:39 PM Theodore Ts'o <tytso@mit.edu> wrote:
>
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
> >
> > On 10/19/22 06:02, Jilin Yuan wrote:
> > > Delete the redundant word 'of'.
> > >
> > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> > > ---
> > >  drivers/of/device.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/of/device.c b/drivers/of/device.c
> > > index 8cefe5a7d04e..16c7e5a2a868 100644
> > > --- a/drivers/of/device.c
> > > +++ b/drivers/of/device.c
> > > @@ -19,7 +19,7 @@
> > >
> > >  /**
> > >   * of_match_device - Tell if a struct device matches an of_device_id list
> > > - * @matches: array of of device match structures to search in
> > > + * @matches: array of device match structures to search in
> >
> > Hi,
> > Rob has already explained this at least 2 times.
> >
> > The second "of" is "open firmware".
> > I would write it
> >               array of OF device match structures to search in
> > :)
>
> Actually, I'd probably do something like
>
>              array of Open Firmware (OF) device match structures...

Or just put the struct name in there: of_device_id

But at this point I prefer to just leave it alone for the
entertainment factor of how many times can I get this patch from
send-only email accts.

Rob
  

On Wed, Oct 19, 2022 at 07:57:44PM +0100, Conor Dooley wrote:
> Good luck getting a response out of these guys, at this point
> you've gotta wonder if they're real people or bots.
> 

I think @cdjrlc.com people only have one-way communication with kernel
community, since they send patches but ignoring (critical) review on
these.

Thanks.
  

On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
> >  /**
> >   * of_match_device - Tell if a struct device matches an of_device_id list
> > - * @matches: array of of device match structures to search in
> > + * @matches: array of device match structures to search in
> 
> Hi,
> Rob has already explained this at least 2 times.
> 

On what?
  

On 10/20/22 06:35, Bagas Sanjaya wrote:
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
>>>  /**
>>>   * of_match_device - Tell if a struct device matches an of_device_id list
>>> - * @matches: array of of device match structures to search in
>>> + * @matches: array of device match structures to search in
>>
>> Hi,
>> Rob has already explained this at least 2 times.
>>
> 
> On what?
> 

I have seen them on lkml mailing list.