| Message ID | 20221020014426.188667-1-xiangyang3@huawei.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp11519wrs;
Wed, 19 Oct 2022 18:50:50 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM6NkGigmGGVARUxh6OyHiA5xGq2vwkS/9ytu+8AHF8U+WWhRCXgjMULmhbsmep0rA71iz89
X-Received: by 2002:a05:6402:2285:b0:45c:7c8c:3032 with SMTP id
cw5-20020a056402228500b0045c7c8c3032mr9732522edb.78.1666230650203;
Wed, 19 Oct 2022 18:50:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666230650; cv=none;
d=google.com; s=arc-20160816;
b=snrb5s5p1ZjFah5wq7PFDNmjNdLfl6aNFZ8t43zPyAkLfoFmnAcShoc9xvK1NRHLV4
0PgExoZeM7Mxw2BVqXPS+K/lBD05oMKNcAY7RG4KWVnpDY9amLmiAsDYCAhrMCMe7Eyh
FbNA1Nd13CRJMeiifdKug3m1ML/MGCKQM/q3RB5i5CGb+/iX09lz204ykXhCGTLkV+Z3
lV1uSp+FXvAsSToFu2rmj16JcQH6ZyFvSRAl209uKkGR8+zT9qQqT04Ju76QHTicv8FT
zjvUVyYQYn8BYQ93lp2VYHBaSACkvzMrGxq+Gw42sn1F8q96piO9BeqUqHBI/XQ/Smvk
yQoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=/KNt1saws/21aqFc8Jwk9VPHaSQDPRAjcwq1UtHhvzY=;
b=pa7y7uufrDUo/zuf0Lys+0z7Dg1TnoKtRPdjbZwSRalcpMTtRpcrsJdiOG/XDahzHQ
LxQpRSxE2p+j0RPZ8Q6QVEAQraDe6X6uRuwou52JCzVIUmWKDG/lcl7Zs/0L2/G0Vg+G
YNTLx0s6695FxEWeoBXn9KdMiKCCf6Ux37u7Gcv/CYGcZx0Dni0nADXVk3/MBkfnT/K+
V9QgUckBYpNaji9Zq4zVcg4BYXiE7jxuf54y4CL8xpgo65MvXDNB4C8+ZErXKOkuacZK
cpQdZEFNcWQpmgyGK0xEcTZvbtQXFbeu10BB/0J8wC3vkfNbQxruvqpm7tqMlSWpewmS
FAaQ==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
k6-20020a50cb86000000b0045c97cb9027si13704093edi.421.2022.10.19.18.50.22;
Wed, 19 Oct 2022 18:50:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231526AbiJTBsL (ORCPT <rfc822;samuel.l.nystrom@gmail.com>
+ 99 others); Wed, 19 Oct 2022 21:48:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40438 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231479AbiJTBsG (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 19 Oct 2022 21:48:06 -0400
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 500F41D2B58;
Wed, 19 Oct 2022 18:48:05 -0700 (PDT)
Received: from canpemm500004.china.huawei.com (unknown [172.30.72.55])
by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Mt9NX6S1yzVhkK;
Thu, 20 Oct 2022 09:43:24 +0800 (CST)
Received: from ubuntu1604.huawei.com (10.67.174.160) by
canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2375.31; Thu, 20 Oct 2022 09:48:02 +0800
From: Xiang Yang <xiangyang3@huawei.com>
To: <mika.westerberg@linux.intel.com>,
<andriy.shevchenko@linux.intel.com>, <linus.walleij@linaro.org>,
<brgl@bgdev.pl>
CC: <linux-gpio@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH -next] gpiolib: acpi: Use METHOD_NAME__AEI macro for
acpi_walk_resources
Date: Thu, 20 Oct 2022 09:44:26 +0800
Message-ID: <20221020014426.188667-1-xiangyang3@huawei.com>
X-Mailer: git-send-email 2.22.0
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=US-ASCII
X-Originating-IP: [10.67.174.160]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
canpemm500004.china.huawei.com (7.192.104.92)
X-CFilter-Loop: Reflected
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747169470384782122?=
X-GMAIL-MSGID: =?utf-8?q?1747169470384782122?=
|
| Series |
[-next] gpiolib: acpi: Use METHOD_NAME__AEI macro for acpi_walk_resources
|
|
Commit Message
Xiang Yang
Oct. 20, 2022, 1:44 a.m. UTC
Using the METHOD_NAME__AEI macro instead of using "_AEI" directly.
Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
---
drivers/gpio/gpiolib-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Oct 20, 2022 at 3:48 AM Xiang Yang <xiangyang3@huawei.com> wrote: > > Using the METHOD_NAME__AEI macro instead of using "_AEI" directly. > > Signed-off-by: Xiang Yang <xiangyang3@huawei.com> > --- > drivers/gpio/gpiolib-acpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > index a7d2358736fe..064ba5150fd4 100644 > --- a/drivers/gpio/gpiolib-acpi.c > +++ b/drivers/gpio/gpiolib-acpi.c > @@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) > if (ACPI_FAILURE(status)) > return; > > - acpi_walk_resources(handle, "_AEI", > + acpi_walk_resources(handle, METHOD_NAME__AEI, > acpi_gpiochip_alloc_event, acpi_gpio); This line dates back to 2018 so why -next in your PATCH tag? That being said - patch applied (unless Andy wants to take it directly). Bart > > mutex_lock(&acpi_gpio_deferred_req_irqs_lock); > -- > 2.22.0 >
On Thu, Oct 20, 2022 at 03:23:27PM +0200, Bartosz Golaszewski wrote: > On Thu, Oct 20, 2022 at 3:48 AM Xiang Yang <xiangyang3@huawei.com> wrote: > > > > Using the METHOD_NAME__AEI macro instead of using "_AEI" directly. > > > > Signed-off-by: Xiang Yang <xiangyang3@huawei.com> > > --- > > drivers/gpio/gpiolib-acpi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > > index a7d2358736fe..064ba5150fd4 100644 > > --- a/drivers/gpio/gpiolib-acpi.c > > +++ b/drivers/gpio/gpiolib-acpi.c > > @@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) > > if (ACPI_FAILURE(status)) > > return; > > > > - acpi_walk_resources(handle, "_AEI", > > + acpi_walk_resources(handle, METHOD_NAME__AEI, > > acpi_gpiochip_alloc_event, acpi_gpio); > > This line dates back to 2018 so why -next in your PATCH tag? This means "for Linux next cycle". It has roots in the net subsystem where it's a requirement to mark each patch either net or net-next, because they have a huge traffic of patches. > That being said - patch applied (unless Andy wants to take it directly). I think I will take it. Care to provide your tag?
On Thu, Oct 20, 2022 at 3:51 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Oct 20, 2022 at 03:23:27PM +0200, Bartosz Golaszewski wrote: > > On Thu, Oct 20, 2022 at 3:48 AM Xiang Yang <xiangyang3@huawei.com> wrote: > > > > > > Using the METHOD_NAME__AEI macro instead of using "_AEI" directly. > > > > > > Signed-off-by: Xiang Yang <xiangyang3@huawei.com> > > > --- > > > drivers/gpio/gpiolib-acpi.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > > > index a7d2358736fe..064ba5150fd4 100644 > > > --- a/drivers/gpio/gpiolib-acpi.c > > > +++ b/drivers/gpio/gpiolib-acpi.c > > > @@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) > > > if (ACPI_FAILURE(status)) > > > return; > > > > > > - acpi_walk_resources(handle, "_AEI", > > > + acpi_walk_resources(handle, METHOD_NAME__AEI, > > > acpi_gpiochip_alloc_event, acpi_gpio); > > > > This line dates back to 2018 so why -next in your PATCH tag? > > This means "for Linux next cycle". It has roots in the net subsystem where > it's a requirement to mark each patch either net or net-next, because they > have a huge traffic of patches. > > > That being said - patch applied (unless Andy wants to take it directly). > > I think I will take it. Care to provide your tag? > Just take it, I will back it out. Bartosz
On Thu, Oct 20, 2022 at 04:30:27PM +0200, Bartosz Golaszewski wrote: > On Thu, Oct 20, 2022 at 3:51 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Thu, Oct 20, 2022 at 03:23:27PM +0200, Bartosz Golaszewski wrote: ... > > I think I will take it. Care to provide your tag? > > Just take it, I will back it out. Pushed to my review and testing queue, thanks!
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c index a7d2358736fe..064ba5150fd4 100644 --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -512,7 +512,7 @@ void acpi_gpiochip_request_interrupts(struct gpio_chip *chip) if (ACPI_FAILURE(status)) return; - acpi_walk_resources(handle, "_AEI", + acpi_walk_resources(handle, METHOD_NAME__AEI, acpi_gpiochip_alloc_event, acpi_gpio); mutex_lock(&acpi_gpio_deferred_req_irqs_lock);