diff mbox series

[RESEND] block, bfq: remove unused variable for bfq_queue

Message ID 20221018030139.159-1-Yuwei.Guan@zeekrlife.com
State New
Headers
Series [RESEND] block, bfq: remove unused variable for bfq_queue |

Commit Message

Yuwei Guan Oct. 18, 2022, 3:01 a.m. UTC 
  it defined in d0edc2473be9d, but there's nowhere to use it,
so remove it.

Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
Acked-by: Paolo Valente <paolo.valente@linaro.org>
---
 block/bfq-iosched.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

Yuwei Guan Oct. 20, 2022, 11:43 a.m. UTC | #1 
Hi Jens,

On 2022/10/18 11:01, Yuwei Guan wrote:
> it defined in d0edc2473be9d, but there's nowhere to use it,
> so remove it.
>
> Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
> Acked-by: Paolo Valente <paolo.valente@linaro.org>
> ---
>   block/bfq-iosched.h | 4 ----
>   1 file changed, 4 deletions(-)

Can you help to check this patch again?

Thanks

> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> index 64ee618064ba..71f721670ab6 100644
> --- a/block/bfq-iosched.h
> +++ b/block/bfq-iosched.h
> @@ -369,12 +369,8 @@ struct bfq_queue {
>   	unsigned long split_time; /* time of last split */
>   
>   	unsigned long first_IO_time; /* time of first I/O for this queue */
> -
>   	unsigned long creation_time; /* when this queue is created */
>   
> -	/* max service rate measured so far */
> -	u32 max_service_rate;
> -
>   	/*
>   	 * Pointer to the waker queue for this queue, i.e., to the
>   	 * queue Q such that this queue happens to get new I/O right
Jens Axboe Oct. 20, 2022, 12:47 p.m. UTC | #2 
On Tue, 18 Oct 2022 11:01:39 +0800, Yuwei Guan wrote:
> it defined in d0edc2473be9d, but there's nowhere to use it,
> so remove it.
> 
> 

Applied, thanks!

[1/1] block, bfq: remove unused variable for bfq_queue
      commit: 33566f92cd5f1c1d462920978f6dc102c744270d

Best regards,
diff mbox series

Patch

diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
index 64ee618064ba..71f721670ab6 100644
--- a/block/bfq-iosched.h
+++ b/block/bfq-iosched.h
@@ -369,12 +369,8 @@  struct bfq_queue {
 	unsigned long split_time; /* time of last split */
 
 	unsigned long first_IO_time; /* time of first I/O for this queue */
-
 	unsigned long creation_time; /* when this queue is created */
 
-	/* max service rate measured so far */
-	u32 max_service_rate;
-
 	/*
 	 * Pointer to the waker queue for this queue, i.e., to the
 	 * queue Q such that this queue happens to get new I/O right