Message ID | 20221020090547.398680-1-cui.jinpeng2@zte.com.cn |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp146038wrs; Thu, 20 Oct 2022 02:06:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5/Qiu0I42/JPIHo5YNl3OoWD6XvnSb2SDBkW2vrzcgH9+Qf/vZldQLyrAZpu/nTxS50rOC X-Received: by 2002:a17:907:3d91:b0:78d:f675:5659 with SMTP id he17-20020a1709073d9100b0078df6755659mr9916158ejc.92.1666256801375; Thu, 20 Oct 2022 02:06:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666256801; cv=none; d=google.com; s=arc-20160816; b=Rn5neUNLX/MIBnFxCZ0CP1kVaVQIFOZ2NYtCn0qVj5To3zzCdgPh4T7iYOX0RfFiuH OzgOO/6naTU400b2vofnHcutwtRFr1EIgwSaNmdF/L0SWaLf5bBnhkV7Vh6J5g/b8fFr F+j0RqzIKLYn/P6FjnEW1L0ZE17f4ZP9zyjdGpXB/ISE4KtzLvlqWApJUMfgtydpowti a6J9uRt4IxpDHqQvXVPsPErulbEk1BPaYqcYPC6u5y2ALTSEas+9J5b5ifMuTbnuUi0A ek/hjSLk/qZVsFrG0kBTC9B7GiF9tA6g6WMuRuvSsDGQuzNnuLJ8ZORW92M9a8h5vm0r cvLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7o3DdS6QAF9bYcwYa9OQ8LlTpX2ZcGANydX8jAzYar4=; b=hkoOhx9zBVzWeB60IeIZtpUfy23cVEX8XrXMNMwQvaUUoRrWlQyRXBd5UE/1yqAscY ZsmMx3r0wFEXTgYPi71kVEJGdKt3ia3x0UIjATv1VbpgmtYac+0QSZprRnRF/EN3705C vMAT+P4TX42XV+FRmOWxCJAY/OIqclLK+LCeRDFJDbRK4AQeY21jACZwB6y5Ty987tJl 9/wbNE6mgYlrN7SFcy9RBizxJElVgBU2F1LI3mmmdIwbTXfcGCZdaN/yhNKo877GVlVh 1plE6GxvqbBDiUogX9ATQ5uVd98JjwXaQentOiLYGKbgVSy4YvE907m+XpYhLShABk26 4hWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TLZ04qDs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p21-20020a170906785500b0077bc1269f8esi14137976ejm.424.2022.10.20.02.06.16; Thu, 20 Oct 2022 02:06:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=TLZ04qDs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230208AbiJTJGC (ORCPT <rfc822;realc9580@gmail.com> + 99 others); Thu, 20 Oct 2022 05:06:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbiJTJGA (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 20 Oct 2022 05:06:00 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 526C017C558; Thu, 20 Oct 2022 02:05:54 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id d24so19723934pls.4; Thu, 20 Oct 2022 02:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7o3DdS6QAF9bYcwYa9OQ8LlTpX2ZcGANydX8jAzYar4=; b=TLZ04qDs5Zy8Zg0EhnSXGWOdoORY56Fwy/FrJit+9mwSG6BzgNClx6P/rXbJkjPzqi JT+57SRFD2qlquqvNl8YQnuAEsPm+2vcDmUCXKPq6ozQVgN7QTaGqEtbw0kTd/7th8Ab bF1Pz5OhPicdX55adPsAQFZ71susRlr9EG/0BK13uc0nZ2yIcYrZmFytHcaNHaUOXQkL 1V+CdI8a21467V+T8blGn7Y3ToAe7sktnmsr1sVVqkyR5DLgMUuXmqvarECR+i9xxaBI D71miwyiPJALc+l6auuQjYstDpWMCFjOpxlRcehtmmAXhGt9+3L9Rhgk8n0fUnHpSUxu xE2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7o3DdS6QAF9bYcwYa9OQ8LlTpX2ZcGANydX8jAzYar4=; b=tr+zuSDdZC94Y0vr+j7VFkvaji8ctEQ7a05R/acVIq9T6tOC9ZmgI+0ByRHrqAX0As FPCbhwTuCQmJ0cSSykch/SMT2RlI6KptZtO82W6gnpVDkBNZYOdJrPxqwSJ+n1p+zStj LUPtk6sabs/bDUTA1SyEZUhrvWS4cMRtTblWBdzkuHNN6UQ2jw0lhHKZzoO6U/pHsjhA /Q8ghRD4VUNYdwrLZvJe8yI54iuYGR9p6LrW19YtmvXwKG/4xgL3Ta+nYKddFMKNjSVg TgSMlsQwxVFC1PFrm5iuS9MY5trUWwiVNRv8b29qeACtc2a9eu+VHf4E5A/fzo+gPZPO K6TQ== X-Gm-Message-State: ACrzQf01t3vmO3RiSQfVQzYFlDydEIo7KY4fRCH7C+KqywO6ievkKDVi Yfm/PGJghwHh2LCv6NqRbiw= X-Received: by 2002:a17:90b:4f4e:b0:20d:9f5b:abbf with SMTP id pj14-20020a17090b4f4e00b0020d9f5babbfmr15378166pjb.148.1666256753196; Thu, 20 Oct 2022 02:05:53 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id w24-20020aa79558000000b00562adc8b6d3sm12642653pfq.193.2022.10.20.02.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 02:05:52 -0700 (PDT) From: cuijinpeng666@gmail.com X-Google-Original-From: cui.jinpeng2@zte.com.cn To: ast@kernel.org, keescook@chromium.org, jolsa@kernel.org, cui.jinpeng2@zte.com.cn Cc: peterz@infradead.org, stephen.s.brennan@oracle.com, alan.maguire@oracle.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Zeal Robot <zealci@zte.com.cn> Subject: [PATCH linux-next] kallsyms: Use strscpy() instead of strlcpy() Date: Thu, 20 Oct 2022 09:05:47 +0000 Message-Id: <20221020090547.398680-1-cui.jinpeng2@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747196891914755795?= X-GMAIL-MSGID: =?utf-8?q?1747196891914755795?= |
Series |
[linux-next] kallsyms: Use strscpy() instead of strlcpy()
|
|
Commit Message
cuijinpeng666@gmail.com
Oct. 20, 2022, 9:05 a.m. UTC
From: Jinpeng Cui <cui.jinpeng2@zte.com.cn> The implementation of strscpy() is more robust and safer. Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn> --- kernel/kallsyms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Thu, Oct 20, 2022 at 09:05:47AM +0000, cuijinpeng666@gmail.com wrote: > From: Jinpeng Cui <cui.jinpeng2@zte.com.cn> > > The implementation of strscpy() is more robust and safer. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn> Again, please stop. I have told you, and others who are purporting to send patches from ZTE to please stop using gmail.com addresses as there is no way to verify that you really are from ZTE. You are potentially lying about who you are here, which is not allowed in kernel development for obvious reasons. Also, these email addresses are "one way only" with no responses ever being recieved, and so they have been banned from vger mailing lists. I will go ask this one to be banned as well. Please work with your employer to get their email settings fixed up so that you can properly send patches. Do NOT abuse gmail for this as that's not ok. greg k-h
On Thu, Oct 20, 2022 at 08:27:39PM +0800, jinpeng Cui wrote: > Hello,Please do not ban my private account cuijinpeng666@gmail.com Sorry, that has already happened. > I am very sorry if the patches from zte.com.cn > in the past few months have made you angry, > we have decided to fix the problem you pointed out > as soon as possible. > Our company's mailbox name@zte.com.cn > cannot send emails to the external network, > so we use name@gmail.com to send patches; You all have been warned numerous times over many weeks and months and never responded to our emails. We have no proof that using gmail accounts is actually coming from a ZTE employee, so until that happens, we can not take your changes (not to mention the basic fact that you all keep ignoring our review comments, which is a good enough reason to ignore them.) Please fix your email systems. Also, do not attempt to send html emails (like this one), as the lists by default, reject them as you know. greg k-h
On Thu, Oct 20, 2022 at 02:43:52PM +0200, Greg KH wrote: > > I am very sorry if the patches from zte.com.cn > > in the past few months have made you angry, > > we have decided to fix the problem you pointed out > > as soon as possible. > > Our company's mailbox name@zte.com.cn > > cannot send emails to the external network, > > so we use name@gmail.com to send patches; > > You all have been warned numerous times over many weeks and months and > never responded to our emails. > > We have no proof that using gmail accounts is actually coming from a ZTE > employee, so until that happens, we can not take your changes (not to > mention the basic fact that you all keep ignoring our review comments, > which is a good enough reason to ignore them.) Aren't there a few solutions here? 1) Just send the emails from @gmail with matching S-o-b. 2) Send an @zte.com.cn to lkml to confirm their @gmail/@zte.com.cn mapping. 3) Fix the email systems.
On Fri, Oct 21, 2022 at 09:17:10AM -0700, Kees Cook wrote: > On Thu, Oct 20, 2022 at 02:43:52PM +0200, Greg KH wrote: > > > I am very sorry if the patches from zte.com.cn > > > in the past few months have made you angry, > > > we have decided to fix the problem you pointed out > > > as soon as possible. > > > Our company's mailbox name@zte.com.cn > > > cannot send emails to the external network, > > > so we use name@gmail.com to send patches; > > > > You all have been warned numerous times over many weeks and months and > > never responded to our emails. > > > > We have no proof that using gmail accounts is actually coming from a ZTE > > employee, so until that happens, we can not take your changes (not to > > mention the basic fact that you all keep ignoring our review comments, > > which is a good enough reason to ignore them.) > > Aren't there a few solutions here? > > 1) Just send the emails from @gmail with matching S-o-b. As we know these developers are claiming to be from a company that we can not confirm they are actually working for, no, we can't take their contributions as that goes against the DCO (anonymous contributions). > 2) Send an @zte.com.cn to lkml to confirm their @gmail/@zte.com.cn mapping. That would be great, but so far no one that I have contacted from ZTE has been able to confirm that these are actually ZTE developers. > 3) Fix the email systems. That would be the best thing for them to do, and would solve the problem for everyone at their company. Hopefully that happens soon. thanks, greg k-h
diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c index cc244c02b4cf..639de60ed417 100644 --- a/kernel/kallsyms.c +++ b/kernel/kallsyms.c @@ -660,7 +660,7 @@ static int get_ksymbol_bpf(struct kallsym_iter *iter) { int ret; - strlcpy(iter->module_name, "bpf", MODULE_NAME_LEN); + strscpy(iter->module_name, "bpf", MODULE_NAME_LEN); iter->exported = 0; ret = bpf_get_kallsym(iter->pos - iter->pos_ftrace_mod_end, &iter->value, &iter->type, @@ -680,7 +680,7 @@ static int get_ksymbol_bpf(struct kallsym_iter *iter) */ static int get_ksymbol_kprobe(struct kallsym_iter *iter) { - strlcpy(iter->module_name, "__builtin__kprobes", MODULE_NAME_LEN); + strscpy(iter->module_name, "__builtin__kprobes", MODULE_NAME_LEN); iter->exported = 0; return kprobe_get_kallsym(iter->pos - iter->pos_bpf_end, &iter->value, &iter->type,