Message ID | 20230118135259.19249-1-fabrizio.castro.jz@renesas.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2361130wrn; Wed, 18 Jan 2023 06:16:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXutbPZuv/kEj0x2ODH0RKO6NdlkOjXy/1zOJ+VTHCrQtjs4Uzl4R6GP6o1b1JskqUSCpUQ6 X-Received: by 2002:a17:90a:86cb:b0:229:8344:2a65 with SMTP id y11-20020a17090a86cb00b0022983442a65mr7107667pjv.20.1674051381046; Wed, 18 Jan 2023 06:16:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674051381; cv=none; d=google.com; s=arc-20160816; b=i3qXP5JbTgucI1SqfdmixR+DpcOfM8WEUjIgWAfHmjcxXCTYy/gux+hdXnbjLBkDXp RbVA1K/lmoCitN7wW6qIyERSFrv9MMIYkFTj4jqp/uVZZLXhjHj5JAIHJ38yj2Ki0Ec5 AD4YAMk1obv6AE0rVkfCm/LoQi7G7gybiWg007YhmYWbTHWz8HWhDzss3gn36q04Apcv +7LIMNCwekf+oXt8jOySy6xVQII9WivKYWR2wiWlmrGtXBHHraCvYmSM4J91rYKtyxO3 QApfGdm8GZJVKVSD1O8kf0fjhW0+X+Ro4OkAWjvyqLAZUJiCAQSDTDzUSDS5JkA3s0a4 yxrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ls7wPEkVIzGEoNdovvl8OqDbLcgKMua5Op+kNgmA+2M=; b=UVpO/sq5wZCpBV/SHM9RRke6zDkBYpVhyZoyrzbI6hlSEHAZer0SZ9IUyV+dq6S6l3 EbZMsloBdzd9ED+EcOJqodhV/ABEaQbxezhAVNqVG3P2y8+eowxjPfqP5573QKljij1C LxT2sHDLJYUctbgaZXMNHE9lp+wS9wVX2NfT5XBgUjVGZwRZWxpw8e0BtC0AaRLXOt7z An7xYiHC7ilNRn1YgWTMOrIyx/EGd6CT3t3190rJDASQodP6KgPZU0TdPZqRuh27OSJP k/XE6grEoTLZ4D4/WFmpmLvn/1s8XTXzYEPZpyBLVvkMLsaBxGzu+XUEHjJrf0WYwwaL iEGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a6-20020a17090a854600b002239c987051si2110697pjw.128.2023.01.18.06.16.08; Wed, 18 Jan 2023 06:16:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbjAROM3 (ORCPT <rfc822;pfffrao@gmail.com> + 99 others); Wed, 18 Jan 2023 09:12:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbjAROMO (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 18 Jan 2023 09:12:14 -0500 Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A5EA58A0DB; Wed, 18 Jan 2023 05:53:25 -0800 (PST) X-IronPort-AV: E=Sophos;i="5.97,226,1669042800"; d="scan'208";a="146743313" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 18 Jan 2023 22:53:24 +0900 Received: from mulinux.example.org (unknown [10.226.93.55]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 1D52A438EEA8; Wed, 18 Jan 2023 22:53:20 +0900 (JST) From: Fabrizio Castro <fabrizio.castro.jz@renesas.com> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be> Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>, Magnus Damm <magnus.damm@gmail.com>, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Paterson <Chris.Paterson2@renesas.com>, Biju Das <biju.das@bp.renesas.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Jacopo Mondi <jacopo@jmondi.org> Subject: [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status Date: Wed, 18 Jan 2023 13:52:59 +0000 Message-Id: <20230118135259.19249-1-fabrizio.castro.jz@renesas.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=AC_FROM_MANY_DOTS,BAYES_00, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755370100682423623?= X-GMAIL-MSGID: =?utf-8?q?1755370100682423623?= |
Series |
arm64: dts: renesas: r9a09g011: Reword ethernet status
|
|
Commit Message
Fabrizio Castro
Jan. 18, 2023, 1:52 p.m. UTC
Although of_fdt_device_is_available returns true when the DT
property "status" is assigned "ok" or "okay", and false for every
other value, it's become common practice to assign "disabled"
when we want of_fdt_device_is_available to return false.
For some reason, the status property of the ethernet node was
assigned "disable" when originally added to the kernel. Change
it to "disabled" for consistency.
Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Fabrizio, Thank you for the patch. On Wed, Jan 18, 2023 at 01:52:59PM +0000, Fabrizio Castro wrote: > Although of_fdt_device_is_available returns true when the DT > property "status" is assigned "ok" or "okay", and false for every > other value, it's become common practice to assign "disabled" > when we want of_fdt_device_is_available to return false. > For some reason, the status property of the ethernet node was > assigned "disable" when originally added to the kernel. Change > it to "disabled" for consistency. > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi > index dd35a8ff72ee..b0c066c5e0ba 100644 > --- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi > @@ -165,7 +165,7 @@ avb: ethernet@a3300000 { > power-domains = <&cpg>; > #address-cells = <1>; > #size-cells = <0>; > - status = "disable"; > + status = "disabled"; > }; > > cpg: clock-controller@a3500000 {
On Wed, Jan 18, 2023 at 2:53 PM Fabrizio Castro <fabrizio.castro.jz@renesas.com> wrote: > Although of_fdt_device_is_available returns true when the DT > property "status" is assigned "ok" or "okay", and false for every > other value, it's become common practice to assign "disabled" > when we want of_fdt_device_is_available to return false. > For some reason, the status property of the ethernet node was > assigned "disable" when originally added to the kernel. Change > it to "disabled" for consistency. > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi index dd35a8ff72ee..b0c066c5e0ba 100644 --- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi @@ -165,7 +165,7 @@ avb: ethernet@a3300000 { power-domains = <&cpg>; #address-cells = <1>; #size-cells = <0>; - status = "disable"; + status = "disabled"; }; cpg: clock-controller@a3500000 {