Message ID | 20230104-topic-sm8550-upstream-dts-display-v3-3-46f0d4e57752@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2238320wrn; Wed, 18 Jan 2023 01:43:54 -0800 (PST) X-Google-Smtp-Source: AMrXdXsQefMVNBVaUGMo3xTQbBtdGUBaPsb5/92n2qyl1QEtPLc3rKckCRnHoiwJzbP2bfnwT33a X-Received: by 2002:a17:90b:2347:b0:226:d727:4045 with SMTP id ms7-20020a17090b234700b00226d7274045mr6515778pjb.24.1674035033986; Wed, 18 Jan 2023 01:43:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674035033; cv=none; d=google.com; s=arc-20160816; b=dH9B9GwUwh1RPu5qxV6sP5jhP0vJL4HZYyVnxY0V32jeIRQokZiQvga+pyN1WQCUj+ pf99XhHT/KAmxKNFrEx/ar3JT4DnTk/zdM0igvOkHCllpo45BvylGRAUBuGyPD2pDBZT 0ooOwdBN8ymQ4Z9Kz8eKKkl34R3WDiWU3iGg9sUp6ZrhTp3Gk9G51iYsZ/9KXgTvEo1h SC05biHE+rVFbzQVv+l91dRKhsv5O65pw4qNrryq2+Cig1Q/AyNcdHZyCzmWYCXJLY1x qjdIflVV6aphi0NlFDWamt1ugZJ8SFz9M4J4DcxcZe8LIgh7o1RxjxSncO1dgTzaVArH rsvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=FOKB9Zz+BjKJBFcDfmkLVcFXEHvkL9mnlnuKcHLTRsg=; b=zgzYrmKtpcUOBpAhQxUzpa6EjpWD5zRydVBOK89amDsYQnNmZ96oj1dkkMycYlOBzq LY5dM5jfOzmbBsjAYJp1HrjPhp6Lz7Fw0TWJSCjIxWs1jqsf3ue7oZEcVvrgyfEJHfXT vhfsffxETXZuSQ7rXjOnOANjiu8ZDSFsU4S4/S27a9BfUqErRJp8tBL/mA09kTJGFjHv OEqUKlj+zq9spik49nPUQkqLN1hRsL1o2xt+xjOq8SdxKKnWIo7+qg5JFOqKcikVmUcS ItnbEc1NlLQfsCwjvOzd5hfEYz7d967VpCs0kx13g3tNcx4G5HRQHluHOQvV/GlE0IlJ B/Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E9cUKJNb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a9-20020a63bd09000000b0046066611352si35319788pgf.502.2023.01.18.01.43.42; Wed, 18 Jan 2023 01:43:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E9cUKJNb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229987AbjARJmp (ORCPT <rfc822;pfffrao@gmail.com> + 99 others); Wed, 18 Jan 2023 04:42:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230037AbjARJhn (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 18 Jan 2023 04:37:43 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FF9E8384F for <linux-kernel@vger.kernel.org>; Wed, 18 Jan 2023 00:55:41 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id b5so12003374wrn.0 for <linux-kernel@vger.kernel.org>; Wed, 18 Jan 2023 00:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FOKB9Zz+BjKJBFcDfmkLVcFXEHvkL9mnlnuKcHLTRsg=; b=E9cUKJNbBt3kwhbAOHI/CKd/4LCSpmmFhwW8qWI/VDUttqRocQCEa9JVuLfay5eBuu dGimKeTUO3BOFmsKR+9g29MH2WymQrSi5PuuW7BxhE5z7IZ7GsjRRFfNgd3dQmMhEmqp xSzrUBgcuJZLNPvmmz5OkfG645D22DzlfEKEmAdQTvfXTL68bzN/hEgXH4uJ7vuNf19+ IZxOMtumplXAPfwLx9kc+UWUjt3wGi4NvhbBmTbiuKpiex8nKOf23QrU5elXhviaAj0o RfFe1m7jL7CSgYWQ70n47W3pEhfI3iMMYu6ZyMAb+9dHa31qsg4tLhnHJNsTOKsopkF8 uuYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FOKB9Zz+BjKJBFcDfmkLVcFXEHvkL9mnlnuKcHLTRsg=; b=PINGfd8lVWrI0F+PqyOllGpuEoWDK7HDKaVft/kWGX7Xm9DCXLJfAswikjQ8GXE5nB iI3GIjQTZW6n105nxaX4XKeBbnFfbYemaROfBdzzYiRiEs0dQi8lieFycnyr6zcvgi1h zbvprEUejQaMgYqldsKtWOHjEnyxf7IXDcD+Fc9aEIL6coh5NIbHeztHJfPmbMDWrhp+ 81KI+HxUP4bGi/WcvYTq7Ri4dApbjtEhjTQzkAnYho+3d1qOb9IOWOGr4tQYN6IaXh2R lYorP2ztWiri9+brqrqlWT5zX4l8r1nEQqAtOgo+BLQ3/7hr6fW0uz/haEJLgnJgGBhd ZDhQ== X-Gm-Message-State: AFqh2kpqkPIuLt9rG5sYNqz5rD6zZo4ymnOqON5HODkk9XvV0QdIE6wE Te0xOc12kXUZptE41VYBo1qATA== X-Received: by 2002:a5d:48c7:0:b0:2bb:ed0c:a0d8 with SMTP id p7-20020a5d48c7000000b002bbed0ca0d8mr5192938wrs.53.1674032139930; Wed, 18 Jan 2023 00:55:39 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id m15-20020adffe4f000000b002bdd155ca4dsm16480212wrs.48.2023.01.18.00.55.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 00:55:39 -0800 (PST) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Wed, 18 Jan 2023 09:55:35 +0100 Subject: [PATCH v3 3/3] arm64: dts: qcom: sm8550-mtp: add DSI panel MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230104-topic-sm8550-upstream-dts-display-v3-3-46f0d4e57752@linaro.org> References: <20230104-topic-sm8550-upstream-dts-display-v3-0-46f0d4e57752@linaro.org> In-Reply-To: <20230104-topic-sm8550-upstream-dts-display-v3-0-46f0d4e57752@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.11.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755352959652997134?= X-GMAIL-MSGID: =?utf-8?q?1755352959652997134?= |
Series |
arm64: dts: qcom: sm8550-mtp: enable DSI panel
|
|
Commit Message
Neil Armstrong
Jan. 18, 2023, 8:55 a.m. UTC
Add nodes for the Visionox VTDR6130 found on the SM8550-MTP
device.
TLMM states are also added for the Panel reset GPIO and
Tearing Effect signal for when the panel is running in
DSI Command mode.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 56 +++++++++++++++++++++++++++++++++
1 file changed, 56 insertions(+)
Comments
On 18/01/2023 09:55, Neil Armstrong wrote: > Add nodes for the Visionox VTDR6130 found on the SM8550-MTP > device. > > TLMM states are also added for the Panel reset GPIO and > Tearing Effect signal for when the panel is running in > DSI Command mode. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 56 +++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 0dfd1d3db86c..2de387aa2c2d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -370,6 +370,34 @@ &mdss { > &mdss_dsi0 { > vdda-supply = <&vreg_l3e_1p2>; > status = "okay"; > + > + panel@0 { > + compatible = "visionox,vtdr6130"; > + reg = <0>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>; > + pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>; > + > + vddio-supply = <&vreg_l12b_1p8>; > + vci-supply = <&vreg_l13b_3p0>; > + vdd-supply = <&vreg_l11b_1p2>; > + > + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; > + > + status = "okay"; No need unless you override existing device node. > + > + port { > + panel0_in: endpoint { > + remote-endpoint = <&mdss_dsi0_out>; > + }; > + }; > + }; > +}; Best regards, Krzysztof
On 18.01.2023 09:55, Neil Armstrong wrote: > Add nodes for the Visionox VTDR6130 found on the SM8550-MTP > device. > > TLMM states are also added for the Panel reset GPIO and > Tearing Effect signal for when the panel is running in > DSI Command mode. > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 56 +++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index 0dfd1d3db86c..2de387aa2c2d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -370,6 +370,34 @@ &mdss { > &mdss_dsi0 { > vdda-supply = <&vreg_l3e_1p2>; > status = "okay"; > + > + panel@0 { > + compatible = "visionox,vtdr6130"; > + reg = <0>; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>; > + pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>; Hm.. I've just realized there are two styles of specifying phandle arrays: <&a &b> and <&a>, <&b>.. even worse, we have both of them in our tree.. Krzysztof, Bjorn, which one should we go with, going forward? > + > + vddio-supply = <&vreg_l12b_1p8>; > + vci-supply = <&vreg_l13b_3p0>; > + vdd-supply = <&vreg_l11b_1p2>; > + > + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; > + > + status = "okay"; Superfluous, it's enabled by default, drop Konrad > + > + port { > + panel0_in: endpoint { > + remote-endpoint = <&mdss_dsi0_out>; > + }; > + }; > + }; > +}; > + > +&mdss_dsi0_out { > + remote-endpoint = <&panel0_in>; > + data-lanes = <0 1 2 3>; > }; > > &mdss_dsi0_phy { > @@ -415,6 +443,34 @@ &sleep_clk { > > &tlmm { > gpio-reserved-ranges = <32 8>; > + > + sde_dsi_active: sde-dsi-active-state { > + pins = "gpio133"; > + function = "gpio"; > + drive-strength = <8>; > + bias-disable; > + }; > + > + sde_dsi_suspend: sde-dsi-suspend-state { > + pins = "gpio133"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + sde_te_active: sde-te-active-state { > + pins = "gpio86"; > + function = "mdp_vsync"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + > + sde_te_suspend: sde-te-suspend-state { > + pins = "gpio86"; > + function = "mdp_vsync"; > + drive-strength = <2>; > + bias-pull-down; > + }; > }; > > &uart7 { >
On 18/01/2023 14:36, Konrad Dybcio wrote: > > > On 18.01.2023 09:55, Neil Armstrong wrote: >> Add nodes for the Visionox VTDR6130 found on the SM8550-MTP >> device. >> >> TLMM states are also added for the Panel reset GPIO and >> Tearing Effect signal for when the panel is running in >> DSI Command mode. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 56 +++++++++++++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> index 0dfd1d3db86c..2de387aa2c2d 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts >> @@ -370,6 +370,34 @@ &mdss { >> &mdss_dsi0 { >> vdda-supply = <&vreg_l3e_1p2>; >> status = "okay"; >> + >> + panel@0 { >> + compatible = "visionox,vtdr6130"; >> + reg = <0>; >> + >> + pinctrl-names = "default", "sleep"; >> + pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>; >> + pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>; > Hm.. I've just realized there are two styles of specifying > phandle arrays: <&a &b> and <&a>, <&b>.. even worse, we > have both of them in our tree.. Krzysztof, Bjorn, which one > should we go with, going forward? I've been cleaning into <&a>, <&b> for the last few years and it clearer since it separates each phandle (+ parameters) in the DTS. Neil > > >> + >> + vddio-supply = <&vreg_l12b_1p8>; >> + vci-supply = <&vreg_l13b_3p0>; >> + vdd-supply = <&vreg_l11b_1p2>; >> + >> + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; >> + >> + status = "okay"; > Superfluous, it's enabled by default, drop Ack, will remove > > Konrad >> + >> + port { >> + panel0_in: endpoint { >> + remote-endpoint = <&mdss_dsi0_out>; >> + }; >> + }; >> + }; >> +}; >> + >> +&mdss_dsi0_out { >> + remote-endpoint = <&panel0_in>; >> + data-lanes = <0 1 2 3>; >> }; >> >> &mdss_dsi0_phy { >> @@ -415,6 +443,34 @@ &sleep_clk { >> >> &tlmm { >> gpio-reserved-ranges = <32 8>; >> + >> + sde_dsi_active: sde-dsi-active-state { >> + pins = "gpio133"; >> + function = "gpio"; >> + drive-strength = <8>; >> + bias-disable; >> + }; >> + >> + sde_dsi_suspend: sde-dsi-suspend-state { >> + pins = "gpio133"; >> + function = "gpio"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + >> + sde_te_active: sde-te-active-state { >> + pins = "gpio86"; >> + function = "mdp_vsync"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> + >> + sde_te_suspend: sde-te-suspend-state { >> + pins = "gpio86"; >> + function = "mdp_vsync"; >> + drive-strength = <2>; >> + bias-pull-down; >> + }; >> }; >> >> &uart7 { >>
diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts index 0dfd1d3db86c..2de387aa2c2d 100644 --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts @@ -370,6 +370,34 @@ &mdss { &mdss_dsi0 { vdda-supply = <&vreg_l3e_1p2>; status = "okay"; + + panel@0 { + compatible = "visionox,vtdr6130"; + reg = <0>; + + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sde_dsi_active>, <&sde_te_active>; + pinctrl-1 = <&sde_dsi_suspend>, <&sde_te_suspend>; + + vddio-supply = <&vreg_l12b_1p8>; + vci-supply = <&vreg_l13b_3p0>; + vdd-supply = <&vreg_l11b_1p2>; + + reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; + + status = "okay"; + + port { + panel0_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; +}; + +&mdss_dsi0_out { + remote-endpoint = <&panel0_in>; + data-lanes = <0 1 2 3>; }; &mdss_dsi0_phy { @@ -415,6 +443,34 @@ &sleep_clk { &tlmm { gpio-reserved-ranges = <32 8>; + + sde_dsi_active: sde-dsi-active-state { + pins = "gpio133"; + function = "gpio"; + drive-strength = <8>; + bias-disable; + }; + + sde_dsi_suspend: sde-dsi-suspend-state { + pins = "gpio133"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; + }; + + sde_te_active: sde-te-active-state { + pins = "gpio86"; + function = "mdp_vsync"; + drive-strength = <2>; + bias-pull-down; + }; + + sde_te_suspend: sde-te-suspend-state { + pins = "gpio86"; + function = "mdp_vsync"; + drive-strength = <2>; + bias-pull-down; + }; }; &uart7 {